From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3ADC433EF for ; Tue, 19 Apr 2022 09:29:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FD4E6B00F8; Tue, 19 Apr 2022 05:29:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AC776B00F9; Tue, 19 Apr 2022 05:29:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29B296B00FA; Tue, 19 Apr 2022 05:29:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 1AEE16B00F8 for ; Tue, 19 Apr 2022 05:29:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D0ED321B94 for ; Tue, 19 Apr 2022 09:29:02 +0000 (UTC) X-FDA: 79373104524.22.60EC1D4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 102824000C for ; Tue, 19 Apr 2022 09:29:00 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 317031042; Tue, 19 Apr 2022 02:29:01 -0700 (PDT) Received: from [10.163.40.223] (unknown [10.163.40.223]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 708A43F5A1; Tue, 19 Apr 2022 02:28:52 -0700 (PDT) Message-ID: <1671baf7-046e-7c52-183f-fd654125fd67@arm.com> Date: Tue, 19 Apr 2022 14:59:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH -next v4 1/4] mm: page_table_check: move pxx_user_accessible_page into x86 Content-Language: en-US To: Tong Tiangen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Pasha Tatashin , Andrew Morton , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Kefeng Wang , Guohanjun References: <20220418034444.520928-1-tongtiangen@huawei.com> <20220418034444.520928-2-tongtiangen@huawei.com> From: Anshuman Khandual In-Reply-To: <20220418034444.520928-2-tongtiangen@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 102824000C X-Stat-Signature: njn86hdagyo5tufr14h9t39w7yw7itxb Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam01 X-HE-Tag: 1650360540-276042 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/18/22 09:14, Tong Tiangen wrote: > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -10,6 +10,14 @@ > #undef pr_fmt > #define pr_fmt(fmt) "page_table_check: " fmt > > +#ifndef PMD_PAGE_SIZE > +#define PMD_PAGE_SIZE PMD_SIZE > +#endif > + > +#ifndef PUD_PAGE_SIZE > +#define PUD_PAGE_SIZE PUD_SIZE > +#endif Why cannot PMD_SIZE/PUD_SIZE be used on every platform instead ? What is the need for using PUD_PAGE_SIZE/PMD_PAGE_SIZE ? Are they different on x86 ?