From: Kees Cook <keescook@chromium.org>
To: Tony Luck <tony.luck@intel.com>,
swboyd@chromium.org, anton@enomsg.org, ccross@android.com
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, rppt@kernel.org,
bgeffon@google.com
Subject: Re: [PATCH] pstore: Avoid kcore oops by vmap()ing with VM_IOREMAP
Date: Mon, 5 Dec 2022 16:16:15 -0800 [thread overview]
Message-ID: <167028577239.2860027.4300649046470353371.b4-ty@chromium.org> (raw)
In-Reply-To: <20221205233136.3420802-1-swboyd@chromium.org>
On Mon, 5 Dec 2022 15:31:36 -0800, Stephen Boyd wrote:
> An oops can be induced by running 'cat /proc/kcore > /dev/null' on
> devices using pstore with the ram backend because kmap_atomic() assumes
> lowmem pages are accessible with __va().
>
> Unable to handle kernel paging request at virtual address ffffff807ff2b000
> Mem abort info:
> ESR = 0x96000006
> EC = 0x25: DABT (current EL), IL = 32 bits
> SET = 0, FnV = 0
> EA = 0, S1PTW = 0
> FSC = 0x06: level 2 translation fault
> Data abort info:
> ISV = 0, ISS = 0x00000006
> CM = 0, WnR = 0
> swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000081d87000
> [ffffff807ff2b000] pgd=180000017fe18003, p4d=180000017fe18003, pud=180000017fe18003, pmd=0000000000000000
> Internal error: Oops: 96000006 [#1] PREEMPT SMP
> Modules linked in: dm_integrity
> CPU: 7 PID: 21179 Comm: perf Not tainted 5.15.67-10882-ge4eb2eb988cd #1 baa443fb8e8477896a370b31a821eb2009f9bfba
> Hardware name: Google Lazor (rev3 - 8) (DT)
> pstate: a0400009 (NzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> pc : __memcpy+0x110/0x260
> lr : vread+0x194/0x294
> sp : ffffffc013ee39d0
> x29: ffffffc013ee39f0 x28: 0000000000001000 x27: ffffff807ff2b000
> x26: 0000000000001000 x25: ffffffc0085a2000 x24: ffffff802d4b3000
> x23: ffffff80f8a60000 x22: ffffff802d4b3000 x21: ffffffc0085a2000
> x20: ffffff8080b7bc68 x19: 0000000000001000 x18: 0000000000000000
> x17: 0000000000000000 x16: 0000000000000000 x15: ffffffd3073f2e60
> x14: ffffffffad588000 x13: 0000000000000000 x12: 0000000000000001
> x11: 00000000000001a2 x10: 00680000fff2bf0b x9 : 03fffffff807ff2b
> x8 : 0000000000000001 x7 : 0000000000000000 x6 : 0000000000000000
> x5 : ffffff802d4b4000 x4 : ffffff807ff2c000 x3 : ffffffc013ee3a78
> x2 : 0000000000001000 x1 : ffffff807ff2b000 x0 : ffffff802d4b3000
> Call trace:
> __memcpy+0x110/0x260
> read_kcore+0x584/0x778
> proc_reg_read+0xb4/0xe4
>
> [...]
Applied to for-next/pstore, thanks!
[1/1] pstore: Avoid kcore oops by vmap()ing with VM_IOREMAP
https://git.kernel.org/kees/c/e6b842741b4f
--
Kees Cook
prev parent reply other threads:[~2022-12-06 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 23:31 Stephen Boyd
2022-12-06 0:16 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167028577239.2860027.4300649046470353371.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=anton@enomsg.org \
--cc=bgeffon@google.com \
--cc=ccross@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patches@lists.linux.dev \
--cc=rppt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox