From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97220C4332F for ; Fri, 2 Dec 2022 21:58:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DE1D6B0071; Fri, 2 Dec 2022 16:58:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38EE66B0072; Fri, 2 Dec 2022 16:58:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22F7A6B0074; Fri, 2 Dec 2022 16:58:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17B7B6B0071 for ; Fri, 2 Dec 2022 16:58:35 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE26716162C for ; Fri, 2 Dec 2022 21:58:34 +0000 (UTC) X-FDA: 80198730948.19.1B9815E Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 7A168100005 for ; Fri, 2 Dec 2022 21:58:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ivPcOYRK; spf=pass (imf05.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670018314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8yjeqd6Koufe4qTZvRhQnhZFfJ1y5qbmqZ7QZG+tZQU=; b=n0wPd6JTlFqvhhxt6F91lxLhXnwYgJHSlpBf2880WYc3svVwDlNCoWoCZNuX8V7qPiPM8u Cl+ifovWhY9+4O+aobxUBdox62GynUazmR88wb4/KW4S/u0YlU3763+TrKjzlfVAP1Mr+Z G9En5KN3w6bcc+LnTlw6tEBCCmvAmsU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ivPcOYRK; spf=pass (imf05.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670018314; a=rsa-sha256; cv=none; b=AdTyi98xd2fSub6YFnJBNbitfUnvrJZAURuXAge8x6g3oz5nVpYWnSDcDlSDKv49zFf/Px s+JRbHWVhGzP9vDMO7NI+XMYi2/q3W3pCX5FJF5ZPlgkcLgxERwyJOfgAd5r/xOq+iPAYm Qo1wnXiSrpj/XNq8hCNZfoSHR3/jt1w= Received: by mail-pg1-f172.google.com with SMTP id 82so5488669pgc.0 for ; Fri, 02 Dec 2022 13:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8yjeqd6Koufe4qTZvRhQnhZFfJ1y5qbmqZ7QZG+tZQU=; b=ivPcOYRK1NdgChB66zDMvb7VWcDjKkliBxnnUq6YWmj8wckt4Pb4FG87vPB66UKOgv xv8mVe6PnQdADgDRE7YQHIBvedXy5bpLa0HSdOjOTNBBq/YgT3mkO8CvA8tmf/cpUVkZ gHNVQu0qhiaEhbzzG/+nBGT3f+FgCcjAVhXGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8yjeqd6Koufe4qTZvRhQnhZFfJ1y5qbmqZ7QZG+tZQU=; b=B+zLJJJ9dHEzSVvffn1jBXOIboinJNU4OBvdXZThEfLAJeKL4oW7/ZiE4KAsWPj0Wy HtjwsVjXKldul5AP96VxFpHd6yBdl9jNhOGNrQ7sADc4llAz9m7Vuq/ZenBjrn556Lak c6Yl9c7K5fjFbfYjRi2lGY1/Fj0oH8kH1cJCVaSKqOfZdvJmvcso7omLDfKlkLPnUjTl VfXemtJCxdnjJSwj8fL8AJnWe5zSUAhGr4oh8YM6qJot7oiHbIAYM3SLJijh6pYwEO8M z8sdlGeOfJsul5QzMUGBhhvqedQ4coMUh1jA0tk9igEfrc0r3Fqn8sn2GHOUVFM/N+cq uG8w== X-Gm-Message-State: ANoB5pkFj2bCBkgmc1j8yevrNn7iwmw2Elk44nT1CKWu51juxYaP421w SnRXVbKm8reurk2MEd+yqt/4UA== X-Google-Smtp-Source: AA0mqf5o0/pBvKgXcn0gxFd+v3J2yNrQJfZEbKNpSgG+xOC0q9SqNnXxMtCCE/dwQQkrAwC5dH9Sxw== X-Received: by 2002:aa7:8d8f:0:b0:56b:b112:4a16 with SMTP id i15-20020aa78d8f000000b0056bb1124a16mr77220595pfr.66.1670018313432; Fri, 02 Dec 2022 13:58:33 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 32-20020a17090a09a300b00212735c8898sm7026718pjo.30.2022.12.02.13.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 13:58:32 -0800 (PST) From: Kees Cook To: ebiederm@xmission.com, liushixin2@huawei.com, Al Viro Cc: Kees Cook , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] binfmt_misc: fix shift-out-of-bounds in check_special_flags Date: Fri, 2 Dec 2022 13:58:29 -0800 Message-Id: <167001830861.1882545.11740816202645494659.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221102025123.1117184-1-liushixin2@huawei.com> References: <20221102025123.1117184-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7A168100005 X-Rspam-User: X-Stat-Signature: wgme7ayskypi93eh8dxbsu7ged8qzk4z X-Spamd-Result: default: False [1.16 / 9.00]; SORBS_IRL_BL(3.00)[209.85.215.172:from]; BAYES_HAM(-2.94)[91.46%]; SUBJECT_HAS_UNDERSCORES(1.00)[]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[chromium.org:+]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_THREE(0.00)[3]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-HE-Tag: 1670018314-483226 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Nov 2022 10:51:23 +0800, Liu Shixin wrote: > UBSAN reported a shift-out-of-bounds warning: > > left shift of 1 by 31 places cannot be represented in type 'int' > Call Trace: > > __dump_stack lib/dump_stack.c:88 [inline] > dump_stack_lvl+0x8d/0xcf lib/dump_stack.c:106 > ubsan_epilogue+0xa/0x44 lib/ubsan.c:151 > __ubsan_handle_shift_out_of_bounds+0x1e7/0x208 lib/ubsan.c:322 > check_special_flags fs/binfmt_misc.c:241 [inline] > create_entry fs/binfmt_misc.c:456 [inline] > bm_register_write+0x9d3/0xa20 fs/binfmt_misc.c:654 > vfs_write+0x11e/0x580 fs/read_write.c:582 > ksys_write+0xcf/0x120 fs/read_write.c:637 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x34/0x80 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > RIP: 0033:0x4194e1 > > [...] Applied to for-next/execve, thanks! [1/1] binfmt_misc: fix shift-out-of-bounds in check_special_flags https://git.kernel.org/kees/c/6a46bf558803 -- Kees Cook