From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EF2C4332F for ; Fri, 2 Dec 2022 01:21:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B970F6B0073; Thu, 1 Dec 2022 20:21:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B473A6B0074; Thu, 1 Dec 2022 20:21:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EAB36B0075; Thu, 1 Dec 2022 20:21:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8BE0D6B0073 for ; Thu, 1 Dec 2022 20:21:13 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5E4DF1605FB for ; Fri, 2 Dec 2022 01:21:13 +0000 (UTC) X-FDA: 80195612826.18.ADE0840 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf21.hostedemail.com (Postfix) with ESMTP id B24811C000D for ; Fri, 2 Dec 2022 01:21:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of wangyufen@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangyufen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669944073; a=rsa-sha256; cv=none; b=bPQyJskNU8s46Icd/vwN/fS52+JHzuwrDoCwiSJEYbGeenG8hyws5fHkq2xYQFVmpYtQOu SC8Opx/kzrXtccBPOuMiQlENCeWO41N+H6H/AqRW743PMENJO8vuvrGJyISUWe/GUPwajH ydcTAjfnbXClK2ANz+Rm5gJKx9k1tIQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of wangyufen@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangyufen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669944073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=3BZBGGkttVJ4zmozy6MT/6IeNZBc8vsW11feLxT97zs=; b=sDCMX1AKUTHOjJtJrw4Jnc+IzTemcxxNLNE8moIwwU3N/9twDF4Nryriwo+2kYTgxag8NS ge+3hGxRZxl26M4rgmO9OhA+jCt83Mj+308uZGApFyg0FOKkMVKJwi2zPy6HTjJUyYoJd4 7gE/epGq/YGkAKjQz+akz8hB/1c01Tc= Received: from canpemm500010.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NNZr62VBVz15N3G; Fri, 2 Dec 2022 09:20:22 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 2 Dec 2022 09:21:04 +0800 From: Wang Yufen To: , , CC: , , Wang Yufen Subject: [PATCH] binfmt: Fix error return code in load_elf_fdpic_binary() Date: Fri, 2 Dec 2022 09:41:01 +0800 Message-ID: <1669945261-30271-1-git-send-email-wangyufen@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.70] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500010.china.huawei.com (7.192.105.118) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B24811C000D X-Stat-Signature: 4jjd81migwu15gt7agxot7ngwsyfidxy X-Spamd-Result: default: False [-0.66 / 9.00]; BAYES_HAM(-1.96)[94.84%]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[huawei.com,quarantine]; R_SPF_ALLOW(-0.20)[+ip4:45.249.212.255]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; MIME_TRACE(0.00)[0:+]; HAS_XOIP(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspam-User: X-HE-Tag: 1669944071-121269 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Fix to return a negative error code from create_elf_fdpic_tables() instead of 0. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Wang Yufen --- fs/binfmt_elf_fdpic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index 08d0c87..9ce5e1f 100644 --- a/fs/binfmt_elf_fdpic.c +++ b/fs/binfmt_elf_fdpic.c @@ -434,8 +434,9 @@ static int load_elf_fdpic_binary(struct linux_binprm *bprm) current->mm->start_stack = current->mm->start_brk + stack_size; #endif - if (create_elf_fdpic_tables(bprm, current->mm, - &exec_params, &interp_params) < 0) + retval = create_elf_fdpic_tables(bprm, current->mm, &exec_params, + &interp_params); + if (retval < 0) goto error; kdebug("- start_code %lx", current->mm->start_code); -- 1.8.3.1