From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B145CC38A2D for ; Tue, 25 Oct 2022 22:25:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 408DC8E0001; Tue, 25 Oct 2022 18:25:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B8578E0006; Tue, 25 Oct 2022 18:25:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 289FD8E0001; Tue, 25 Oct 2022 18:25:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19BD48E0001 for ; Tue, 25 Oct 2022 18:25:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E838CA06F8 for ; Tue, 25 Oct 2022 22:25:31 +0000 (UTC) X-FDA: 80060904462.12.628B2D2 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf08.hostedemail.com (Postfix) with ESMTP id 8E35A160003 for ; Tue, 25 Oct 2022 22:25:31 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id y13so8820770pfp.7 for ; Tue, 25 Oct 2022 15:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bfUwPkkWvWRH7D0jic4UzLRvzXiFnNnqQdHiOc474w4=; b=X81xPrHAJB8kKGIX9N34GO+pUJhjd0vTSsPqLbXZPbnwjhw78RSFkKX/ieyem911R5 vn0YP9brTjXp2CKcqAxTTuhsFkGMkkbJSeJal6bAZHaMdMnU4oL5F7ZaV6+sbUjQOBsF e8mfAG7nfu7SJUEleArdeEKViZFX4gjE+8yY0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bfUwPkkWvWRH7D0jic4UzLRvzXiFnNnqQdHiOc474w4=; b=pu4B2x0ag6KjZdGcZKUrJk/8zoBBGSccZr/D6PGwNVS8CTJCl22ovGVrKSY5MPAygw WmnC+uHGacaVsuQiGFG4N2UlKovvzS2R5NBh+Hm/eFPyQvwxNgaHzOYSJr/vFisMtDKB c8k8UMNVGn+/T0Rc9UqMVFbdOTtfr/ogLBgiLD/YtjRACKim3vVQh4f22YBlvu/gkFEq hYNwZy18Eb5nNwCyiEoW65tSpZXjGuqrjEdNGjW3QAhuG/stGQ3GkpvtB9e/NQXq3VI1 HflyL/CxdxU03t4VBZ5IqnUXX5E8wRyWe+qK8cVJvqI7EW54nbUnmUEcTOPhw33zs7nr 0pOw== X-Gm-Message-State: ACrzQf1ZszqwrSUu8THHvR3NkskOqYdGIj1LCL5ktq+47IPhgLBCN4/I kBXcWFKwT42lJmsOIkM5kMt+2bexQrUEKA== X-Google-Smtp-Source: AMsMyM6BfIf8gI4+orMuLMLulOzofOtWVpprVt+MKJeR7Vf9gJoXQ8G6kX4U/nRDcdT0HEkPtm8YpQ== X-Received: by 2002:a63:2c4c:0:b0:434:e001:89fd with SMTP id s73-20020a632c4c000000b00434e00189fdmr34519522pgs.444.1666736730605; Tue, 25 Oct 2022 15:25:30 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q15-20020a170902dacf00b0018685257c0dsm1671942plx.58.2022.10.25.15.25.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 15:25:29 -0700 (PDT) From: Kees Cook To: Andrew Morton , Al Viro , adobriyan@gmail.com, ebiederm@xmission.com, lizetao1@huawei.com Cc: Kees Cook , linux-fsdevel@vger.kernel.org, chengzhihao1@huawei.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yi.zhang@huawei.com Subject: Re: [PATCH] fs/binfmt_elf: Fix memory leak in load_elf_binary() Date: Tue, 25 Oct 2022 15:24:41 -0700 Message-Id: <166673667327.2128117.4844279671091670952.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024154421.982230-1-lizetao1@huawei.com> References: <20221024154421.982230-1-lizetao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666736731; a=rsa-sha256; cv=none; b=l+gnycZ+eljTzPhCjXe83YnlvLGOWhad62sNPr2DlNB478dmQqX0k8Jx9ojihVztRh8gam NUzf0NlL81ahTELf1lBQmmsdpo1XCPAOMToCGknF3mSjJ3zFbtbb2SlW/kDRzhoeomqPj1 SVwasf2M50FtNnAI93NRl5VaWtq9QIk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=X81xPrHA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666736731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bfUwPkkWvWRH7D0jic4UzLRvzXiFnNnqQdHiOc474w4=; b=KIj0LxigIeyk8FrcY14CFEoUtwlQtGFsnyuK24pqXbTratFj7uhD+mLUiv0JAVj70ftRx1 +4A7Q6a4AW4jCcNyZChZgbXmJjZNBGtR/UQ1Jk1ce8ECJgyK9mdfW0Mu4PUJbMKOeneJsO /+upWY6D1Owtr2+FCm5IV0MA9hp8npk= X-Stat-Signature: uiundiy9rrdex8tb1ziyzb6qy73ur65e X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8E35A160003 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=X81xPrHA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=keescook@chromium.org X-HE-Tag: 1666736731-820592 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Oct 2022 23:44:21 +0800, Li Zetao wrote: > There is a memory leak reported by kmemleak: > > unreferenced object 0xffff88817104ef80 (size 224): > comm "xfs_admin", pid 47165, jiffies 4298708825 (age 1333.476s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 60 a8 b3 00 81 88 ff ff a8 10 5a 00 81 88 ff ff `.........Z..... > backtrace: > [] __alloc_file+0x21/0x250 > [] alloc_empty_file+0x41/0xf0 > [] path_openat+0xea/0x3d30 > [] do_filp_open+0x1b9/0x290 > [] do_open_execat+0xce/0x5b0 > [] open_exec+0x27/0x50 > [] load_elf_binary+0x510/0x3ed0 > [] bprm_execve+0x599/0x1240 > [] do_execveat_common.isra.0+0x4c7/0x680 > [] __x64_sys_execve+0x88/0xb0 > [] do_syscall_64+0x35/0x80 > > [...] Applied to for-next/execve, thanks! [1/1] fs/binfmt_elf: Fix memory leak in load_elf_binary() https://git.kernel.org/kees/c/594d2a14f216 -- Kees Cook