From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D9EECDFA1 for ; Tue, 25 Oct 2022 22:25:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 345388E0003; Tue, 25 Oct 2022 18:25:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F5548E0001; Tue, 25 Oct 2022 18:25:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BD528E0003; Tue, 25 Oct 2022 18:25:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0C81F8E0001 for ; Tue, 25 Oct 2022 18:25:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DC63012063D for ; Tue, 25 Oct 2022 22:25:11 +0000 (UTC) X-FDA: 80060903622.10.3B1670E Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf16.hostedemail.com (Postfix) with ESMTP id 7E423180038 for ; Tue, 25 Oct 2022 22:25:11 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id g62so9346540pfb.10 for ; Tue, 25 Oct 2022 15:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N/IHWp5axKcNbS4CK0rdqluH2L9n6cyXddp8mwZdAWk=; b=M+QTTQuJYEiA9TQ/SaVp6cRfUf5PJqP7uvCnPdF4C/K5AcaCpZ3dnqjCsBVxZf26u6 YN9NAK30TVZha17vuUpG9TRFJxK01wJ+Nfnk4rLf5/5/+YaqBOOmkJotmZ4GGZH8u2g1 5f+OTY0f1+7kwGO9LaWXRPRZ0n8wX7GVMty+0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N/IHWp5axKcNbS4CK0rdqluH2L9n6cyXddp8mwZdAWk=; b=ntUORcDYoa7g4Yrjhqc2N2wmBwClMNlU3fVabvMCdhb2t8oxdiHTq/YP1SJTKoEY6C b4wlGH4JYkmhajp7g5UJ2tFXyM51OKELgjiGeKC8pDVl2ddV2YJII9BDP+TEHqpGkCA7 67T4KQcHgfofn+h4LNEHyB40wCdRz7REx5a80vY+f/gkU3HKVeKgqdnmDvopu/BbdX+c 0a0QxpNJW/RRgCuhFsMBx06oNLgVvPvR/MFy8E8lto+Cav2RlYOuSqwTfgS0rDa+i9rf ohLZ+CUQ7SaFEr+NeUXJA/GrP6XTzxITITbNZJCmR1G1BGxaaz0WfRnNgIhCtpgb6LSK pSxA== X-Gm-Message-State: ACrzQf2B3TWgl/FeQ/3W2sLYmwrbNTOJh4KYZf0to571zq0hBUyo5ePK q+zrTmKCFWyN8Bou27JI/2EHkQ== X-Google-Smtp-Source: AMsMyM66lXBBZiCQgf6FJkUodLvLKJHXn2RfG7lIzuw8OWJbBF9QFZXfjigg53YexUkU8JIZdanoxA== X-Received: by 2002:a63:d314:0:b0:452:598a:cc5a with SMTP id b20-20020a63d314000000b00452598acc5amr35619334pgg.299.1666736710427; Tue, 25 Oct 2022 15:25:10 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y17-20020aa79e11000000b0056be4dbd4besm1848936pfq.111.2022.10.25.15.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 15:25:09 -0700 (PDT) From: Kees Cook To: Al Viro , ebiederm@xmission.com, eb@emlix.com Cc: Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] binfmt_elf: simplify error handling in load_elf_phdrs() Date: Tue, 25 Oct 2022 15:24:37 -0700 Message-Id: <166673667324.2128117.9264012790851667013.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <4137126.7Qn9TF0dmF@mobilepool36.emlix.com> References: <4137126.7Qn9TF0dmF@mobilepool36.emlix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666736711; a=rsa-sha256; cv=none; b=xU/hlaRyGF2KbXiIqJTnu3INUN8fv76IimUG11pO7xCQ0oAYGHGV19VyKqI/CVfiOFrv5v jgbsk2UXa6K68Ht+N76pBi3RUGHfe/kH62ZTRS2naHAAp6FG3HCZbirZU6Esw4+VSD36T5 njIWwqzSu9Kx/Ul0PMJjlya1zKo+Dzs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=M+QTTQuJ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf16.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666736711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N/IHWp5axKcNbS4CK0rdqluH2L9n6cyXddp8mwZdAWk=; b=FXiWRYh2XYR+RD4Ymh5qUUe7SpjT619xd58Uo4Djks10NvaSh5sscAF6NwOja2w6GWz+LJ OfNmRhl0GeGdro4yzXVIUc06Q/td+FjJKNVd7etzxnn/K+h7zcS6RjNQSif+oiFo2qIoPU US6B1q3p6fjgTdbWpel+o66EZ/QGmSg= X-Stat-Signature: qw61s668tre8q9x8chkk4b83ic4m7miu X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7E423180038 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=M+QTTQuJ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf16.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org X-HE-Tag: 1666736711-316293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002092, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 19 Oct 2022 09:52:16 +0200, Rolf Eike Beer wrote: > The err variable was the same like retval, but capped to <= 0. This is the > same as retval as elf_read() never returns positive values. Applied to for-next/execve, thanks! [1/1] binfmt_elf: simplify error handling in load_elf_phdrs() https://git.kernel.org/kees/c/ef20c5139c31 -- Kees Cook