linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev
Subject: [mm-unstable PATCH] mm/memremap: fix pgmap_request_folio() stub
Date: Sat, 22 Oct 2022 15:40:38 -0700	[thread overview]
Message-ID: <166647843799.1783549.13495269957811737203.stgit@dwillia2-xfh.jf.intel.com> (raw)

0day robot reports:

include/linux/memremap.h:258:9: warning: expression which evaluates to zero treated as a null pointer constant of type 'struct folio *'

...because I failed to update the pgmap_request_folio() return value in
the CONFIG_ZONE_DEVICE=n case when changing the calling convention.

Fixes: e634e7e18f3b ("mm/memremap: Introduce pgmap_request_folio() using pgmap offsets")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 include/linux/memremap.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/memremap.h b/include/linux/memremap.h
index f11f827883bb..4a6eadf0d1d8 100644
--- a/include/linux/memremap.h
+++ b/include/linux/memremap.h
@@ -255,7 +255,7 @@ static inline struct dev_pagemap *get_dev_pagemap(unsigned long pfn,
 static inline struct folio *pgmap_request_folio(struct dev_pagemap *pgmap,
 						pgoff_t pgmap_offset, int order)
 {
-	return false;
+	return NULL;
 }
 
 static inline bool pgmap_pfn_valid(struct dev_pagemap *pgmap, unsigned long pfn)



                 reply	other threads:[~2022-10-22 22:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166647843799.1783549.13495269957811737203.stgit@dwillia2-xfh.jf.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox