From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC956C43219 for ; Tue, 4 Oct 2022 13:38:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50C6A6B0074; Tue, 4 Oct 2022 09:38:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BBAD8E0002; Tue, 4 Oct 2022 09:38:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AA8E8E0001; Tue, 4 Oct 2022 09:38:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 282856B0074 for ; Tue, 4 Oct 2022 09:38:56 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EE088140A3C for ; Tue, 4 Oct 2022 13:38:55 +0000 (UTC) X-FDA: 79983372630.02.64DBE80 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf27.hostedemail.com (Postfix) with ESMTP id 3BF644001C for ; Tue, 4 Oct 2022 13:38:54 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Mhf1R664Kz4xH2; Wed, 5 Oct 2022 00:38:51 +1100 (AEDT) From: Michael Ellerman To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: Jonathan Corbet , Baoquan He , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Ingo Molnar , linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, Andrew Morton , Michael Ellerman , Jani Nikula , Vivek Goyal , Dave Young , Linus Torvalds , Joe Perches , Nicholas Piggin , David Laight , linux-mm@kvack.org, Christophe Leroy In-Reply-To: <20220920122302.99195-1-david@redhat.com> References: <20220920122302.99195-1-david@redhat.com> Subject: Re: (subset) [PATCH v1 0/3] coding-style.rst: document BUG() and WARN() rules Message-Id: <166488986181.779920.10714540040506715558.b4-ty@ellerman.id.au> Date: Wed, 05 Oct 2022 00:24:21 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664890735; a=rsa-sha256; cv=none; b=HuvYKCar3M/85VujXg8dAkNJlzE4v/D8rMb3WUXCAP/0K1NR9CxBkH5lMTjC+/1M0tOJM+ AULnVVQrlYd7PGvrWnO212zNrbUELF68Mgrqt/mi+/jiwGUmb3mg4ksQ0AmTFNRFMRrnC3 qlYSmwqUX+CPZIqQYrhqIeP9MRcGoDA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of michael@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=michael@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664890735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q2hm5FhkKiG+2OeYnuTfk6I4vztKMNId21nMRWPhs/M=; b=wM8xFYm+uVHWr/hM+IiPBZ/XVSLpKCKERn+9LwG/JXdPuFD5b5QKAN+Imdm9bJ8hfku0qv Kern5TYBykpZG3VzpVEblOd5AjaYU+VBDv13HyHTSPUrIy8ZAgyQlBn6CoGua84UYSCsMc 5INQPyplZoBXSkwwn7s5YELh4mXcoqc= X-Rspamd-Server: rspam08 X-Rspam-User: X-Rspamd-Queue-Id: 3BF644001C Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of michael@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=michael@ellerman.id.au X-Stat-Signature: kwdfztjibzgi34bw39hgfgd6u1r8oz7e X-HE-Tag: 1664890734-546148 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 20 Sep 2022 14:22:59 +0200, David Hildenbrand wrote: > As it seems to be rather unclear if/when to use BUG(), BUG_ON(), > VM_BUG_ON(), WARN_ON_ONCE(), ... let's try to document the result of a > recent discussion. > > Details can be found in patch #1. > > RFC -> v1: > * "coding-style.rst: document BUG() and WARN() rules ("do not crash the > kernel")" > -> Rephrase/extend according to John > -> Add some details regarding the use of panic() > * powerpc/prom_init: drop PROM_BUG() > -> Added > * "checkpatch: warn on usage of VM_BUG_ON() and other BUG variants" > -> Warn on more variants > > [...] Patch 2 applied to powerpc/next. [2/3] powerpc/prom_init: drop PROM_BUG() https://git.kernel.org/powerpc/c/c4167aec98524fa4511b3222303a758b532b6009 cheers