* [PATCH] mm: No need to check pcp page when free it to buddy
@ 2022-09-14 10:53 zhaoyang.huang
2022-09-14 21:19 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: zhaoyang.huang @ 2022-09-14 10:53 UTC (permalink / raw)
To: Andrew Morton, Zhaoyang Huang, linux-mm, linux-kernel, ke.wang
From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
The pages on pcp list have been checked the validity from each entrance. It is
no need to check it again when free them back to buddy.
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index e008a3d..131536e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1445,7 +1445,7 @@ static bool free_pcp_prepare(struct page *page, unsigned int order)
static bool bulkfree_pcp_prepare(struct page *page)
{
- return check_free_page(page);
+ return false;
}
#endif /* CONFIG_DEBUG_VM */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: No need to check pcp page when free it to buddy
2022-09-14 10:53 [PATCH] mm: No need to check pcp page when free it to buddy zhaoyang.huang
@ 2022-09-14 21:19 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2022-09-14 21:19 UTC (permalink / raw)
To: zhaoyang.huang; +Cc: Zhaoyang Huang, linux-mm, linux-kernel, ke.wang
On Wed, 14 Sep 2022 18:53:40 +0800 "zhaoyang.huang" <zhaoyang.huang@unisoc.com> wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> The pages on pcp list have been checked the validity from each entrance. It is
> no need to check it again when free them back to buddy.
>
I'm not sure what "from each entrance" means. Please identify the
codesite where this other check is occurring?
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index e008a3d..131536e 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1445,7 +1445,7 @@ static bool free_pcp_prepare(struct page *page, unsigned int order)
>
> static bool bulkfree_pcp_prepare(struct page *page)
> {
> - return check_free_page(page);
> + return false;
> }
> #endif /* CONFIG_DEBUG_VM */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-14 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 10:53 [PATCH] mm: No need to check pcp page when free it to buddy zhaoyang.huang
2022-09-14 21:19 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox