From: Joe Damato <jdamato@fastly.com>
To: x86@kernel.org, linux-mm@kvack.org,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@suse.de>,
Steven Rostedt <rostedt@goodmis.org>,
Valentin Schneider <vschneid@redhat.com>
Cc: Joe Damato <jdamato@fastly.com>
Subject: [RFC 0/1] mm: Track per-task tlb events
Date: Tue, 13 Sep 2022 18:51:08 -0700 [thread overview]
Message-ID: <1663120270-2673-1-git-send-email-jdamato@fastly.com> (raw)
Greetings:
TLB shootdown events can be measured on a per-CPU basis by examining
/proc/interrupts. Further information about TLB events can be harvested
from /proc/vmstat if CONFIG_DEBUG_TLBFLUSH is enabled, but this information
is system-wide.
This information is useful, but on a busy system with many tasks it can be
difficult to disambiguate the source of the TLB shootdown events.
Having this information tracked per-task can enable developers to fix or
tweak userland allocators to reduce the number of IPIs and improve
application performance.
This change adds two new fields to task_struct and signal_struct to help
track TLB events:
- ngtlbflush: number of tlb flushes generated
- nrtlbflush: number of tlb flushes received
These stats are exported in /proc/[pid]/stat alongside similar metrics
(e.g. min_flt and maj_flt) for analysis.
I've gotten code into kernel networking / drivers before, but I've never
hacked on mm and mm-adjacent code before. Please let me know if there's a
glaring issue and I'll be happy to tweak this code as necessary.
If this seems OK, I'll send an official v1.
Thanks!
Joe Damato (1):
mm: Add per-task struct tlb counters
arch/x86/mm/tlb.c | 2 ++
fs/proc/array.c | 9 +++++++++
include/linux/sched.h | 6 ++++++
include/linux/sched/signal.h | 1 +
kernel/exit.c | 6 ++++++
kernel/fork.c | 1 +
6 files changed, 25 insertions(+)
--
2.7.4
next reply other threads:[~2022-09-14 1:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 1:51 Joe Damato [this message]
2022-09-14 1:51 ` [RFC 1/1] mm: Add per-task struct tlb counters Joe Damato
2022-09-14 7:40 ` Dave Hansen
2022-09-14 11:58 ` Peter Zijlstra
2022-09-14 14:23 ` Joe Damato
2022-09-14 14:15 ` Joe Damato
2022-09-14 14:25 ` Joe Damato
2022-09-15 8:50 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1663120270-2673-1-git-send-email-jdamato@fastly.com \
--to=jdamato@fastly.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hpa@zytor.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rostedt@goodmis.org \
--cc=vschneid@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox