From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A9CC0502C for ; Sat, 27 Aug 2022 09:03:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81C8B6B0074; Sat, 27 Aug 2022 05:03:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CB9D940008; Sat, 27 Aug 2022 05:03:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66C62940007; Sat, 27 Aug 2022 05:03:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 590386B0074 for ; Sat, 27 Aug 2022 05:03:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3838A12029B for ; Sat, 27 Aug 2022 09:03:17 +0000 (UTC) X-FDA: 79844783634.12.C20F1C4 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf10.hostedemail.com (Postfix) with ESMTP id E9718C0020 for ; Sat, 27 Aug 2022 09:03:16 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id y127so3720107pfy.5 for ; Sat, 27 Aug 2022 02:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc; bh=d1f8nUkF5t5cqSm1uy6aZjuA2/Q1MZyp0rZYnQGPqp0=; b=ADjlqlLIinapEBKNHJvPolEuOZOLX5jS2yCniDir0S71XSJNsvfMC3q6GUuAFzuJqR 8vplwGxKNX2EsG9DemkIS31tmJaa8urq6d9dQPAoSQfovgGR1RKD8BYEryyzG3AJG/dm nG1Hy5RBSbbVJIPOfm9dxB1H/nLD7X0PGfE6nOpZntMCl/OIiy7dvNBflhCnnZlgjQIV nuh2nT0+/QE5gOvY/YEECvTlajluTepx43UDivJKpw+BuV2uonfE7Mlc/mAfNIDC7vo4 SIX0MT+I90XyCiC1VW+mvtuFzDkQDeFK68kD3JdlI5G8HPDdUtlklTfqy/k+gVgiUb7A Ut/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc; bh=d1f8nUkF5t5cqSm1uy6aZjuA2/Q1MZyp0rZYnQGPqp0=; b=sv/NsDl7D/N/Z8lp+eFLvM3lzrcRUX2lmpvqP1KMJ0tSfJOFKKYMjmoonlPGM4kBUj SjEptg4Y0t+u/NGi48zOClE1zwegHHrTDS8TfAU7dpT5/WTHDRStQBENW62oxP51y08b qODM9SL5AFplUrCwY4oYKrCF8Zb7mFNOGwIUBp/yxnjAPpUbqyu9DY0d08gmxiXZoTSe N78fAHQbUgtUyTe9+tOAazSjoiv2e6KVQ9T2sQRxp18J7V9tb+SW3VYHwnTEqov80yvs AHkoWOew18u4RRM8GQM47XKmYWK32hMno8YXNoSMRsHoagFq3tn2jj0Z79iNEIY/FsfL uNJQ== X-Gm-Message-State: ACgBeo3u5yD5rMY3vSe3oGrkw2qRUH7ytdov1ykDNPRL8XasXA0eRtmK +6GVHRpTbYvZtN8hwImQYA== X-Google-Smtp-Source: AA6agR5q+qB4j7NKYCCupMsiap0S5orWPGACxAjLmCltEPdsahEoARsCXsq2ScHJmpUnXiH+R4HNCg== X-Received: by 2002:a63:5d4e:0:b0:41d:dcc3:aa85 with SMTP id o14-20020a635d4e000000b0041ddcc3aa85mr6342951pgm.324.1661590995694; Sat, 27 Aug 2022 02:03:15 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id s88-20020a17090a69e100b001fb09316a26sm2943332pjj.43.2022.08.27.02.03.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Aug 2022 02:03:14 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH v2 1/2] mm/damon: simplify the parameter passing for 'check_accesses' Date: Sat, 27 Aug 2022 17:02:50 +0800 Message-Id: <1661590971-20893-2-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1661590971-20893-1-git-send-email-kaixuxia@tencent.com> References: <1661590971-20893-1-git-send-email-kaixuxia@tencent.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661590996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=d1f8nUkF5t5cqSm1uy6aZjuA2/Q1MZyp0rZYnQGPqp0=; b=bWtCSGP2Ps54Y1vTCG7YhbJLWmZb42TlQBrK2MfXreYxp1i9o+j4xKBFm832tjiyjAORyi rIXLVZlH5P6wWOzNv0rHbEUIW3f5QEa0njz+cqRJzdVEIQ4KO05L4bzzmcy14u/3qYh5xJ v7n2Odxg2oMk7T/9IbOFm4Lxhvt3Xz4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ADjlqlLI; spf=pass (imf10.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661590996; a=rsa-sha256; cv=none; b=xqhVbTo3TE2lqHrRJSkNLpuQCVoS8Q54pNAw29d7Z/NMrWGmRQhpDDHYr6AiSyOg/aQYqH 7U2erFUO7KuZuMserbx05Vg3KVQxN5fBeewBx5NI7nk4Re15FMJjXoUoHqrW75OkOBg1Ct QN5ZJ+5q/BETtJOcSGQAAeHSAtto8bI= X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ADjlqlLI; spf=pass (imf10.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Stat-Signature: e4xpkekrcgink3iu1odd9gfzwg9aerhx X-Rspamd-Queue-Id: E9718C0020 X-HE-Tag: 1661590996-329352 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia The parameter 'struct damon_ctx *ctx' isn't used in the functions __damon_{p,v}a_check_access(), so we can remove it and simplify the parameter passing. Signed-off-by: Kaixu Xia --- mm/damon/paddr.c | 5 ++--- mm/damon/vaddr.c | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index dc131c6a5403..6b0d9e6aa677 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -166,8 +166,7 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz) return result.accessed; } -static void __damon_pa_check_access(struct damon_ctx *ctx, - struct damon_region *r) +static void __damon_pa_check_access(struct damon_region *r) { static unsigned long last_addr; static unsigned long last_page_sz = PAGE_SIZE; @@ -196,7 +195,7 @@ static unsigned int damon_pa_check_accesses(struct damon_ctx *ctx) damon_for_each_target(t, ctx) { damon_for_each_region(r, t) { - __damon_pa_check_access(ctx, r); + __damon_pa_check_access(r); max_nr_accesses = max(r->nr_accesses, max_nr_accesses); } } diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 3c7b9d6dca95..e481f81c3efb 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -532,8 +532,8 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr, * mm 'mm_struct' for the given virtual address space * r the region to be checked */ -static void __damon_va_check_access(struct damon_ctx *ctx, - struct mm_struct *mm, struct damon_region *r) +static void __damon_va_check_access(struct mm_struct *mm, + struct damon_region *r) { static struct mm_struct *last_mm; static unsigned long last_addr; @@ -568,7 +568,7 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) if (!mm) continue; damon_for_each_region(r, t) { - __damon_va_check_access(ctx, mm, r); + __damon_va_check_access(mm, r); max_nr_accesses = max(r->nr_accesses, max_nr_accesses); } mmput(mm); -- 2.27.0