From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34438C19F2D for ; Sat, 13 Aug 2022 15:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F8E98E0002; Sat, 13 Aug 2022 11:19:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A6F88E0001; Sat, 13 Aug 2022 11:19:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66E958E0002; Sat, 13 Aug 2022 11:19:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 579CD8E0001 for ; Sat, 13 Aug 2022 11:19:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 01A6312055E for ; Sat, 13 Aug 2022 15:19:28 +0000 (UTC) X-FDA: 79794928458.08.1153DE9 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 8FBDC40075 for ; Sat, 13 Aug 2022 15:19:28 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id f28so3356236pfk.1 for ; Sat, 13 Aug 2022 08:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc; bh=sczWzcrWCAkWB34nYrTJR/7dpANVkwOeC+sp+t0HVfg=; b=Ch2VEMqApEF7lOYCvApzId+CrqdLxAbsPRAJozfJeo2VvHdNDkJNgIpVgnWA6pGh4l i6xU7XYij8JJaJZNCCMT9pmc94GhY8UqOZMtIPeAmX0BizsVH6iUV/Nsc54Dv4pEF6A8 Xb/6Xv0X8th6wday3v0NwrfxCHBjl4PGgPaiY0Vd7Gz8Etubp20Be6PmftqNqPnETYXq bzZnjCbNcaShGvoKRUc6sPjytSEcIe3Yuk5/BPy+6Da0a7IkdIo4B9iQZOSzdVKmjBUJ Hsi6XuSfWIRp/5OXmgBqWwRSLjPAqFRpt5QPYPzDYTTBIYCmR8D23vltAKb9nLCfmlRr IO2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=sczWzcrWCAkWB34nYrTJR/7dpANVkwOeC+sp+t0HVfg=; b=UmmKIQbYpmQVRIO2EaSooc12hY90UGMAXMl2cWj5su39VyvJTusp3gnJja0USUIsmX oJADagUFXKgAGMnoPRrxM9mvtQNpWFUODoyeiJufNQLydTWwhlFeCqU6d5bSVYxf5SKf 8VgsiO/KWEaH2DI2SVSR8LMbS9wG8sBhB3gJExWxKm95aWWqFv1qe9R8yu5yusksYzic sflMV42N9bJ4cQ7aUPgxG26Km1g09eD+SEeh9vYO78bY0Iqug0CyoGcUIx9WkvhwhVZ1 SBX/7Z1Bdu4CMWyMvin5TTviVUsL71+a00W0LLZjDAp879/hZIw0xtBgJQAK7KZ3R2y6 SiYg== X-Gm-Message-State: ACgBeo3Jl6l1mhHuwxnUShD7ALkYrWpMVnSl3AEHl/2GIBSr1IaiNlmV 4rGK3UtixuO7C+vn9UGh3A== X-Google-Smtp-Source: AA6agR6Xb4TLm7ioMv+Cf/enVJM4Y6+9baENFEq59DyweBo1Hi/1Ds5xYTCCuHuBvnOT3fZMGNL2vA== X-Received: by 2002:a63:e016:0:b0:427:e7f2:32b3 with SMTP id e22-20020a63e016000000b00427e7f232b3mr16970pgh.194.1660403967376; Sat, 13 Aug 2022 08:19:27 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id a22-20020aa795b6000000b0052dab7afa04sm3666619pfk.47.2022.08.13.08.19.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Aug 2022 08:19:26 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH V2] mm/damon/core: simplify the parameter passing for region split operation Date: Sat, 13 Aug 2022 23:19:03 +0800 Message-Id: <1660403943-29124-1-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660403968; a=rsa-sha256; cv=none; b=0KFdG0pqcIorAzjlR6T2BNkJXLTTLu/uRDZzW8qRZMVhyCpUzruN7qYLOeTYkhVOM269x4 26r35oFgW57GTfqCTebxYuibgKojmx95nuAsoDluD7Zo7kPZoA2MW+ICVOAU0mULgVIeLn 8dau/J1WCkenKxuXjHwun5+EcM7QOOU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ch2VEMqA; spf=pass (imf12.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660403968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=sczWzcrWCAkWB34nYrTJR/7dpANVkwOeC+sp+t0HVfg=; b=VkZJVYC0JN7qY2moHjB1Rs2+7aenVF0bL1n37Mc82z+fMu2sSBFpzH9q2sJj7m0su1qY1H xlIF/cOW146VWSmy56GYqW3OragUTH9+p6jR+HmNsNMqTi7MK3YpJmmXT8dUbR+MLp3ykC w6a6EMt97FnYBJqLmCfbatLLVd1m8mU= X-Rspamd-Queue-Id: 8FBDC40075 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ch2VEMqA; spf=pass (imf12.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: fwh67ammdsaqnpztui9gos7nyj59skkx X-HE-Tag: 1660403968-432371 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia The parameter 'struct damon_ctx *ctx' is unnecessary in damon region split operation, so we can remove it. Signed-off-by: Kaixu Xia --- v2: -fix both the build error reported by kernel test robot and commit message. mm/damon/core-test.h | 6 +++--- mm/damon/core.c | 21 +++++++++------------ 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h index 573669566f84..45db79d28fdc 100644 --- a/mm/damon/core-test.h +++ b/mm/damon/core-test.h @@ -126,7 +126,7 @@ static void damon_test_split_at(struct kunit *test) t = damon_new_target(); r = damon_new_region(0, 100); damon_add_region(r, t); - damon_split_region_at(c, t, r, 25); + damon_split_region_at(t, r, 25); KUNIT_EXPECT_EQ(test, r->ar.start, 0ul); KUNIT_EXPECT_EQ(test, r->ar.end, 25ul); @@ -219,14 +219,14 @@ static void damon_test_split_regions_of(struct kunit *test) t = damon_new_target(); r = damon_new_region(0, 22); damon_add_region(r, t); - damon_split_regions_of(c, t, 2); + damon_split_regions_of(t, 2); KUNIT_EXPECT_LE(test, damon_nr_regions(t), 2u); damon_free_target(t); t = damon_new_target(); r = damon_new_region(0, 220); damon_add_region(r, t); - damon_split_regions_of(c, t, 4); + damon_split_regions_of(t, 4); KUNIT_EXPECT_LE(test, damon_nr_regions(t), 4u); damon_free_target(t); damon_destroy_ctx(c); diff --git a/mm/damon/core.c b/mm/damon/core.c index 7d25dc582fe3..9964b9d00768 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -658,9 +658,8 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) } } -static void damon_split_region_at(struct damon_ctx *ctx, - struct damon_target *t, struct damon_region *r, - unsigned long sz_r); +static void damon_split_region_at(struct damon_target *t, + struct damon_region *r, unsigned long sz_r); static bool __damos_valid_target(struct damon_region *r, struct damos *s) { @@ -726,7 +725,7 @@ static void damon_do_apply_schemes(struct damon_ctx *c, continue; sz = DAMON_MIN_REGION; } - damon_split_region_at(c, t, r, sz); + damon_split_region_at(t, r, sz); r = damon_next_region(r); sz = r->ar.end - r->ar.start; } @@ -745,7 +744,7 @@ static void damon_do_apply_schemes(struct damon_ctx *c, DAMON_MIN_REGION); if (!sz) goto update_stat; - damon_split_region_at(c, t, r, sz); + damon_split_region_at(t, r, sz); } ktime_get_coarse_ts64(&begin); sz_applied = c->ops.apply_scheme(c, t, r, s); @@ -928,9 +927,8 @@ static void kdamond_merge_regions(struct damon_ctx *c, unsigned int threshold, * r the region to be split * sz_r size of the first sub-region that will be made */ -static void damon_split_region_at(struct damon_ctx *ctx, - struct damon_target *t, struct damon_region *r, - unsigned long sz_r) +static void damon_split_region_at(struct damon_target *t, + struct damon_region *r, unsigned long sz_r) { struct damon_region *new; @@ -947,8 +945,7 @@ static void damon_split_region_at(struct damon_ctx *ctx, } /* Split every region in the given target into 'nr_subs' regions */ -static void damon_split_regions_of(struct damon_ctx *ctx, - struct damon_target *t, int nr_subs) +static void damon_split_regions_of(struct damon_target *t, int nr_subs) { struct damon_region *r, *next; unsigned long sz_region, sz_sub = 0; @@ -969,7 +966,7 @@ static void damon_split_regions_of(struct damon_ctx *ctx, if (sz_sub == 0 || sz_sub >= sz_region) continue; - damon_split_region_at(ctx, t, r, sz_sub); + damon_split_region_at(t, r, sz_sub); sz_region = sz_sub; } } @@ -1004,7 +1001,7 @@ static void kdamond_split_regions(struct damon_ctx *ctx) nr_subregions = 3; damon_for_each_target(t, ctx) - damon_split_regions_of(ctx, t, nr_subregions); + damon_split_regions_of(t, nr_subregions); last_nr_regions = nr_regions; } -- 2.27.0