From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32EF4C00140 for ; Fri, 12 Aug 2022 07:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 557026B0073; Fri, 12 Aug 2022 03:41:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DFF26B0075; Fri, 12 Aug 2022 03:41:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 359458E0001; Fri, 12 Aug 2022 03:41:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 202096B0073 for ; Fri, 12 Aug 2022 03:41:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E1242121A9F for ; Fri, 12 Aug 2022 07:41:53 +0000 (UTC) X-FDA: 79790146506.10.0EB5DF5 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf12.hostedemail.com (Postfix) with ESMTP id 92AB94006C for ; Fri, 12 Aug 2022 07:41:53 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id d10so92701plr.6 for ; Fri, 12 Aug 2022 00:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc; bh=a85QtWLEcMRCMIMtbuuHRx4zEckQE16YnrJva/znejY=; b=QwJ1cMt+zU/OEIGc/ORnYEwubrCFSzo0cdKCbDj0t7pkzoiGw5mhEzchQ4TsyJQ5ee JQCgSApm13Au1svbHoYl+OgSVx7XkoSO/vWJWxyzMDXKJucMsYyzJhj8Q96T5/P9KK06 W6jsyT0kBPBlTD0bH6k5aksti9W8l/2KvMSu17byb2y50Uj1btMtytyaQr3G7QFeHWfh QpTPra9BLoduIaiyYNhBPi7X2V8sJhZPzhxn/OZ0+1wp9yRuQKsR3e3gVTdvA5JRcCJA Rp1mZm9itn6C+rQLRuKsb4eWKchvezWjlfbFmkiTFHii+SKFMSdYynvKn3UTb+IB9wQ9 OIwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=a85QtWLEcMRCMIMtbuuHRx4zEckQE16YnrJva/znejY=; b=yb5wF3bVslACznNB6ziqdalgz3Kyv4WYk7orPtY1RIRzI7bDfJIks0I1cVKxgkxBN0 jj48oEdMHIQik+0Ly61e30JNxwPLQXRU2lDnaJfrI/mWkHk4GHE8zLGFO+/mPhidsKQ5 azkP8aDDBkK+oMuu5yEagG0tQWh8ERO2uxwNiCCSJ3H/n3Xq4P7oYU2WXRvZfaUD4ush bS09mhLNvBldZ3DMMtCqOhkaiOeARU/KtIrx1XOVFvU+8wNmLkIDx5Bde4vGhp6TqwPL KtDZ3ozJbQ16oOU+JlPvXegLTYlQjAsddT+6HT5cZZBmUdCSiplnnsNrETw3FPMBj3ZI ZNxA== X-Gm-Message-State: ACgBeo1FBDcN+dgFgOqATFaSiBDuNiBX897ABewuwl/xOiAsaMwN7h2f lqexg38dweQMyaCgZW3SMw== X-Google-Smtp-Source: AA6agR7z+XSTaY12H9leweMCFym0qnSon6wZ8VAkDqXiHWjIjyaAnZy8Ed2MGrYyw5+Xo+vaqK/BnA== X-Received: by 2002:a17:90b:2687:b0:1f3:1535:eda5 with SMTP id pl7-20020a17090b268700b001f31535eda5mr12777870pjb.39.1660290112394; Fri, 12 Aug 2022 00:41:52 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id e6-20020a170902d38600b001709b9d292esm942358pld.268.2022.08.12.00.41.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Aug 2022 00:41:51 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH] mm/damon/core: simplify the parameter passing for region split operation Date: Fri, 12 Aug 2022 15:41:13 +0800 Message-Id: <1660290073-26347-1-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660290113; a=rsa-sha256; cv=none; b=5UdDjW+vfDoWJXqsc8dXBS3xfyKCkpMmR1hZ3Ye8+PSG6RVwollqlroLmZDoSQ8lcWLfIV e7r99yETVNzDrBHtPhAnb8UqhnPA5bGlsCWKNhODKwAzWV97kKq5CjqMfTuOetdUvIzrw6 V33LVDW0jABBLoxuWzGFPuRRn7G/ikI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QwJ1cMt+; spf=pass (imf12.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660290113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=a85QtWLEcMRCMIMtbuuHRx4zEckQE16YnrJva/znejY=; b=XJPLx+y4G2hu0SHxBGeYMZwzKGRm5+ZIBH60uV40ypl968p828CIcAIh2ywWWY9MZcJMV4 fom8C5DKg1A+MhKffHprDrqW18KmXoCJBIEFwf4nhKLQuzf7hVL4CrNHbjl8m4d2XnGUEX nXelGWKdSiqvGky1ajD6utu0+phI6Vo= X-Stat-Signature: nmef5e9ry74jyybgt7h6xtq4aby7nhk9 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 92AB94006C Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QwJ1cMt+; spf=pass (imf12.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-HE-Tag: 1660290113-311328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.099626, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia The parameter 'struct damon_target *t' is unnecessary in damon region split operation, so we can remove it. Signed-off-by: Kaixu Xia --- mm/damon/core.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 7d25dc582fe3..9964b9d00768 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -658,9 +658,8 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) } } -static void damon_split_region_at(struct damon_ctx *ctx, - struct damon_target *t, struct damon_region *r, - unsigned long sz_r); +static void damon_split_region_at(struct damon_target *t, + struct damon_region *r, unsigned long sz_r); static bool __damos_valid_target(struct damon_region *r, struct damos *s) { @@ -726,7 +725,7 @@ static void damon_do_apply_schemes(struct damon_ctx *c, continue; sz = DAMON_MIN_REGION; } - damon_split_region_at(c, t, r, sz); + damon_split_region_at(t, r, sz); r = damon_next_region(r); sz = r->ar.end - r->ar.start; } @@ -745,7 +744,7 @@ static void damon_do_apply_schemes(struct damon_ctx *c, DAMON_MIN_REGION); if (!sz) goto update_stat; - damon_split_region_at(c, t, r, sz); + damon_split_region_at(t, r, sz); } ktime_get_coarse_ts64(&begin); sz_applied = c->ops.apply_scheme(c, t, r, s); @@ -928,9 +927,8 @@ static void kdamond_merge_regions(struct damon_ctx *c, unsigned int threshold, * r the region to be split * sz_r size of the first sub-region that will be made */ -static void damon_split_region_at(struct damon_ctx *ctx, - struct damon_target *t, struct damon_region *r, - unsigned long sz_r) +static void damon_split_region_at(struct damon_target *t, + struct damon_region *r, unsigned long sz_r) { struct damon_region *new; @@ -947,8 +945,7 @@ static void damon_split_region_at(struct damon_ctx *ctx, } /* Split every region in the given target into 'nr_subs' regions */ -static void damon_split_regions_of(struct damon_ctx *ctx, - struct damon_target *t, int nr_subs) +static void damon_split_regions_of(struct damon_target *t, int nr_subs) { struct damon_region *r, *next; unsigned long sz_region, sz_sub = 0; @@ -969,7 +966,7 @@ static void damon_split_regions_of(struct damon_ctx *ctx, if (sz_sub == 0 || sz_sub >= sz_region) continue; - damon_split_region_at(ctx, t, r, sz_sub); + damon_split_region_at(t, r, sz_sub); sz_region = sz_sub; } } @@ -1004,7 +1001,7 @@ static void kdamond_split_regions(struct damon_ctx *ctx) nr_subregions = 3; damon_for_each_target(t, ctx) - damon_split_regions_of(ctx, t, nr_subregions); + damon_split_regions_of(t, nr_subregions); last_nr_regions = nr_regions; } -- 2.27.0