From: Alex Williamson <alex.williamson@redhat.com>
To: alex.sierra@amd.com, akpm@linux-foundation.org
Cc: hch@lst.de, Felix.Kuehling@amd.com, apopple@nvidia.com,
david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] mm: re-allow pinning of zero pfns (again)
Date: Mon, 08 Aug 2022 22:42:24 -0600 [thread overview]
Message-ID: <166002010021.381133.11357879752637949308.stgit@omen> (raw)
The below referenced commit makes the same error as 1c563432588d ("mm: fix
is_pinnable_page against a cma page"), re-interpreting the logic to exclude
pinning of the zero page, which breaks device assignment with vfio.
Link: https://lore.kernel.org/all/165490039431.944052.12458624139225785964.stgit@omen
Fixes: f25cbb7a95a2 ("mm: add zone device coherent type memory support")
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
include/linux/mm.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 18e01474cf6b..772279ed7010 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1544,9 +1544,8 @@ static inline bool is_longterm_pinnable_page(struct page *page)
if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE)
return false;
#endif
- return !(is_device_coherent_page(page) ||
- is_zone_movable_page(page) ||
- is_zero_pfn(page_to_pfn(page)));
+ return !(is_device_coherent_page(page) || is_zone_movable_page(page)) ||
+ is_zero_pfn(page_to_pfn(page));
}
#else
static inline bool is_longterm_pinnable_page(struct page *page)
next reply other threads:[~2022-08-09 4:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 4:42 Alex Williamson [this message]
2022-08-09 8:15 ` David Hildenbrand
2022-08-09 12:31 ` Matthew Wilcox
2022-08-09 14:14 ` Felix Kuehling
2022-08-09 14:43 ` Matthew Wilcox
2022-08-09 14:51 ` David Hildenbrand
2022-08-10 2:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166002010021.381133.11357879752637949308.stgit@omen \
--to=alex.williamson@redhat.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox