From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 059D3C19F2B for ; Wed, 3 Aug 2022 23:21:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2885A8E0002; Wed, 3 Aug 2022 19:21:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 237CD8E0001; Wed, 3 Aug 2022 19:21:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9EE8E0002; Wed, 3 Aug 2022 19:21:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F1FF38E0001 for ; Wed, 3 Aug 2022 19:21:45 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9FC588010A for ; Wed, 3 Aug 2022 23:21:45 +0000 (UTC) X-FDA: 79759855770.07.5AE3408 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf27.hostedemail.com (Postfix) with ESMTP id 3447840010 for ; Wed, 3 Aug 2022 23:21:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8B98B20660; Wed, 3 Aug 2022 23:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1659568903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WX3MyHefy1m59oXa4YMmkgiCO4W1byOGHw1BNWRWYEI=; b=uIZa5ohSXvr3rXkA1xgYUVbF2vcZvd3y5Fvn3so69YUt2nacp+GL4pJ6X6JAMnMKSIWvfs AUUVYQovRvn+aGywU96S/0RZdi0SBaT9hkflf2SbzKxHvcyTYqhfsWRGo5yHpw73VVjIo8 HSpbq8aFpzkJ6calgR9ImsaCPu3vge4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1659568903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WX3MyHefy1m59oXa4YMmkgiCO4W1byOGHw1BNWRWYEI=; b=SxumgYHsZ+YPhIiDUI+mGtq7DMy2X13+otzQA5yqcWN78bPcGiHIlpFd9niaoNB9ndCQSm F+o2VPbMnyb+rLAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DB41913AD8; Wed, 3 Aug 2022 23:21:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5R09JQUD62LuYgAAMHmgww (envelope-from ); Wed, 03 Aug 2022 23:21:41 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 From: "NeilBrown" To: "Chuck Lever III" Cc: "kbuild-all@lists.01.org" , "Linux Memory Management List" , "kernel test robot" , "Linux NFS Mailing List" Subject: Re: [linux-next:master 13556/14285] ERROR: modpost: "set_posix_acl" [fs/nfsd/nfsd.ko] undefined! In-reply-to: References: <202208031404.a1NgfSzI-lkp@intel.com>, Date: Thu, 04 Aug 2022 09:21:38 +1000 Message-id: <165956889874.12283.5007966519219519664@noble.neil.brown.name> ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uIZa5ohS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SxumgYHs; spf=pass (imf27.hostedemail.com: domain of neilb@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659568905; a=rsa-sha256; cv=none; b=OXz9TwiXmM0HlcvtLSa8UPpGuS/Ug+djtGuvg/b/DCEv0h+DPwBBupryiXi5D/OScfv3Cd 2m4oJnhEN2aSHpn3/cC4WRC40N2jQzQlXgPNPtZJyc8mPxnA3foJF8jZDojVYf22X26y3l xbsCz7mwGVjr3vSEh0OTGJJD1DFMDco= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659568905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WX3MyHefy1m59oXa4YMmkgiCO4W1byOGHw1BNWRWYEI=; b=v8xDCCUSvrC+4n1LfFjOnZJKb1ZXZxhQhM/25zjO2WPxvC0syQgUdp9MYv6DMntUlT9Oq7 W95Sgq1+cc3Xp/lzQXN5GIKbR13JI5zYLTiVdfY0HETsLxqm3bGuUbvwNOfbe6BRDMJI7l NbL90mg3MzHo0OUvnTjkyjYJcSpUqT4= X-Stat-Signature: f1g7sjiy13od85mbxumn8op3tjjfzeza X-Rspamd-Queue-Id: 3447840010 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uIZa5ohS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SxumgYHs; spf=pass (imf27.hostedemail.com: domain of neilb@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1659568905-121687 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 03 Aug 2022, Chuck Lever III wrote: >=20 > > On Aug 3, 2022, at 2:55 AM, kernel test robot wrote: > >=20 > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > > head: 42d670bda02fdba0f3944c92f545984501e5788d > > commit: 2743f3e0444f7287161ecf3e464ee2733dde412d [13556/14285] NFSD: add = posix ACLs to struct nfsd_attrs > > config: parisc-defconfig (https://download.01.org/0day-ci/archive/2022080= 3/202208031404.a1NgfSzI-lkp@intel.com/config) > > compiler: hppa-linux-gcc (GCC) 12.1.0 > > reproduce (this is a W=3D1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin= /make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.= git/commit/?id=3D2743f3e0444f7287161ecf3e464ee2733dde412d > > git remote add linux-next https://git.kernel.org/pub/scm/linux/ker= nel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 2743f3e0444f7287161ecf3e464ee2733dde412d > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cros= s W=3D1 O=3Dbuild_dir ARCH=3Dparisc SHELL=3D/bin/bash > >=20 > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > >=20 > > All errors (new ones prefixed by >>, old ones prefixed by <<): > >=20 > >>> ERROR: modpost: "set_posix_acl" [fs/nfsd/nfsd.ko] undefined! > >=20 > > --=20 > > 0-DAY CI Kernel Test Service > > https://01.org/lkp >=20 > Neil, I've reproduced this and confirmed that the following addresses > the error: >=20 > 464 #ifdef CONFIG_FS_POSIX_ACL > 465 if (attr->na_pacl) > 466 attr->na_aclerr =3D set_posix_acl(&init_user_ns, > 467 inode, ACL_TYPE_ACCESS, > 468 attr->na_pacl); > 469 if (!attr->na_aclerr && attr->na_dpacl && S_ISDIR(inode->i_mod= e)) > 470 attr->na_aclerr =3D set_posix_acl(&init_user_ns, > 471 inode, ACL_TYPE_DEFAUL= T, > 472 attr->na_dpacl); > 473 #endif >=20 > I can squash this change into ("NFSD: add posix ACLs to struct nfsd_attrs"). Thanks. I would prefer a fix like diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 8a2731d2969d..eeeadd0b2f13 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -455,11 +455,13 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, if (attr->label && attr->label->len) attr->label_failed =3D security_inode_setsecctx( dentry, attr->label->data, attr->label->len); - if (attr->pacl) + if (IS_ENABLED(CONFIG_FS_POSIX_ACL) && + attr->pacl) attr->acl_failed =3D set_posix_acl(&init_user_ns, inode, ACL_TYPE_ACCESS, attr->pacl); - if (!attr->acl_failed && attr->dpacl && S_ISDIR(inode->i_mode)) + if (IS_ENABLED(CONFIG_FS_POSIX_ACL) && + !attr->acl_failed && attr->dpacl && S_ISDIR(inode->i_mode)) attr->acl_failed =3D set_posix_acl(&init_user_ns, inode, ACL_TYPE_DEFAULT, attr->dpacl); as that is consistent with similar usage in fs/ksmbd/ and with section 21 "Conditional Compilation' in coding-style.rst Thanks, NeilBrown >=20 > -- > Chuck Lever >=20 >=20 >=20 >=20