From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40A6C04A68 for ; Wed, 27 Jul 2022 21:13:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE2D5940029; Wed, 27 Jul 2022 17:13:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9138940012; Wed, 27 Jul 2022 17:13:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D58BC940029; Wed, 27 Jul 2022 17:13:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C6971940012 for ; Wed, 27 Jul 2022 17:13:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 974AD40D45 for ; Wed, 27 Jul 2022 21:13:51 +0000 (UTC) X-FDA: 79734131862.08.417E2D6 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 187A6A00B8 for ; Wed, 27 Jul 2022 21:13:50 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id o12so214248pfp.5 for ; Wed, 27 Jul 2022 14:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YHrp+/mnJmHfV69EUAYZdN7aFUtabolaTlyqxdvvPaU=; b=Jtp2twDnzN+4lWaWTsFbsKGaBtyat8ch1PmoFuOXt68nO5wqOiMFomfJhAZjw3mihm Cj6sAu38qi4Mhu0CXP0FrbKv+B9zeWomjPcPK7nT9VNK3aUlepC9S5nuNfviS8aFofK7 CeOTLuly65dMx9aZTq/hzifVONzGQiTDoxNRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YHrp+/mnJmHfV69EUAYZdN7aFUtabolaTlyqxdvvPaU=; b=sOruuklVVNlxXNpBGcwg9Qbu9dVG0KnkS1yvJ7XNKTFcuY+ezy9knhGfQYgUrFtzKN oW+OGSW90v42RJ9R7r4qTMQyKl/D91J9RfAfJL5a++Ou2J0pjtpjiD4l3n40Ps51YZq0 E3L85kVw6sSOrYGhFiTYh3JR9wHyOvIt++B57//Bz0/eDNNdYUT6E20b0x+4zWnA2gJz qW+Ib3VX+Clm502SfLH3BsY+8vgCe0MAbTS47qyWXse2Glh7mnru8OEGpm/NMNKyC3tD eax8mgPr0iLtGshe1IM4Es211QEVsGrtw74nuWkWEpAqmkyQ5+Jk8/Os5qoyvjmeRUSP 3FnQ== X-Gm-Message-State: AJIora/d4QVeqt9x8ma8ZbAxDRSrsjFxaYKet9hkqDI/H3tgHV5oAp6L gaT1SLe2t85Rfd8CKpkGreQU8Q== X-Google-Smtp-Source: AGRyM1vdkfYRiqix/j7n8sooInJkoyk6a2nXU232zrO69Dea58sX+6BxmUs4R8B8kSGyKxalspeuTA== X-Received: by 2002:a63:560d:0:b0:419:759a:6653 with SMTP id k13-20020a63560d000000b00419759a6653mr20669183pgb.219.1658956429931; Wed, 27 Jul 2022 14:13:49 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n17-20020a170902e55100b0016d6c38d37bsm8013304plf.156.2022.07.27.14.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 14:13:49 -0700 (PDT) From: Kees Cook To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, fmdefrancesco@gmail.com, ebiederm@xmission.com, Al Viro Cc: Kees Cook , ira.weiny@intel.com Subject: Re: [PATCH v2] fs: Call kmap_local_page() in copy_string_kernel() Date: Wed, 27 Jul 2022 14:13:44 -0700 Message-Id: <165895642099.601089.13587838249930753502.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220724212523.13317-1-fmdefrancesco@gmail.com> References: <20220724212523.13317-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Jtp2twDn; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658956431; a=rsa-sha256; cv=none; b=2dCeCs7RybP6OuumGu5DXUyHtXZsTStti8hi0ks9SA3n9HnZUevz83pnND8uYIBLeEE0R/ Pezgoew/ZslvIqEyscttzgWbORZctfNjnaynbdrPk/yXLl4C03Hr1ZxwCierIqhPmgw97x QRHnWC9WkETyMIyna3m8LVOxEOWweGc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658956431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YHrp+/mnJmHfV69EUAYZdN7aFUtabolaTlyqxdvvPaU=; b=4+lVOoGZI4Iw4zVNro7jP6gkkIhQ4R3sCWKf2ebYKp5Wf+T6EPzIeAhWdilGR4Iso9qZKB e2id2G77W+gwqgFf3Y1LBu3O+RYj09gkqSgGInWIR01y+XjGMuYM32b7XQ9HxgLE83fmOv Drueew0k4zcHy1l5s2+PTguBX48G8b0= X-Rspamd-Server: rspam10 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Jtp2twDn; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Stat-Signature: 4uuonjybekytkk45zpa1br95ka9az3w9 X-Rspamd-Queue-Id: 187A6A00B8 X-HE-Tag: 1658956430-229624 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 24 Jul 2022 23:25:23 +0200, Fabio M. De Francesco wrote: > The use of kmap_atomic() is being deprecated in favor of kmap_local_page(). > > With kmap_local_page(), the mappings are per thread, CPU local and not > globally visible. Furthermore, the mappings can be acquired from any > context (including interrupts). > > Therefore, replace kmap_atomic() with kmap_local_page() in > copy_string_kernel(). Instead of open-coding local mapping + memcpy(), > use memcpy_to_page(). Delete a redundant call to flush_dcache_page(). > > [...] Applied to for-next/execve, thanks! [1/1] fs: Call kmap_local_page() in copy_string_kernel() https://git.kernel.org/kees/c/0ff95c390bc8 -- Kees Cook