linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liu Xinpeng <liuxp11@chinatelecom.cn>
To: rppt@kernel.org, mawupeng1@huawei.com, jrdr.linux@gmail.com,
	david@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Liu Xinpeng <liuxp11@chinatelecom.cn>
Subject: [PATCH v4] memblock tests: fix compilation errors
Date: Wed, 27 Jul 2022 18:07:33 +0800	[thread overview]
Message-ID: <1658916453-26312-1-git-send-email-liuxp11@chinatelecom.cn> (raw)

Do 'make -C tools/testing/memblock', get the following errors:

memblock.o: In function `memblock_find_in_range.constprop.9':
memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
memblock.o: In function `memblock_mark_mirror':
memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'

Fixes: 902c2d91582c ("memblock: Disable mirror feature if kernelcore is not specified")
Fixes: 14d9a675fd0d ("mm: Ratelimited mirrored memory related warning messages")

Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
Tested-by: Ma Wupeng <mawupeng1@huawei.com>

---
Changelog:
V3 -> V4: Changed the title and add how to reproduce this issue.
V2 -> V3: Fixs should not have word wrap.
V1 -> V2: Removed comma in macro define and addressed review comments.
---
 tools/testing/memblock/internal.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
index c2a492c05e0c..fdb7f5db7308 100644
--- a/tools/testing/memblock/internal.h
+++ b/tools/testing/memblock/internal.h
@@ -9,6 +9,10 @@
 static int memblock_debug = 1;
 #endif
 
+#define pr_warn_ratelimited(fmt, ...)    printf(fmt, ##__VA_ARGS__)
+
+bool mirrored_kernelcore = false;
+
 struct page {};
 
 void memblock_free_pages(struct page *page, unsigned long pfn,
-- 
1.8.3.1



             reply	other threads:[~2022-07-27 10:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 10:07 Liu Xinpeng [this message]
2022-07-29  7:27 ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1658916453-26312-1-git-send-email-liuxp11@chinatelecom.cn \
    --to=liuxp11@chinatelecom.cn \
    --cc=david@redhat.com \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mawupeng1@huawei.com \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox