From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC6CC43334 for ; Thu, 14 Jul 2022 03:25:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0EB394016B; Wed, 13 Jul 2022 23:25:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 996FA940134; Wed, 13 Jul 2022 23:25:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8601194016B; Wed, 13 Jul 2022 23:25:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 72EB2940134 for ; Wed, 13 Jul 2022 23:25:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3C56F60262 for ; Thu, 14 Jul 2022 03:25:39 +0000 (UTC) X-FDA: 79684265598.26.0001CA1 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf30.hostedemail.com (Postfix) with ESMTP id C1C2B80084 for ; Thu, 14 Jul 2022 03:25:36 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0VJHNBNf_1657769100; Received: from localhost(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0VJHNBNf_1657769100) by smtp.aliyun-inc.com; Thu, 14 Jul 2022 11:25:33 +0800 From: Liu Song To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/dmapool.c: avoid duplicate memset within dma_pool_alloc Date: Thu, 14 Jul 2022 11:25:00 +0800 Message-Id: <1657769100-66142-1-git-send-email-liusong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657769139; a=rsa-sha256; cv=none; b=sK5NFk5/ROkBt45H8FiVKhA4mxKcf0iK+fBLyrtn3t0GeLZUWzAPvAMvg9ychsqylXgSgd tvKKKsq+56FpBbekNmfPaSlrKAmgX4omKlmOH5ugkOGERKs0sNoN/dN6gZuUxhkXcoaKM8 ioKnyxM4AjiciT0WWh2Kg1f0+IGkqWU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of liusong@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=liusong@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657769139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=N4FLDq7ByCOMdRzYMR8RWIPhP+3o15k6eYd34PoVkV8=; b=Ip/vYj3RbNw2kP/AGE1v7XdG8NEcrTQQxTQYD/2VOLod5i3/824OrjLTwIX664ZMIbOjNP aP8hG2ZXq5Y6AormjOFYaKjG12pgM2UsENVz3N68DDgpTPapY8PSJTisywCq+THUQrvQVq rNjKD4Wd3V/zJ1NqpYOJNyiw4YP7Oww= X-Rspamd-Queue-Id: C1C2B80084 Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of liusong@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=liusong@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: s6zur5pycz5d5bi8qyari7fjtu7hda61 X-HE-Tag: 1657769136-413541 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Liu Song In "dma_direct_alloc", the allocated memory is explicitly set to 0. If use direct alloc, we need to avoid possible duplicate memset in dma_pool_alloc. Signed-off-by: Liu Song --- mm/dmapool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index a7eb5d0..94f4859 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -21,6 +21,7 @@ #include #include +#include #include #include #include @@ -372,7 +373,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem_flags, #endif spin_unlock_irqrestore(&pool->lock, flags); - if (want_init_on_alloc(mem_flags)) + if (want_init_on_alloc(mem_flags) && get_dma_ops(pool->dev)) memset(retval, 0, pool->size); return retval; -- 1.8.3.1