From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3541DC433EF for ; Wed, 29 Jun 2022 12:14:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 899468E0003; Wed, 29 Jun 2022 08:14:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 849918E0001; Wed, 29 Jun 2022 08:14:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 712968E0003; Wed, 29 Jun 2022 08:14:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5FD2F8E0001 for ; Wed, 29 Jun 2022 08:14:28 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2EE1B20915 for ; Wed, 29 Jun 2022 12:14:28 +0000 (UTC) X-FDA: 79631166216.13.36B1FEF Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf09.hostedemail.com (Postfix) with ESMTP id 6FB83140034 for ; Wed, 29 Jun 2022 12:14:27 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4LY0km363Dz4xZ8; Wed, 29 Jun 2022 22:14:24 +1000 (AEST) From: Michael Ellerman To: "Aneesh Kumar K.V" , mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Kefeng Wang In-Reply-To: <20220629050925.31447-1-aneesh.kumar@linux.ibm.com> References: <20220629050925.31447-1-aneesh.kumar@linux.ibm.com> Subject: Re: [PATCH v3] powerpc/memhotplug: Add add_pages override for PPC Message-Id: <165650485099.3003821.15747455933782484777.b4-ty@ellerman.id.au> Date: Wed, 29 Jun 2022 22:14:10 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of michael@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=michael@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656504867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iGH9y0GIye9QneplIMkt6xW4j6pzWT3A7YKJP5RjgW4=; b=YUWfAlwDbHvtyZ0eGGIVzbErrxVLB62pAt2KCHlA5CEpyVTtPl4Y5NHR9cJqdICUHDdu+8 76mXHkWulHKSAJ5ih8UtPhGo2vjkhEWkqAfk6BZ4TTJb3/9X499Eg+taHHxw9fVYWhKZxw PiW8B/D4xjtZd0wG1CExtPaAYpJvkL0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656504867; a=rsa-sha256; cv=none; b=c0zJCIZZZJ5qM4rF3CF5VTPNB1IIj9p0iKNb9enfbpUsD85XcXP5mmFk6lOZpoeIKe7d1z tj66HZ8QdgNtqebnQacZ2C3+EVvIgtpxnj5kWftUBJ0bOMX+9BpD6+heiVIUeIkvpN4xju SoybP2Yu72XFo4YVeU+ObI7JuJ4MLhE= X-Stat-Signature: 8p64dt6cagpzydiof1nx8kthy7nfabsb X-Rspamd-Queue-Id: 6FB83140034 Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of michael@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=michael@ellerman.id.au X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1656504867-204817 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 29 Jun 2022 10:39:25 +0530, Aneesh Kumar K.V wrote: > With commit ffa0b64e3be5 ("powerpc: Fix virt_addr_valid() for 64-bit Book3E & 32-bit") > the kernel now validate the addr against high_memory value. This results > in the below BUG_ON with dax pfns. > > [ 635.798741][T26531] kernel BUG at mm/page_alloc.c:5521! > 1:mon> e > cpu 0x1: Vector: 700 (Program Check) at [c000000007287630] > pc: c00000000055ed48: free_pages.part.0+0x48/0x110 > lr: c00000000053ca70: tlb_finish_mmu+0x80/0xd0 > sp: c0000000072878d0 > msr: 800000000282b033 > current = 0xc00000000afabe00 > paca = 0xc00000037ffff300 irqmask: 0x03 irq_happened: 0x05 > pid = 26531, comm = 50-landscape-sy > kernel BUG at :5521! > Linux version 5.19.0-rc3-14659-g4ec05be7c2e1 (kvaneesh@ltc-boston8) (gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0, GNU ld (GNU Binutils for Ubuntu) 2.34) #625 SMP Thu Jun 23 00:35:43 CDT 2022 > 1:mon> t > [link register ] c00000000053ca70 tlb_finish_mmu+0x80/0xd0 > [c0000000072878d0] c00000000053ca54 tlb_finish_mmu+0x64/0xd0 (unreliable) > [c000000007287900] c000000000539424 exit_mmap+0xe4/0x2a0 > [c0000000072879e0] c00000000019fc1c mmput+0xcc/0x210 > [c000000007287a20] c000000000629230 begin_new_exec+0x5e0/0xf40 > [c000000007287ae0] c00000000070b3cc load_elf_binary+0x3ac/0x1e00 > [c000000007287c10] c000000000627af0 bprm_execve+0x3b0/0xaf0 > [c000000007287cd0] c000000000628414 do_execveat_common.isra.0+0x1e4/0x310 > [c000000007287d80] c00000000062858c sys_execve+0x4c/0x60 > [c000000007287db0] c00000000002c1b0 system_call_exception+0x160/0x2c0 > [c000000007287e10] c00000000000c53c system_call_common+0xec/0x250 > > [...] Applied to powerpc/fixes. [1/1] powerpc/memhotplug: Add add_pages override for PPC https://git.kernel.org/powerpc/c/ac790d09885d36143076e7e02825c541e8eee899 cheers