From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6FEC761A6 for ; Thu, 6 Apr 2023 14:42:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E01A6B0071; Thu, 6 Apr 2023 10:42:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 090276B0074; Thu, 6 Apr 2023 10:42:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E72576B0075; Thu, 6 Apr 2023 10:42:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D8A5E6B0071 for ; Thu, 6 Apr 2023 10:42:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9C7511A0F75 for ; Thu, 6 Apr 2023 14:42:11 +0000 (UTC) X-FDA: 80651231262.13.2F382EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 06F9FA0006 for ; Thu, 6 Apr 2023 14:42:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MFH7ILfx; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680792129; a=rsa-sha256; cv=none; b=EzIMsayIKAFodgKudKQd2TY0lhbTBMxQQSf1xoLLumx2I/fppScbVFcyqZnbCkPT0BkgFF oU1r6LInpaqmBy+gCJGiHb1T5oG0pFRRnu+hzt/DXDu41MhRwwrBr3KqEwTxaKChhHU/w0 AvQGw0w0d4Avz37Rj18rDrQM1QgqnE4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MFH7ILfx; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680792129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gj/7YiiNEEJ4+hsVKCJkj1HvadHLyL0uUxvEtZRASmc=; b=svnKI/hC8nnHLt7AJUjZOypv8WQII2i7BSOUhyIVpPt2uu+N3RmejAKyB5CB5yw5gVqLKB 6roRycm8AmplG0CdB9caMOwLb7yeizcqaQEfUD5/vAw0L773tRZyUkxPhyql9ft5aWLviJ wnZKgpGVdlvbgmwVvXcBCgWv/OQ944Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680792128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gj/7YiiNEEJ4+hsVKCJkj1HvadHLyL0uUxvEtZRASmc=; b=MFH7ILfxbxZqwO0kUF9n0x6w2yOBze1MxGq/VEeatz4ioSpLISS87DxB3FDvicAARR+9QA s51Ge5pm9TdLPJglEADJtgBgdA4ozmMs2yKsILr6cyhqVmd86lXUWM4E+u/lLbT2p3E3tI QkYVLP3BjATwNTZLVt1NF8ymBEekAZo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-UKC9FofHN8CI_mgL7mgmhQ-1; Thu, 06 Apr 2023 10:42:07 -0400 X-MC-Unique: UKC9FofHN8CI_mgL7mgmhQ-1 Received: by mail-wr1-f70.google.com with SMTP id m4-20020adfa3c4000000b002e75158e632so2327537wrb.17 for ; Thu, 06 Apr 2023 07:42:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680792126; x=1683384126; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gj/7YiiNEEJ4+hsVKCJkj1HvadHLyL0uUxvEtZRASmc=; b=Ki2pah41bsiLHqs1yt3Z9Vvh8Od9kLE7ZEpeMGBltekVyIEKbFP8eQymlbgq0eJk0U Db6qsPkKyhg8xHI8N2PaSpzo22C5Xgze4jkN7qK9Mz1bdQStBsBfzkxpTN0064Cao1+N 05ecoEmwLp0MNjb7UirfoK3IZIX3QvzlxbAtpikSo7fGo/ILvfLVUayXf1Ho50uAwuGL Ge+F1xi50j2puWeeAGhLoUik9WdS7AEFRBTyyPcM8a7o93XqVayBHugJnkeSexCmr2qo Ly0C2nWk4YYkLbDkFKMmuGghk04YGe4nsXjoIRABrVh0fYekW/CObwlmLtSXMS6S5dOw lNwg== X-Gm-Message-State: AAQBX9dMchLvBiMuAUXMuZEYHOnKer7mLWIonDfg85WllA/SajG0swY0 8Y66iQ7lOnFFwfavvkxAH3Ge3idVwitcVVG/OjaTqUMuupfpP/MtLdhV9IJnwxpuIiauu199PYo VDbeFJm+VPq0= X-Received: by 2002:adf:edd1:0:b0:2cf:e436:f722 with SMTP id v17-20020adfedd1000000b002cfe436f722mr7362249wro.64.1680792125939; Thu, 06 Apr 2023 07:42:05 -0700 (PDT) X-Google-Smtp-Source: AKy350aYtbTmofQf/bI+zulYGKU6rzEaLaSQD1iMgTDT9wELk7OW8105qv2TVrk0E+k02OOZTiYupA== X-Received: by 2002:adf:edd1:0:b0:2cf:e436:f722 with SMTP id v17-20020adfedd1000000b002cfe436f722mr7362204wro.64.1680792125568; Thu, 06 Apr 2023 07:42:05 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id m8-20020adffe48000000b002c55521903bsm1942945wrs.51.2023.04.06.07.42.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 07:42:04 -0700 (PDT) Message-ID: <1654e2d5-5a32-a253-e335-0ee42f69f5ef@redhat.com> Date: Thu, 6 Apr 2023 16:42:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 To: Peter Zijlstra , Marcelo Tosatti Cc: Frederic Weisbecker , Yair Podemsky , linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, vschneid@redhat.com, dhildenb@redhat.com, alougovs@redhat.com, jannh@google.com References: <20230404134224.137038-1-ypodemsk@redhat.com> <20230404134224.137038-4-ypodemsk@redhat.com> <20230405195226.GB365912@hirez.programming.kicks-ass.net> <20230406132928.GM386572@hirez.programming.kicks-ass.net> <20230406140423.GA386634@hirez.programming.kicks-ass.net> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 3/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to CPUs in kernel mode In-Reply-To: <20230406140423.GA386634@hirez.programming.kicks-ass.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 06F9FA0006 X-Rspamd-Server: rspam01 X-Stat-Signature: zn1wihktcepibn4cdep9gnhf7pho9imz X-HE-Tag: 1680792128-113499 X-HE-Meta: U2FsdGVkX18C/lpYoqubQZT7Od8zUAgu2fqEMAW3A0ezdEoZ6YwhdSHZZck8IQTG95o1JMtwwoiaRUvo62unQx+8EBH+azJhApMwtS+1lFzqTZTpBIA0evJxaSWm2Q7uMAfQZmi6nv+JyWBjUyg2X4amlPT5D6nF14rGEEaqAzJ1PX5vb7vVsiBI3LT7MfSHt5MX0vkoeAnVydmbexvDmmPIFvWdzeuSsjmICpEFpm1ZwlKLc+wKCjLFFxzLoI+0ZR03fzkcNh1qeQFTCYKRvbShZ2ZJvzfRk22/HKf4s1ipoanMkjz0w9XqUfWR3yGvjU1fpUVv5MzR0G2fRndmlkwNALsAGsAh2vI+In7BOC5FgQGnUniAf8iSmdmwzjXEbcBf6jPipJghafxwYGld+/djZmvVJ+DZhhxK/oa3U3yjLZdvv2ubSp3UjnJxWbUvw0GtL+vobuNsTb9G0wwHoifbskVdIIdte+IbAnDnl/MS+GZqSTwo7HZLHdWVSIDoBf2OwE8FOYzNX5jvza+YFCj47QZolQqWSwMDQ6QtyysTTw7JcYbQkSp9VgxxEXYoN3peJBFV3e2xwX5WlavVmrmC1G6k/czrxdupCtS3k8Lg0bmBlrAM4hpSjkwB5UZFaxSCyciN8n3xczZ4dysXj5Yd8icTh8eqezfV5GvDva+OnENnzXMhzQ+x+71iVCEFZs7V7EAedH0EI458BzsZO7OxNs7VQEYiNs211dTXD/0SNbSOzJqO0K9Jp9MFX90a24eV2S4Jkh9FjgUMTaRyZN88pM6xK842iRZ/2woVGDw/JmqFnUMlNaTWbmnUWJmIgqM0HOWDQYx9WorCu3oMarfId/oKK/LYrPsL8AFXxtQNjdC9WoWNqREqVR92/6PO4a+1CG3hF4CQD0AXpIjaVTKLmCaGOCqMdofrIhktZsfwcfJVgIEKsGJg5x7WYq2RUE7ge4d+CUUP/oscS+8 L89ah6bS mYhIIzy6z7pNFpjvQr9ci19iCBWD4cuL5o17NnvEeWXRU0n7df5PQK3EJwF0E4Djwu93yBzdMai/5FDDqRc1/ZTbAxjSJkJaB0n4Nt/McaEIouZJUc5/omqdd6E6euckWEnJYAtdSs3OKk1yF2H7z7ckrrX8Xi775PydMfKC9GI9KeNXA/p21iXOWc7GiGOut1TMHECjv+3h2WKuuhwKwfWVG4TRE/uyDs8Ir8quvCx4UvtayK45fYlYQxk2PHu+ZIZysY/bGWIOVrQ0h+O50q5g0PHDUhQsl1ArO70Ox1Irr/btUhXZlZ7w9crxzxvn5Fkg2CjRDDmS/FkrJIzaz1534tYvnveN7/2OV0yQkbkxaYD0ljQI0O+KBv6ZqtFHrTEnidxrsHXEB/xJLsWKfes1F4dn1LeirsWIyc+EeijNWjgoH7xhgbR8RKc9XgjiFAPKHEHS2qo8E9Z/9O3O/QF4Vg4jOd8RMi1W2+FT+kqWvSqqYm7pUDFX+A7mU3f4/BuC4/L99pRq4nVYhZKrcAGN+AcZmgBPl13IJ58bnqMmObdjva2GIdYKufw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.04.23 16:04, Peter Zijlstra wrote: > On Thu, Apr 06, 2023 at 03:29:28PM +0200, Peter Zijlstra wrote: >> On Thu, Apr 06, 2023 at 09:38:50AM -0300, Marcelo Tosatti wrote: >> >>>> To actually hit this path you're doing something really dodgy. >>> >>> Apparently khugepaged is using the same infrastructure: >>> >>> $ grep tlb_remove_table khugepaged.c >>> tlb_remove_table_sync_one(); >>> tlb_remove_table_sync_one(); >>> >>> So just enabling khugepaged will hit that path. >> >> Urgh, WTF.. >> >> Let me go read that stuff :/ > > At the very least the one on collapse_and_free_pmd() could easily become > a call_rcu() based free. > > I'm not sure I'm following what collapse_huge_page() does just yet. It wants to replace a leaf page table by a THP (Transparent Huge Page mapped by a PMD). So we want to rip out a leaf page table while other code (GUP-fast) might still be walking it. In contrast to freeing the page table, we put it into a list where it can be reuse when having to PTE-map a THP again. Now, similar to after freeing the page table, someone else could reuse that page table and modify it. If we have GUP-fast walking the page table while that is happening, we're in trouble. So we have to make sure GUP-fast is done before enqueuing the now-free page table. That's why the tlb_remove_table_sync_one() was recently added (by Jann IIRC). -- Thanks, David / dhildenb