From: Vivek Kumar <quic_vivekuma@quicinc.com>
To: <corbet@lwn.net>, <catalin.marinas@arm.com>, <will@kernel.org>,
<tglx@linutronix.de>, <maz@kernel.org>, <axboe@kernel.dk>,
<rafael@kernel.org>, <akpm@linux-foundation.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-block@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<linux-mm@kvack.org>
Cc: <len.brown@intel.com>, <pavel@ucw.cz>, <paulmck@kernel.org>,
<bp@suse.de>, <keescook@chromium.org>, <songmuchun@bytedance.com>,
<rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
<pasha.tatashin@soleen.com>, <tabba@google.com>,
<ardb@kernel.org>, <tsoni@quicinc.com>,
<quic_psodagud@quicinc.com>, <quic_svaddagi@quicinc.com>,
Vivek Kumar <quic_vivekuma@quicinc.com>,
Prasanna Kumar <quic_kprasan@quicinc.com>
Subject: [RFC 4/6] mm: swap: Add randomization check for swapon/off calls
Date: Wed, 18 May 2022 13:18:39 +0530 [thread overview]
Message-ID: <1652860121-24092-5-git-send-email-quic_vivekuma@quicinc.com> (raw)
In-Reply-To: <1652860121-24092-1-git-send-email-quic_vivekuma@quicinc.com>
Add addtional check on swapon/swapoff sycalls to disable
randomization of swap offsets if GENHD_FL_NO_RANDOMIZE
flag is passed.
Signed-off-by: Vivek Kumar <quic_vivekuma@quicinc.com>
Signed-off-by: Prasanna Kumar <quic_kprasan@quicinc.com>
---
mm/swapfile.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 1c3d5b9..a3eeab6 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2474,7 +2474,8 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile)
if (p->flags & SWP_CONTINUED)
free_swap_count_continuations(p);
- if (!p->bdev || !bdev_nonrot(p->bdev))
+ if (!p->bdev || (p->bdev->bd_disk->flags & GENHD_FL_NO_RANDOMIZE)
+ || !bdev_nonrot(p->bdev))
atomic_dec(&nr_rotate_swap);
mutex_lock(&swapon_mutex);
@@ -3065,7 +3066,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
if (p->bdev && p->bdev->bd_disk->fops->rw_page)
p->flags |= SWP_SYNCHRONOUS_IO;
- if (p->bdev && bdev_nonrot(p->bdev)) {
+ if (p->bdev && !(p->bdev->bd_disk->flags & GENHD_FL_NO_RANDOMIZE) &&
+ bdev_nonrot(p->bdev)) {
int cpu;
unsigned long ci, nr_cluster;
--
2.7.4
next prev parent reply other threads:[~2022-05-18 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 7:48 [RFC 0/6] Bootloader based hibernation Vivek Kumar
2022-05-18 7:48 ` [RFC 1/6] arm64: hibernate: Introduce new entry point to kernel Vivek Kumar
2022-05-19 15:27 ` Marc Zyngier
2022-05-18 7:48 ` [RFC 2/6] PM: Hibernate: Add option to disable disk offset randomization Vivek Kumar
2022-05-18 12:19 ` Andrew Lunn
2022-05-18 13:00 ` Christoph Hellwig
2022-05-23 20:49 ` Randy Dunlap
2022-05-18 7:48 ` [RFC 3/6] block: gendisk: Add a new genhd capability flag Vivek Kumar
2022-05-18 8:08 ` Christoph Hellwig
2022-05-18 7:48 ` Vivek Kumar [this message]
2022-05-18 12:27 ` [RFC 4/6] mm: swap: Add randomization check for swapon/off calls Andrew Lunn
2022-05-18 7:48 ` [RFC 5/6] Hibernate: Add check for pte_valid in saveable page Vivek Kumar
2022-05-18 13:09 ` Christoph Hellwig
2022-05-18 7:48 ` [RFC 6/6] irqchip/gic-v3: Re-init GIC hardware upon hibernation restore Vivek Kumar
2022-05-19 7:59 ` Marc Zyngier
2022-05-18 16:55 ` [RFC 0/6] Bootloader based hibernation Pasha Tatashin
2022-05-20 16:43 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1652860121-24092-5-git-send-email-quic_vivekuma@quicinc.com \
--to=quic_vivekuma@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=axboe@kernel.dk \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=paulmck@kernel.org \
--cc=pavel@ucw.cz \
--cc=quic_kprasan@quicinc.com \
--cc=quic_psodagud@quicinc.com \
--cc=quic_svaddagi@quicinc.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=songmuchun@bytedance.com \
--cc=tabba@google.com \
--cc=tglx@linutronix.de \
--cc=tsoni@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox