From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F636C433EF for ; Mon, 16 May 2022 22:53:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13ADD6B0074; Mon, 16 May 2022 18:53:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EA4D6B0075; Mon, 16 May 2022 18:53:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF4A56B0078; Mon, 16 May 2022 18:53:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD70A6B0074 for ; Mon, 16 May 2022 18:53:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A9FBE32C53 for ; Mon, 16 May 2022 22:53:22 +0000 (UTC) X-FDA: 79473109044.04.4BA40D2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 3A004180051 for ; Mon, 16 May 2022 22:53:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54A0260C26; Mon, 16 May 2022 22:53:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68104C385B8; Mon, 16 May 2022 22:53:18 +0000 (UTC) From: Catalin Marinas To: Baolin Wang , will@kernel.org Cc: christophe.leroy@csgroup.eu, anshuman.khandual@arm.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mike.kravetz@oracle.com, willy@infradead.org, songmuchun@bytedance.com Subject: Re: [PATCH v3 0/2] Implement arm64 specific huge_ptep_get() Date: Mon, 16 May 2022 23:53:15 +0100 Message-Id: <165274157825.4033361.18236433604256004496.b4-ty@arm.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Stat-Signature: zdxaorwtaqmo7ii1ghn469ew5nteamuz Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3A004180051 X-HE-Tag: 1652741592-952143 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 16 May 2022 08:55:56 +0800, Baolin Wang wrote: > As Mike pointed out [1], the huge_ptep_get() will only return one specific > pte value for the CONT-PTE or CONT-PMD size hugetlb on ARM64 system, which > will not take into account the subpages' dirty or young bits of a CONT-PTE/PMD > size hugetlb page. That will make us miss dirty or young flags of a CONT-PTE/PMD > size hugetlb page for those functions that want to check the dirty or > young flags of a hugetlb page. For example, the gather_hugetlb_stats() will > get inaccurate dirty hugetlb page statistics, and the DAMON for hugetlb monitoring > will also get inaccurate access statistics. > > [...] Applied to arm64 (for-next/misc), thanks! [1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page https://git.kernel.org/arm64/c/f0d9d79ec793 [2/2] arm64/hugetlb: Implement arm64 specific huge_ptep_get() https://git.kernel.org/arm64/c/bc5dfb4fd7bd -- Catalin