From: Catalin Marinas <catalin.marinas@arm.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>, will@kernel.org
Cc: christophe.leroy@csgroup.eu, anshuman.khandual@arm.com,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mike.kravetz@oracle.com, willy@infradead.org,
songmuchun@bytedance.com
Subject: Re: [PATCH v3 0/2] Implement arm64 specific huge_ptep_get()
Date: Mon, 16 May 2022 23:53:15 +0100 [thread overview]
Message-ID: <165274157825.4033361.18236433604256004496.b4-ty@arm.com> (raw)
In-Reply-To: <cover.1652496622.git.baolin.wang@linux.alibaba.com>
On Mon, 16 May 2022 08:55:56 +0800, Baolin Wang wrote:
> As Mike pointed out [1], the huge_ptep_get() will only return one specific
> pte value for the CONT-PTE or CONT-PMD size hugetlb on ARM64 system, which
> will not take into account the subpages' dirty or young bits of a CONT-PTE/PMD
> size hugetlb page. That will make us miss dirty or young flags of a CONT-PTE/PMD
> size hugetlb page for those functions that want to check the dirty or
> young flags of a hugetlb page. For example, the gather_hugetlb_stats() will
> get inaccurate dirty hugetlb page statistics, and the DAMON for hugetlb monitoring
> will also get inaccurate access statistics.
>
> [...]
Applied to arm64 (for-next/misc), thanks!
[1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page
https://git.kernel.org/arm64/c/f0d9d79ec793
[2/2] arm64/hugetlb: Implement arm64 specific huge_ptep_get()
https://git.kernel.org/arm64/c/bc5dfb4fd7bd
--
Catalin
prev parent reply other threads:[~2022-05-16 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 0:55 Baolin Wang
2022-05-16 0:55 ` [PATCH v3 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page Baolin Wang
2022-05-16 0:55 ` [PATCH v3 2/2] arm64/hugetlb: Implement arm64 specific huge_ptep_get() Baolin Wang
2022-05-16 22:53 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165274157825.4033361.18236433604256004496.b4-ty@arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox