From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B88C6FD18 for ; Tue, 25 Apr 2023 13:13:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F75E6B0071; Tue, 25 Apr 2023 09:13:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A6A46B0072; Tue, 25 Apr 2023 09:13:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26EF46B0075; Tue, 25 Apr 2023 09:13:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 12BE56B0071 for ; Tue, 25 Apr 2023 09:13:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DEE051C5D0B for ; Tue, 25 Apr 2023 13:13:40 +0000 (UTC) X-FDA: 80719955400.04.48C21CF Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf19.hostedemail.com (Postfix) with ESMTP id F085F1A0003 for ; Tue, 25 Apr 2023 13:13:37 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ZFeQwY+m; spf=pass (imf19.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682428418; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fw45IBooJRHvDJP+m4fpf4zEkBLCSMIA1zdZRImyULk=; b=xIFia/FPlca8QU/Is+AYSq94SwlN4vT91X22hewWiW+Zh9yQzxVc5Kjdp3rfUYVTC9wowm vULEcmegGIqYMAPQIYK+VT3PRCHbwTjwbO5ZwJGmprqEN9DmVa4UFpHIffsx4gil6zpy5C e4HJnALknxejh/8jarz3afH+iVnEyEA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ZFeQwY+m; spf=pass (imf19.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682428418; a=rsa-sha256; cv=none; b=xphClr9CeW1yHwExTFkNsRtOJus5wTb9y9v4uLFZTxejyh+ge/HbB5Hftdu/fP8xgxv8lm /rb5clr09rW+e03WZppyu8HHr97MAoqj01fe5rOB/3gpv8fBrX99KNGZbrwrgrgTpei3oe L7KKRGuQlul3EZqkJiNcKcpzlqpVw4A= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f1957e80a2so114369205e9.1 for ; Tue, 25 Apr 2023 06:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682428416; x=1685020416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fw45IBooJRHvDJP+m4fpf4zEkBLCSMIA1zdZRImyULk=; b=ZFeQwY+mbxyNnRrEcmbP0LbvvvP/dsWeQIgdx1wq33ZQUes3ma9nFUCuBK4hm9D8t9 2vSSeOMEyQ0LiP9Ea/aEulIGGvevMxeLnyX30c2Z5/j52tRL1eu/G6MO48aSwKCZDfpC M0NVlp9ax8nlQDdqPDKR/yoGIZCdMkr6QVhAm8ZAcoC5L6Yij/fAwxda3Z4Rxsvayym3 ZIS0XIf5s1yauv4Dgt35c/+032/XoKewUsehNTRpykyaCw6+7fnF3R558UUePAloGEGs PwcryNMTI0ukCsjuIH+CmyQDVcehbv3oFZAOXlwjAyW81xxSy/RdsbbTFIF30oHWwQ0e mFpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682428416; x=1685020416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fw45IBooJRHvDJP+m4fpf4zEkBLCSMIA1zdZRImyULk=; b=RPqwYoNVQtZbw5cdIAlCRWS40ZPrsJBK7ae8FPZO/H12i14MqSORvtlytCwnq1V4cj iN+1qeHeU/yriofcLY+Gh5ksZaVTCu3biaTdb8YpkdmqEWG9txiQYCZ1VpZtas7AqoZ2 t9AzzXnNPCbqwxz7sZWWe8+hAx11QwyRQHoElnhQdPA0hq7VZ8Bxlk5JwbVGDDpLXc1M J+0vWDj9NB+VyHbhHAAB6APVUf3Vt3ocCRreWfjU5k1BSO+JNEnPWeQ1E6YFDGUabPSU UwQul8ZVkB57LdMoPSGV3UzMjIP8x2GnlreVZ4F+NEopJZeTluZcKhKdT3Goc35xqjno EPCA== X-Gm-Message-State: AAQBX9ck7Wd3l8nAwsjxNGTsDAc7PTwgLyh6EJdk5972Y51b71WnWUE1 JLGP9rRfdtdGWlS2RF1Rii0= X-Google-Smtp-Source: AKy350Z8ytvRYve3cZYjp0OE8W8Wzr1SScE5AHXMmPrw8AtAgr1i/+uLqhz9f/CdQgqVBDusJJLr4Q== X-Received: by 2002:a7b:cc15:0:b0:3f1:65cb:8156 with SMTP id f21-20020a7bcc15000000b003f165cb8156mr10532957wmh.0.1682428416163; Tue, 25 Apr 2023 06:13:36 -0700 (PDT) Received: from suse.localnet (host-95-245-6-24.retail.telecomitalia.it. [95.245.6.24]) by smtp.gmail.com with ESMTPSA id d3-20020a05600c3ac300b003f19b3d89e9sm8697700wms.33.2023.04.25.06.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 06:13:35 -0700 (PDT) From: "Fabio M. De Francesco" To: David Howells Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Martin K. Petersen" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: Re: [PATCH v3 41/55] iscsi: Assume "sendpage" is okay in iscsi_tcp_segment_map() Date: Tue, 25 Apr 2023 15:13:33 +0200 Message-ID: <16526634.geO5KgaWL5@suse> In-Reply-To: <494037.1682411430@warthog.procyon.org.uk> References: <1957131.PYKUYFuaPT@suse> <20230331160914.1608208-42-dhowells@redhat.com> <494037.1682411430@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F085F1A0003 X-Stat-Signature: paxafcy1awqm79ixzycrx5m48nr181df X-HE-Tag: 1682428417-350079 X-HE-Meta: U2FsdGVkX1/CJFSIaXNQg+7veBBIvg2roVinDr7mj+Pv2KdG2G7MMuI7p6x3Rr7R7ZMyQYR6u1QaEsVY4x0EibMjg68KHtC+pp1b1+qmdVq/lcjbUES1yIWd9p6Q7fAqQOu5gTPWejVsJAsVYYZ0nNbHOWnbP+iISoKj7cgnJSs2+L6T75aN7ImB17nCzaT8vvnzbrtN6ogWzRa/RbCWCRLqr+tZur6UG+rudjWp7RujTl6KufbCVUo21KmUlDDigt2FNfAv5DZOahr0N1kl6tTy293JUzp6KgsmNiCHet1x2JcEZPqIG9sWBKY3STFsKWJ7RWL/6QOvGOiRB72FhrdhZIQpOpNVK9PH6gl7EcuVHDH37RnQSi34bDnJ4u7zWfuKDQlMgT62H4UIaIBev//5aJZDAILNG43O8MhJ4cnbXshFXDhNrmSpmXQen5+Hqae0GMJu0RSO28b5v6znn9T8cIeM/FhnDrxpt7j5NQ5badXmAfZe/YMEzYY7PlPto/AzGDYxnHz1LY4vCUGmEq0BdycGfgJK3B4/2bhK0Z69xZ1s5d1vBt+QIRB18BfxF90re4mp/BuTBYxp6i/p4yP2qGOyYd+9793gLznrhcuPUUmqVyfBWqrelLxRWghGO56g50zaQao5kjLxrW5J3kQbH2pG7V7DG43h8MJA2AcQlN5RWE3GbH1UOOlvxS8ht6eNwzla4t3Ca/PhLR8vxYoem1dPSANijjpb9Gga05gRJvh97PcH4fJ4LsuR76R44N9WLNnozPUYGtpPIoue3SiBF1bG8q03GsYnD2Q5JYny6yMDDHIEvMNGQjSMzhSRjZQosbGETMsve/uVvXoVBGDRvXDp8NA/QCbV2HDQSpqb3JupUQDo1v7+ct8AuuT2SaBxL8jLnbxXmi/c4hWi6XikdRDdZVt03BC3Ap9N59c97Hoy4ksF9ohlpPWrZVF540kCl8SBoyzSR5GOJ/v vaVo0YYe AeAUCUgMdFe95UxS08pIYxzlm6F31uW6kUQ29dVgwNZNUBCHcLfkuaJHDRgqD5KuXCWAqW4WMXAfLX91kvkIHVe7G6i/a6VBbT57TffExME1LRQRHLWcDCjiBw/ImXxe5XBVs9VRC2Ll9F9acP1u4HPMLuXkBej2QjYH5fCu/A7evgPb0RioI5mh5/RgUOkcofMZz0prWrOC+04idKvX6JUGQgtUT29NrwbEmenG+hgBt92BA1D9uHqzzgdVe8GrdL7qLCD7PC5A2Z7gfMksK13Funt6GqgaRq9gCDQVfJyn6sc5YH5giIiLlJTWThmCoXzbGF7RRZP7Ff73arkNIjnj3rc7vyJM8lfDYF+HJMjERMCoiwnfingXJuPooNiI5aNDLlIiCY+43YwynXan2Fr0oXwd85nwyOfMTka6hX43QL6VrEGXXyGSBSfcp9QDJ4XXtsu5PSIkfzzI/x42I1Cm2ZGqMf9GI7WgF+b/xWWUvkcLkqIxyNg7b6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On marted=EC 25 aprile 2023 10:30:30 CEST David Howells wrote: > Fabio M. De Francesco wrote: > > > - if (recv) { > > > - segment->atomic_mapped =3D true; > > > - segment->sg_mapped =3D kmap_atomic(sg_page(sg)); > > > - } else { > > > - segment->atomic_mapped =3D false; > > > - /* the xmit path can sleep with the page mapped so use > >=20 > > kmap */ > >=20 > > > - segment->sg_mapped =3D kmap(sg_page(sg)); > > > - } > > > - > > > + segment->atomic_mapped =3D true; > > > + segment->sg_mapped =3D kmap_atomic(sg_page(sg)); > >=20 > > As you probably know, kmap_atomic() is deprecated. > >=20 > > I must admit that I'm not an expert of this code, however, it looks lik= e=20 the > > mapping has no need to rely on the side effects of kmap_atomic() (i.e., > > pagefault_disable() and preempt_disable() - but I'm not entirely sure=20 about > > the possibility that preemption should be explicitly disabled along wit= h=20 the > > replacement with kmap_local_page()). > >=20 > > Last year I've been working on several conversions from kmap{,_atomic}(= )=20 to > > kmap_local_page(), however I'm still not sure to understand what's=20 happening > > here... > >=20 > > Am I missing any important details? Can you please explain why we still= =20 need > > that kmap_atomic() instead of kmap_local_page()? >=20 > Actually, it might be worth dropping segment->sg_mapped and segment->data= =20 and > only doing the kmap_local when necessary. >=20 > And this: >=20 > struct msghdr msg =3D { .msg_flags =3D flags }; > struct kvec iov =3D { > .iov_base =3D segment->data + offset, > .iov_len =3D copy > }; >=20 > r =3D kernel_sendmsg(sk, &msg, &iov, 1, copy); >=20 > should really be using struct bvec, not struct kvec - then the mapping is= n't > necessary. =46WIW, struct bvec looks better suited (despite I have very little knowled= ge of=20 this code). I assume that you noticed that we also have the unmapping counterpart=20 (iscsi_tcp_segment_unmap()) which should also be addressed accordingly. > It looks like this might be the only place the mapping is used, > but I'm not 100% certain. It seems that kmap_atomic() (as well as kmap(), which you deleted) is only= =20 called by iscsi_tcp_segment_map(), which in turn is called only by =20 iscsi_tcp_segment_done(). I can't see any other places where the mapping is= =20 used. I hope that this dialogue may help you somehow to choose the best suited wa= y=20 to get rid of that deprecated kmap_atomic(). Thanks for taking time to address questions from newcomers :-)=20 =46abio >=20 > David