From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEA7C433F5 for ; Thu, 12 May 2022 05:39:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 245EC6B0074; Thu, 12 May 2022 01:39:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F65B6B0075; Thu, 12 May 2022 01:39:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E5C66B0078; Thu, 12 May 2022 01:39:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F37646B0074 for ; Thu, 12 May 2022 01:39:53 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD3D820ABE for ; Thu, 12 May 2022 05:39:53 +0000 (UTC) X-FDA: 79455989466.05.B2FAC4B Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf14.hostedemail.com (Postfix) with ESMTP id 393721000AE for ; Thu, 12 May 2022 05:39:51 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id l11-20020a17090a49cb00b001d923a9ca99so3939507pjm.1 for ; Wed, 11 May 2022 22:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y+ADADOLsy5U0cbqUSAL8sVCV2JHFFb6d6snlliJvBk=; b=CW1zEzHl2MHW93A2lOFLisKLVaijVGVVOUbJG+LpYd/sEPsAq1gJ4cZLkYTgdYyeq9 luxVY40W6rvMrywxYpQGit5+fe+LYvyCUUjqptcXIlkkwUsyu+YSIV0NWVRcHhwnVVfh 4OZSrJP7mHtdXyaAovFq2mqhstaDb0N6wzo3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y+ADADOLsy5U0cbqUSAL8sVCV2JHFFb6d6snlliJvBk=; b=C/2Aplo4c7i2joc54hYYkXqFAd/wLj+PrjYIaUyAZJCGO2ANoHxK4l1sbLzGW3bdcO Y1jPrwO32dHyBR/+wqFufEe6Klcs588jsDVYJM6lMmMJf2v+LSOjBnQ1ea4WSy3En48y wuPlTViniMWphtGvnrvm3EV3oUcH5KZvNdWskbKYxTfgKUlazsvHbt2W6tCQ3IttSOTv 5jW77XPwKIWdAwz/VqiOkfXP8tfwMSjGEB0gzvD4TWt2qEDOU6if6RnlJcn6YVPYSbXR TeLmbtA6UERO8Yq88oB+k4IlueCZ9rYddp2CWz2YzyDsxquNBfruN2ZS7J3Tg8AImEq7 vGjA== X-Gm-Message-State: AOAM5318BCVqYZJouwapIiaZSXmkxP2ovQRJzOFDOgzhyU6VE7Iy9qWu lfHzhBnCBfoPTSQf025ifsfq/ETer17mbw== X-Google-Smtp-Source: ABdhPJzpiXxGpg3/2XDINmqm/PjN3LkXht9fMp4MYaS4FJyG7BSAhZVDPSpPqMiJLhETFW+kFl0k3Q== X-Received: by 2002:a17:902:a9ca:b0:15e:f017:91b5 with SMTP id b10-20020a170902a9ca00b0015ef01791b5mr27782532plr.27.1652333992397; Wed, 11 May 2022 22:39:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f10-20020a170902ab8a00b0015e8d4eb1casm2880921plr.20.2022.05.11.22.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 22:39:52 -0700 (PDT) From: Kees Cook To: songyuanzheng@huawei.com, Andrew Morton Cc: Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: usercopy: move the virt_addr_valid() below the is_vmalloc_addr() Date: Wed, 11 May 2022 22:39:41 -0700 Message-Id: <165233397814.161845.13267754142064821597.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220505071037.4121100-1-songyuanzheng@huawei.com> References: <20220505071037.4121100-1-songyuanzheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=CW1zEzHl; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 393721000AE X-Stat-Signature: pb8t84u714cwx4fz639pz7f6q1exjd8e X-HE-Tag: 1652333991-213163 X-Bogosity: Ham, tests=bogofilter, spamicity=0.270462, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 5 May 2022 07:10:37 +0000, Yuanzheng Song wrote: > The is_kmap_addr() and the is_vmalloc_addr() in the check_heap_object() > will not work, because the virt_addr_valid() will exclude the kmap and > vmalloc regions. So let's move the virt_addr_valid() below > the is_vmalloc_addr(). Applied to for-next/hardening, thanks! [1/1] mm: usercopy: move the virt_addr_valid() below the is_vmalloc_addr() https://git.kernel.org/kees/c/0a76d4c331b4 -- Kees Cook