From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA3D8C433EF for ; Mon, 2 May 2022 16:07:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CD3D6B0071; Mon, 2 May 2022 12:07:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47BEC6B0073; Mon, 2 May 2022 12:07:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31C316B0074; Mon, 2 May 2022 12:07:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 1C2D76B0071 for ; Mon, 2 May 2022 12:07:49 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D80B160EC1 for ; Mon, 2 May 2022 16:07:48 +0000 (UTC) X-FDA: 79421283816.14.3707786 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf01.hostedemail.com (Postfix) with ESMTP id D111340083 for ; Mon, 2 May 2022 16:07:40 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id v10so11995491pgl.11 for ; Mon, 02 May 2022 09:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=vmp9CQIj1Zs/em4uo2GbHk0NnCqJbYnCBw5TO/vJ0eE=; b=DkgHRwBeptOQUef7LWCd9qKGFhzSbT3Ijmd+WMgxscmZkJoRtExzgWwlapmqlIGmfI mu+FjCmNhJRStsbeODKe5Negvi6KvW6ZBRGPlb5+16I4sOhH9x6y9noeRGSH8ZrOuKnk lnEEBiToVM2DyhbQc53hR6aI53AIhWAPiWyzVYAu+daHb9UzbhIIOk7Vbj5IwoANmyVV Bf/HTXoBhEnIKPYm3UTssLxE+VEM1H8AslebOd37GqDC6JsAZ9QFIcwkMO8ykJR+Vp15 0Xh3qyuHcff8GNtu2J2IGOwEGhwmhwo8o1ZMU8Sinwr1JUi0N4c2NLxgPLv2zZ8Q6bsJ P9XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=vmp9CQIj1Zs/em4uo2GbHk0NnCqJbYnCBw5TO/vJ0eE=; b=TWkvpY0y6y8KScwzNfBtCfFwTXBJ+v6FIuBnay5uehUm67suL1Wo+TNEXf2vLD523Q 9ozj3hkfnyofwC6d1+jG6Tw2bVbWaJH3gUxp5nbnJrNVdFEfhkkjH5rhYac6248y/BX4 AaasZhWQHorpv34eZ2g7XudMJHLOhkr8KDBANf6AwRzPMz3EBKssnLGUGYHSk8zpuO8d PKqCwRlF8H96JVAWAjek3NopEPFBMEyJJ/G1trvRT3V+rflaw1MJBSmsD4ijlpbw1xaI ckKNd7SJUz8IBZvz8DzKvJwPFcBkyNJb6SWXncIcINwvZBgcs6Sgn7f1fruS0D4jQi8L UMag== X-Gm-Message-State: AOAM531GP+j1O4DahbH4rlwCLqYYR5wxddSxArL0YIjh5G+9+oSd7K/X r72lo99F05FdKpiVE76Dz6rpYw== X-Google-Smtp-Source: ABdhPJxN7SayQGlnlRlAnxrbhg/8PgwF1fcHSSb/MBaeXeimsNPqrIIR1crr/+zE4OKE6Nsu7mKRzA== X-Received: by 2002:a05:6a00:1515:b0:50d:bc1a:f7b3 with SMTP id q21-20020a056a00151500b0050dbc1af7b3mr12207502pfu.37.1651507666742; Mon, 02 May 2022 09:07:46 -0700 (PDT) Received: from [127.0.1.1] ([8.34.116.185]) by smtp.gmail.com with ESMTPSA id g25-20020a62e319000000b0050dc7628168sm4883880pfh.66.2022.05.02.09.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 09:07:46 -0700 (PDT) From: Jens Axboe To: ming.lei@redhat.com Cc: linux-block@vger.kernel.org, Christoph Hellwig , czhong@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org In-Reply-To: <20220420143110.2679002-1-ming.lei@redhat.com> References: <20220420143110.2679002-1-ming.lei@redhat.com> Subject: Re: [PATCH V2] block: ignore RWF_HIPRI hint for sync dio Message-Id: <165150766572.3972.14278571508374814557.b4-ty@kernel.dk> Date: Mon, 02 May 2022 10:07:45 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D111340083 X-Stat-Signature: ccyw5n6zb43p8jnrif8mwdobiemcqw3o X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=DkgHRwBe; spf=pass (imf01.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.180 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-HE-Tag: 1651507660-202295 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 20 Apr 2022 22:31:10 +0800, Ming Lei wrote: > So far bio is marked as REQ_POLLED if RWF_HIPRI/IOCB_HIPRI is passed > from userspace sync io interface, then block layer tries to poll until > the bio is completed. But the current implementation calls > blk_io_schedule() if bio_poll() returns 0, and this way causes io hang or > timeout easily. > > But looks no one reports this kind of issue, which should have been > triggered in normal io poll sanity test or blktests block/007 as > observed by Changhui, that means it is very likely that no one uses it > or no one cares it. > > [...] Applied, thanks! [1/1] block: ignore RWF_HIPRI hint for sync dio commit: 9650b453a3d4b1b8ed4ea8bcb9b40109608d1faf Best regards, -- Jens Axboe