From: Jens Axboe <axboe@kernel.dk>
To: ming.lei@redhat.com
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
czhong@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH V2] block: ignore RWF_HIPRI hint for sync dio
Date: Mon, 02 May 2022 10:07:45 -0600 [thread overview]
Message-ID: <165150766572.3972.14278571508374814557.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220420143110.2679002-1-ming.lei@redhat.com>
On Wed, 20 Apr 2022 22:31:10 +0800, Ming Lei wrote:
> So far bio is marked as REQ_POLLED if RWF_HIPRI/IOCB_HIPRI is passed
> from userspace sync io interface, then block layer tries to poll until
> the bio is completed. But the current implementation calls
> blk_io_schedule() if bio_poll() returns 0, and this way causes io hang or
> timeout easily.
>
> But looks no one reports this kind of issue, which should have been
> triggered in normal io poll sanity test or blktests block/007 as
> observed by Changhui, that means it is very likely that no one uses it
> or no one cares it.
>
> [...]
Applied, thanks!
[1/1] block: ignore RWF_HIPRI hint for sync dio
commit: 9650b453a3d4b1b8ed4ea8bcb9b40109608d1faf
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2022-05-02 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:31 Ming Lei
2022-04-21 7:02 ` Christoph Hellwig
2022-04-21 11:48 ` Changhui Zhong
2022-05-02 16:01 ` Ming Lei
2022-05-02 16:07 ` Jens Axboe [this message]
2022-05-23 22:36 ` Keith Busch
2022-05-24 0:40 ` Ming Lei
2022-05-24 3:02 ` Keith Busch
2022-05-24 4:34 ` Keith Busch
2022-05-24 6:28 ` Ming Lei
2022-05-24 15:20 ` Keith Busch
2022-05-24 6:10 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165150766572.3972.14278571508374814557.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=czhong@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox