From: "NeilBrown" <neilb@suse.de>
To: "Miaohe Lin" <linmiaohe@huawei.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Christoph Hellwig" <hch@lst.de>,
linux-nfs@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] MM: handle THP in swap_*page_fs() - count_vm_events()
Date: Mon, 02 May 2022 14:57:46 +1000 [thread overview]
Message-ID: <165146746627.24404.2324091720943354711@noble.neil.brown.name> (raw)
We need to use count_swpout_vm_event() for sio_write_complete() and
sio_read_complete(), to get correct counting.
This patch should be squased into
MM: handle THP in swap_*page_fs()
Reported-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: NeilBrown <neilb@suse.de>
---
mm/page_io.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index d636a3531cad..3e2e9029ce50 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -280,8 +280,10 @@ static void sio_write_complete(struct kiocb *iocb, long ret)
set_page_dirty(page);
ClearPageReclaim(page);
}
- } else
- count_vm_events(PSWPOUT, sio->pages);
+ } else {
+ for (p = 0; p < sio->pages; p++)
+ count_swpout_vm_event(sio->bvec[p].bv_page);
+ }
for (p = 0; p < sio->pages; p++)
end_page_writeback(sio->bvec[p].bv_page);
@@ -390,9 +392,9 @@ static void sio_read_complete(struct kiocb *iocb, long ret)
struct page *page = sio->bvec[p].bv_page;
SetPageUptodate(page);
+ count_swpout_vm_event(page);
unlock_page(page);
}
- count_vm_events(PSWPIN, sio->pages);
} else {
for (p = 0; p < sio->pages; p++) {
struct page *page = sio->bvec[p].bv_page;
--
2.36.0
next reply other threads:[~2022-05-02 4:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 4:57 NeilBrown [this message]
2022-05-02 5:16 ` Matthew Wilcox
2022-05-02 5:28 ` NeilBrown
2022-05-02 5:31 ` Matthew Wilcox
2022-05-06 17:26 ` Yang Shi
2022-05-09 8:56 ` Miaohe Lin
2022-05-02 5:31 ` [PATCH v2] " NeilBrown
2022-05-09 8:54 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165146746627.24404.2324091720943354711@noble.neil.brown.name \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=geert+renesas@glider.be \
--cc=hch@lst.de \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox