From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBAD2C433F5 for ; Fri, 29 Apr 2022 02:05:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B3406B0071; Thu, 28 Apr 2022 22:05:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13C6B6B0073; Thu, 28 Apr 2022 22:05:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF6A16B0074; Thu, 28 Apr 2022 22:05:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id DA5C86B0071 for ; Thu, 28 Apr 2022 22:05:24 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id A87F812099E for ; Fri, 29 Apr 2022 02:05:24 +0000 (UTC) X-FDA: 79408274568.21.C8731F3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id 50DF1160057 for ; Fri, 29 Apr 2022 02:05:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C762B210E6; Fri, 29 Apr 2022 02:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1651197922; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQDXCYk6Wp2fThp27o+RRwGuMEj38RMRp7V9mIoaJbU=; b=aH0xMKbGX3tLDkIE+w0DSWZemlHZ9Ki3i6uleeG6ICQBueIO9bdIr3YKMKa9kn/yTmkHcu f7wNkMwm29wIPum703Iajuq7/r6zHPt3SKrYINfPlXbIoJjrBm49FbSbVhkvtoOdZs+9cM m8sZG4+MyIUgnqQVJSzoWc9T6rP7/Go= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1651197922; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQDXCYk6Wp2fThp27o+RRwGuMEj38RMRp7V9mIoaJbU=; b=EaIeOX9kGfmK/fCfk5FcomE94id4ubWbX/l+kI52NaQyHKGfx2YYbVWwnfCGjxEPZFdCca BQZK+xIJRQI0nPAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8635D13446; Fri, 29 Apr 2022 02:05:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rlZFEOBHa2JsYAAAMHmgww (envelope-from ); Fri, 29 Apr 2022 02:05:20 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Andrew Morton" Cc: "Geert Uytterhoeven" , "Christoph Hellwig" , "Miaohe Lin" , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] NFS: rename nfs_direct_IO and use as ->swap_rw In-reply-to: <20220428182353.d79ae288e1bb0cae5116d989@linux-foundation.org> References: <165119280115.15698.2629172320052218921.stgit@noble.brown>, <165119301493.15698.7491285551903597618.stgit@noble.brown>, <20220428182353.d79ae288e1bb0cae5116d989@linux-foundation.org> Date: Fri, 29 Apr 2022 12:05:16 +1000 Message-id: <165119791620.1648.7397114175780668923@noble.neil.brown.name> X-Stat-Signature: h17g1959yfinfots8iqcgabn88e7eiq8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 50DF1160057 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aH0xMKbG; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=EaIeOX9k; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf08.hostedemail.com: domain of neilb@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=neilb@suse.de X-HE-Tag: 1651197917-291210 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 29 Apr 2022, Andrew Morton wrote: > On Fri, 29 Apr 2022 10:43:34 +1000 NeilBrown wrote: > > > The nfs_direct_IO() exists to support SWAP IO, but hasn't worked for a > > while. We now need a ->swap_rw function which behaves slightly > > differently, returning zero for success rather than a byte count. > > > > So modify nfs_direct_IO accordingly, rename it, and use it as the > > ->swap_rw function. > > > > This one I insertion sorted into the series after > mm-introduce-swap_rw-and-use-it-for-reads-from-swp_fs_ops-swap-space.patch. > I can later fold this patch into that one of you think that's a better > presentation? > I'm happy for the patches to remain separate - though adjacent is good. If they were to be merged we'd need to fix up the commit message. At least delete: Future patches will restore swap-over-NFS functionality. Thanks, NeilBrown