linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "NeilBrown" <neilb@suse.de>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Christoph Hellwig" <hch@lst.de>,
	"Miaohe Lin" <linmiaohe@huawei.com>,
	linux-nfs@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] NFS: rename nfs_direct_IO and use as ->swap_rw
Date: Fri, 29 Apr 2022 12:05:16 +1000	[thread overview]
Message-ID: <165119791620.1648.7397114175780668923@noble.neil.brown.name> (raw)
In-Reply-To: <20220428182353.d79ae288e1bb0cae5116d989@linux-foundation.org>

On Fri, 29 Apr 2022, Andrew Morton wrote:
> On Fri, 29 Apr 2022 10:43:34 +1000 NeilBrown <neilb@suse.de> wrote:
> 
> > The nfs_direct_IO() exists to support SWAP IO, but hasn't worked for a
> > while.  We now need a ->swap_rw function which behaves slightly
> > differently, returning zero for success rather than a byte count.
> > 
> > So modify nfs_direct_IO accordingly, rename it, and use it as the
> > ->swap_rw function.
> > 
> 
> This one I insertion sorted into the series after
> mm-introduce-swap_rw-and-use-it-for-reads-from-swp_fs_ops-swap-space.patch.
> I can later fold this patch into that one of you think that's a better
> presentation?
> 

I'm happy for the patches to remain separate - though adjacent is good.
If they were to be merged we'd need to fix up the commit message.
At least delete:

   Future patches will restore swap-over-NFS functionality.

Thanks,
NeilBrown


      reply	other threads:[~2022-04-29  2:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29  0:43 [PATCH 0/2] Finalising swap-over-NFS patches NeilBrown
2022-04-29  0:43 ` [PATCH 1/2] MM: handle THP in swap_*page_fs() NeilBrown
2022-04-29  1:21   ` Andrew Morton
2022-04-29  1:57     ` NeilBrown
2022-04-29  8:13   ` Miaohe Lin
2022-04-29 19:04   ` Yang Shi
2022-05-02  4:23     ` NeilBrown
2022-05-02 17:48       ` Yang Shi
2022-05-04 23:41         ` NeilBrown
2022-05-06  2:56           ` ying.huang
2022-04-29  0:43 ` [PATCH 2/2] NFS: rename nfs_direct_IO and use as ->swap_rw NeilBrown
2022-04-29  1:23   ` Andrew Morton
2022-04-29  2:05     ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165119791620.1648.7397114175780668923@noble.neil.brown.name \
    --to=neilb@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=geert+renesas@glider.be \
    --cc=hch@lst.de \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox