From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22451C433F5 for ; Thu, 21 Apr 2022 09:47:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E5F56B0071; Thu, 21 Apr 2022 05:47:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 595FA6B0073; Thu, 21 Apr 2022 05:47:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 436B66B0074; Thu, 21 Apr 2022 05:47:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 346136B0071 for ; Thu, 21 Apr 2022 05:47:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F415426B5F for ; Thu, 21 Apr 2022 09:47:53 +0000 (UTC) X-FDA: 79380409668.17.6A6FDF9 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf24.hostedemail.com (Postfix) with ESMTP id F024018002F for ; Thu, 21 Apr 2022 09:47:51 +0000 (UTC) Received: by mail-pf1-f175.google.com with SMTP id i24so4521187pfa.7 for ; Thu, 21 Apr 2022 02:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=lyWO8pI/iZL3pBCIc8iGOQ7+JToyR5F2j32rII4xAew=; b=c0gv7Cnxk0OHBkuP2DwEJeHnHhMtv7rbNbQXxDkgpxcDcsqHJpeP6cnivE4wL82xVn HRVrWF+J98+ATJf3b6C9CFtxsbBThsPTi0gMkBoaVMfMMqQvNFGHBTCJrbJbrUtiOGrQ WFU1ey9FhcQ4iLkh/b/KNXtEEEPYhbIWmuHengFh49Rz+RMvO/qe929Kw1S3DUoG/UGm BfUXn3i7FxU6wJXTPH2NKEU8b7ngLILY52TFemea2Q/7/UgaBDjdli1u99pKVXpnKpna pbvOsnPcL9/R57sW4YO8RI52ip7+1Pk3GyQwf+s+1MS5QPG37dqI6YkVlVAV0+xY5fSE ueQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=lyWO8pI/iZL3pBCIc8iGOQ7+JToyR5F2j32rII4xAew=; b=e9QWmbFOsPC74NwoJfzJmlrf5hk7ahwqtME0VdySdKjikDMTqQFqDxE7TJ7E5rGp+Q I0dZa/0YJloTxzr/uKNznTLm1il1EcUz1AuKS4mH7foFAK2sZ+evb0TL2VOyFjIr612D foD0AJawFz4LdN/WLuQjKq6EVWOT/uPElVXWByEaYhKl5KrxutID3NkQhSMdtXSmjJ8w t8WmuVSJkaylR0iXhoGZedVX0xgvGIcFcKPooyPHXMvV9oLrjdDz6JYkJapxVJiSJvWn /YVZNsYYwGrZKUalGEHt0dz9JFuqI8l7JR6GowqsnTHTxB80qb1Uk+3V8JBw4UFa13jK jnHQ== X-Gm-Message-State: AOAM532fDg+b5eWRtjXU7EC5nAO1fuRSE3yaJ1H3XimVJwa05m5IbSpu cgPVKTKW9oKbfx9zH/8WcYo= X-Google-Smtp-Source: ABdhPJwqQVk0NLfWe71VgxEX8jGq+J8cb/1K6tUorOoMgwYIFLGuD4VSp0pC02lD9Oy9JEg9hTb9yA== X-Received: by 2002:a05:6a00:2444:b0:4fd:db81:cbdd with SMTP id d4-20020a056a00244400b004fddb81cbddmr27840130pfj.32.1650534472608; Thu, 21 Apr 2022 02:47:52 -0700 (PDT) Received: from localhost (193-116-116-20.tpgi.com.au. [193.116.116.20]) by smtp.gmail.com with ESMTPSA id t18-20020a17090ae51200b001cd4989fec6sm2044542pjy.18.2022.04.21.02.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 02:47:52 -0700 (PDT) Date: Thu, 21 Apr 2022 19:47:47 +1000 From: Nicholas Piggin Subject: Re: [PATCH v4 bpf 0/4] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP To: Linus Torvalds Cc: "akpm@linux-foundation.org" , "ast@kernel.org" , "bp@alien8.de" , "bpf@vger.kernel.org" , "daniel@iogearbox.net" , "dborkman@redhat.com" , "edumazet@google.com" , "hch@infradead.org" , "hpa@zytor.com" , "imbrenda@linux.ibm.com" , Kernel Team , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "mbenes@suse.cz" , "mcgrof@kernel.org" , "pmladek@suse.com" , "Edgecombe, Rick P" , Mike Rapoport , "song@kernel.org" , Song Liu References: <20220415164413.2727220-1-song@kernel.org> <4AD023F9-FBCE-4C7C-A049-9292491408AA@fb.com> <88eafc9220d134d72db9eb381114432e71903022.camel@intel.com> <1650511496.iys9nxdueb.astroid@bobo.none> In-Reply-To: MIME-Version: 1.0 Message-Id: <1650533246.j8team32e9.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F024018002F X-Stat-Signature: 8yuesdnspp917uj87nwtqkq4rps13r8r Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=c0gv7Cnx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of npiggin@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=npiggin@gmail.com X-HE-Tag: 1650534471-521128 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Linus Torvalds's message of April 21, 2022 3:48 pm: > On Wed, Apr 20, 2022 at 8:25 PM Nicholas Piggin wrote= : >> >> Why not just revert fac54e2bfb5b ? >=20 > That would be stupid, with no sane way forward. Oh I missed this comment. Now I'm completely confused. Reverting the patch which caused the breakage *is* the sane way forward. Your tree is not broken after that so you're done. And if x86 wanted to select HUGE_VMALLOC in future then it can do so after fixing the issues it has with it, so that's that the sane way forward for that. What you have now is what's insane. HAVE_ARCH_HUGE_VMALLOC now means "you can ask for huge pages but it might crash in undocumented=20 arch-specific circumstances so good luck". Thanks, Nick