From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A2FC433F5 for ; Thu, 21 Apr 2022 00:06:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EC446B0071; Wed, 20 Apr 2022 20:06:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69AC36B0073; Wed, 20 Apr 2022 20:06:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5650F6B0074; Wed, 20 Apr 2022 20:06:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 473C86B0071 for ; Wed, 20 Apr 2022 20:06:44 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1841725F58 for ; Thu, 21 Apr 2022 00:06:44 +0000 (UTC) X-FDA: 79378945128.13.98DE93B Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf09.hostedemail.com (Postfix) with ESMTP id 6916614001F for ; Thu, 21 Apr 2022 00:06:42 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id n33-20020a17090a5aa400b001d28f5ee3f9so3560405pji.4 for ; Wed, 20 Apr 2022 17:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gtZMfNzGeYhMURXLY1XiggmvzmJ7zBGBwSixzSCqueo=; b=eBgz4Jdj3KpVL+L3DcDIANI9sXH884X7GMcuZDA3daEecFWtjgBYouZek6J44gsx+L JmUKgRpTPAV6vqC+BoeegczlKhnGF7v6OxI0Cy6QNJk0m4GuTizslzCIWzTcoZ/FMPqd QgpxrMCY8OCJxCNXDrbMqD2dSJMnxvYGTiUyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gtZMfNzGeYhMURXLY1XiggmvzmJ7zBGBwSixzSCqueo=; b=PAhnthGdnKK1MUxKgdeH4GekSqMvtx7t2zGIEaAZPIwiDRcRTz1dRqVvIHrcfdE5RQ TUA2lgWZMIBMeq3NyyCbXXcInqRyD02+tHoRimDD3nrv+EM4uqevlywMWwyHPi5ghIMQ /Tq6htmZdzuRCJ1NVIIFgmxnqs6tdHD0lY+W+eBi5I/uQ4vOtHAsIxXa3GK7tCuSp/DR sB/IyQSYMHZxaPJR4i/q6puJIbNnZfCecoZtexcOsQY9SAaDUVsZUXPB2dwnC1PqS5/i ylAiF9innob49wx3hu+KqRSlqxS5NcWYkLrdqpvM7lsqeqcjXaBh07jaej7yY+K7/YkR vfsA== X-Gm-Message-State: AOAM530/ysz9mgMLu0tI7cUCwleidfJ2nI38PDWi92iiCh+DQ8uThOfJ z2k6TBE8tzGARTast0llxdmbjA== X-Google-Smtp-Source: ABdhPJwUZ02o3o5MBT8n6MGMrt+xN1PWAFYVkoIs5DF8SnTYZwrpdZebjT8ZyRj80drR/SDxakHSUA== X-Received: by 2002:a17:902:ba8e:b0:151:ed65:fda4 with SMTP id k14-20020a170902ba8e00b00151ed65fda4mr23129589pls.127.1650499602483; Wed, 20 Apr 2022 17:06:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f19-20020a17090a639300b001cd4989febasm320094pjj.6.2022.04.20.17.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 17:06:42 -0700 (PDT) From: Kees Cook To: ebiederm@xmission.com Cc: Kees Cook , linux-arm-kernel@lists.infradead.org, dalias@libc.org, aou@eecs.berkeley.edu, gerg@linux-m68k.org, geert@linux-m68k.org, vapier@gentoo.org, palmer@dabbelt.com, damien.lemoal@opensource.wdc.com, linux-m68k@lists.linux-m68k.org, linux-riscv@lists.infradead.org, Al Viro , stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, paul.walmsley@sifive.com, ysato@users.sourceforge.jp, Niklas.Cassel@wdc.com, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org Subject: Re: (subset) [PATCH] binfmt_flat: Remove shared library support Date: Wed, 20 Apr 2022 17:05:47 -0700 Message-Id: <165049954506.2420506.9909431091128831748.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> References: <20220414091018.896737-1-niklas.cassel@wdc.com> <81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org> <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Stat-Signature: 5uphd4kjpcf78bixqr5mdhyyr7cjgwnx X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=eBgz4Jdj; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.52 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6916614001F X-HE-Tag: 1650499602-580096 X-Bogosity: Ham, tests=bogofilter, spamicity=0.012774, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 20 Apr 2022 09:58:03 -0500, Eric W. Biederman wrote: > In a recent discussion[1] it was reported that the binfmt_flat library > support was only ever used on m68k and even on m68k has not been used > in a very long time. > > The structure of binfmt_flat is different from all of the other binfmt > implementations becasue of this shared library support and it made > life and code review more effort when I refactored the code in fs/exec.c. > > [...] It seems like there is agreement that the shared library support is unused, so let's test that assumption. :) With typos fixed up, applied to for-next/execve, thanks! [1/1] binfmt_flat: Remove shared library support https://git.kernel.org/kees/c/c85b5d88951b -- Kees Cook