From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F1AC433F5 for ; Sat, 16 Apr 2022 04:25:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DFEE6B0073; Sat, 16 Apr 2022 00:25:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B88E6B0074; Sat, 16 Apr 2022 00:25:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 057E96B0075; Sat, 16 Apr 2022 00:25:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id EA7F96B0073 for ; Sat, 16 Apr 2022 00:25:55 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id B0BF7613B6 for ; Sat, 16 Apr 2022 04:25:55 +0000 (UTC) X-FDA: 79361454270.16.3765F2D Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf09.hostedemail.com (Postfix) with ESMTP id 276AB140004 for ; Sat, 16 Apr 2022 04:25:54 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id mm4-20020a17090b358400b001cb93d8b137so13156144pjb.2 for ; Fri, 15 Apr 2022 21:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fwjZWUK23SDc9f6Fzho9lbrW12rtjQaU86s3X7g7WA8=; b=F34psi04KzHnYMusfXO0+Sf3dJ+pbADOBfrHzkAjvESdbhKsZSm2ygbl4eJ8nzig2M 6I4LRslXFzO0BGeOnKyUp9HRJeF5QPCuHXGQNSY4rw5MVk8II4OdX1w478l05XQxHCaj ltrcULTumO2g2mcppqt0GiQ9OCt++92abzFh4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fwjZWUK23SDc9f6Fzho9lbrW12rtjQaU86s3X7g7WA8=; b=Pksvnlp9pSYu2UDRlI2tHtTw3kUK6NKbg9LAhlf3AWHLgUifWJh6fGZXzpD99ZDpMs Yn8xe4eYCVifpdA7rzBbVPbFAjwnwItTDaVrEnQJ7I5nw4aksWY1uoYiN2CJywDIgika 8scA1PCR8AxE9aFWKbGeRpw4/yrkDnqhM4yVr0WyjByOjp6dx8FTECVA76t8ypCFB3Br 5NZa4z2LC53GC15D+xhU7e5JsHwTlTgwcJpUNrIjfxK3aV938skRLQGMw+e/tVvr2H4z etMvLGZwOmwVuS+nOiiDMm9lEIZxrCTqhtDHStjVWKY2jLdeW3KPDF4mXx20bLrknJhA 56Aw== X-Gm-Message-State: AOAM532lOjv26Uin03S4gSEOHZSHcjyCsWaGysfY1rUBjlgSgz/cA2qc Pmwtv4TRjaAX9M2eQYE/Hng/bA== X-Google-Smtp-Source: ABdhPJzuch/i5PtXeUfpilPZbG0Ojdf8xS0zPST9o6TFZXb4i9S7hdqyz7HtmT5xcBIsyArbi7vBqw== X-Received: by 2002:a17:90b:4f91:b0:1cd:3a73:3a5d with SMTP id qe17-20020a17090b4f9100b001cd3a733a5dmr2216377pjb.98.1650083153061; Fri, 15 Apr 2022 21:25:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h5-20020a17090a648500b001cd5137217fsm6115627pjj.47.2022.04.15.21.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 21:25:52 -0700 (PDT) From: Kees Cook To: palmer@dabbelt.com, Al Viro , ebiederm@xmission.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, niklas.cassel@wdc.com Cc: Kees Cook , linux-fsdevel@vger.kernel.org, vapier@gentoo.org, gerg@linux-m68k.org, linux-mm@kvack.org, stable@vger.kernel.org, damien.lemoal@opensource.wdc.com, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv Date: Fri, 15 Apr 2022 21:25:07 -0700 Message-Id: <165008310452.2715005.9013061971753495821.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220414091018.896737-1-niklas.cassel@wdc.com> References: <20220414091018.896737-1-niklas.cassel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=F34psi04; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 276AB140004 X-Stat-Signature: joif7sjsqjoxx8pmfymjkzcaikogy1xo X-HE-Tag: 1650083154-165148 X-Bogosity: Ham, tests=bogofilter, spamicity=0.007465, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 14 Apr 2022 11:10:18 +0200, Niklas Cassel wrote: > bFLT binaries are usually created using elf2flt. > > The linker script used by elf2flt has defined the .data section like the > following for the last 19 years: > > .data : { > _sdata = . ; > __data_start = . ; > data_start = . ; > *(.got.plt) > *(.got) > FILL(0) ; > . = ALIGN(0x20) ; > LONG(-1) > . = ALIGN(0x20) ; > ... > } > > [...] Applied to for-next/execve, thanks! [1/1] binfmt_flat: do not stop relocating GOT entries prematurely on riscv https://git.kernel.org/kees/c/a767e6fd68d2 -- Kees Cook