From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FC59C433F5 for ; Wed, 6 Apr 2022 12:06:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E37D6B0072; Wed, 6 Apr 2022 08:05:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76C726B0073; Wed, 6 Apr 2022 08:05:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60D4B6B0074; Wed, 6 Apr 2022 08:05:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 4DD536B0072 for ; Wed, 6 Apr 2022 08:05:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F09242453E for ; Wed, 6 Apr 2022 12:05:38 +0000 (UTC) X-FDA: 79326324756.03.5CBB8F0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 421911C0021 for ; Wed, 6 Apr 2022 12:05:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 9F0FECE22EB; Wed, 6 Apr 2022 12:05:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D078C385A3; Wed, 6 Apr 2022 12:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649246733; bh=rDQvaygpthRKRnsZXsnfNGtisUPV3/sff5jhgVezLbM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lYe2kM1CRvfa5Nortbkz5PizCF/NIMl+nfKquFCdMCIjPwqcVY8LR0l/etnfU2ttV t1KjoWYMoaFg9mlQMdMtUVEKMN3Zmt77t4Bin0L0PejIKDb9I5z9f02sbm7mykoOmO Vkz6jWlFlAGFwlWm8RCBk4vTsN1bq5Y9jllYzG9s4Yalsgb9K7rXvYL7B/3z/L7khB 5MBln9Yi783wqaK5PYRTrwNkIOnrKx+jrOYK9BXs2ptlT5KxW5/iBrk+8yeX5Dc4o1 nKhYWnohZgeU/yqFdgt+Z8nOus1RRyeRAWMhnnkaqJL1yOYw5Dc/GNeGqzCKe6d70a Z2aYbBL9RzhPw== From: Will Deacon To: linux-mm@kvack.org, Steve Capper Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Anshuman Khandual , David Hildenbrand , Peter Zijlstra Subject: Re: [PATCH v2] tlb: hugetlb: Add more sizes to tlb_remove_huge_tlb_entry Date: Wed, 6 Apr 2022 13:05:26 +0100 Message-Id: <164924530906.2850486.16239024731673637557.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220330112543.863-1-steve.capper@arm.com> References: <8d5f53c2-2e67-66e4-6453-946a62d5ee98@arm.com> <20220330112543.863-1-steve.capper@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Stat-Signature: 161gootrdbhztzbfcjq3kuzwr5xzr6fd Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lYe2kM1C; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of will@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=will@kernel.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 421911C0021 X-HE-Tag: 1649246738-460774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 30 Mar 2022 12:25:43 +0100, Steve Capper wrote: > tlb_remove_huge_tlb_entry only considers PMD_SIZE and PUD_SIZE when > updating the mmu_gather structure. > > Unfortunately on arm64 there are two additional huge page sizes that > need to be covered: CONT_PTE_SIZE and CONT_PMD_SIZE. Where an end-user > attempts to employ contiguous huge pages, a VM_BUG_ON can be experienced > due to the fact that the tlb structure hasn't been correctly updated by > the relevant tlb_flush_p.._range() call from tlb_remove_huge_tlb_entry. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] tlb: hugetlb: Add more sizes to tlb_remove_huge_tlb_entry https://git.kernel.org/arm64/c/697a1d44af8b Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev