From: Will Deacon <will@kernel.org>
To: linux-mm@kvack.org, Steve Capper <steve.capper@arm.com>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
David Hildenbrand <david@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] tlb: hugetlb: Add more sizes to tlb_remove_huge_tlb_entry
Date: Wed, 6 Apr 2022 13:05:26 +0100 [thread overview]
Message-ID: <164924530906.2850486.16239024731673637557.b4-ty@kernel.org> (raw)
In-Reply-To: <20220330112543.863-1-steve.capper@arm.com>
On Wed, 30 Mar 2022 12:25:43 +0100, Steve Capper wrote:
> tlb_remove_huge_tlb_entry only considers PMD_SIZE and PUD_SIZE when
> updating the mmu_gather structure.
>
> Unfortunately on arm64 there are two additional huge page sizes that
> need to be covered: CONT_PTE_SIZE and CONT_PMD_SIZE. Where an end-user
> attempts to employ contiguous huge pages, a VM_BUG_ON can be experienced
> due to the fact that the tlb structure hasn't been correctly updated by
> the relevant tlb_flush_p.._range() call from tlb_remove_huge_tlb_entry.
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/1] tlb: hugetlb: Add more sizes to tlb_remove_huge_tlb_entry
https://git.kernel.org/arm64/c/697a1d44af8b
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2022-04-06 12:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 16:52 [PATCH] tlb: hugetlb: Add arm64 contiguous hint awareness Steve Capper
2022-03-23 18:30 ` Catalin Marinas
2022-03-24 14:33 ` Peter Zijlstra
2022-03-24 14:35 ` Steve Capper
2022-03-24 15:58 ` Peter Zijlstra
2022-03-24 16:11 ` Steve Capper
2022-03-30 11:25 ` [PATCH v2] tlb: hugetlb: Add more sizes to tlb_remove_huge_tlb_entry Steve Capper
2022-03-30 12:05 ` David Hildenbrand
2022-03-30 14:04 ` Anshuman Khandual
2022-04-06 11:21 ` Peter Zijlstra
2022-04-04 6:07 ` Anshuman Khandual
2022-04-05 14:26 ` Catalin Marinas
2022-04-06 11:40 ` Peter Zijlstra
2022-04-06 12:05 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164924530906.2850486.16239024731673637557.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=steve.capper@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox