From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D202C5AD49 for ; Fri, 6 Jun 2025 11:51:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18D1A6B0089; Fri, 6 Jun 2025 07:51:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 165FC6B0093; Fri, 6 Jun 2025 07:51:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02D1C6B0095; Fri, 6 Jun 2025 07:51:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D77CC6B0089 for ; Fri, 6 Jun 2025 07:51:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7FF33102156 for ; Fri, 6 Jun 2025 11:51:03 +0000 (UTC) X-FDA: 83524809606.03.0B50687 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 1461B14000C for ; Fri, 6 Jun 2025 11:51:00 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OTWSmP3o; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749210661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pYJGRqckhRe+BwZpb5JLIznIuBTO3J/tHjbtBqCbLRk=; b=MjHmnNJY4wevNwYGtgcrJUqpMcMhNQk2HzJLirC07k2nWr3WjcspqLQ9QsBw1TG3aSFucu jFsp4k/XVZnT8Z4Jd1J2vT2MDEwp5c1hevdhQrIzDw6aME3cSHKiOP8xsF0nPbjsxUQBEe Hk3ccAWPO6U84e4ETzTa31iO5Gq7IhI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OTWSmP3o; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749210661; a=rsa-sha256; cv=none; b=JkD68NdGXm2MSaN2U0fFpFjMMiWnqJfUYhp2xWf2B2rjVFzJVVUXyxCKYk1ynv8+Sn+t1H kB3l6EIMfvmO5JGpi6KfOBEOItbRKqOgXXoH75XwAbRBjgdK3zSrkfqarAolTx0cSvI1eV q50TN3AIzAtfHishnYi96CKPF6hGrb8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749210660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pYJGRqckhRe+BwZpb5JLIznIuBTO3J/tHjbtBqCbLRk=; b=OTWSmP3oYDmDiW2yOG8+1dxdd5aqzluj2XugqNJZVCkQQiyB761oK1xAKJs90rzkVKqx5G 0oYIa7IGNTrNDQDvtfDp08pvfAGkOVdK/4BqEjmm9LWkPX8TRHMRiK5AqG+UBnMoQ2Qg0b lIJBTAt42QZqDzQRTb+xsXdWyodOZrE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-OH3C-oABN9K1CL0eh-pI3g-1; Fri, 06 Jun 2025 07:50:59 -0400 X-MC-Unique: OH3C-oABN9K1CL0eh-pI3g-1 X-Mimecast-MFC-AGG-ID: OH3C-oABN9K1CL0eh-pI3g_1749210658 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4eec544c6so1040246f8f.0 for ; Fri, 06 Jun 2025 04:50:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749210658; x=1749815458; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pYJGRqckhRe+BwZpb5JLIznIuBTO3J/tHjbtBqCbLRk=; b=lYNJrCVvl+RFXi0W/7eM+jlzPouuCeh53TBdf3VqDGdgZIPv9H08vGXK31L++nkVpH ssPUB8vSa+xar8jscenXz08w6NgxQIMLeeFWTV+1OG6JjZAe4Pth6nZFst8XlBEUtzks zrW2kxgW6p6/Gw5v1KiFblUJzffdum4kAieUTrgUM/SwHz6HDO0SItaUxGjGiNPuGlBI T3bWhgJgeaKHxXx6hQgwpwQjUNqsLxvhlkFMDMjwXPQYKjEYDMqEyr5NCjADMusZofSk hcXvHrgKtDzeWi/84e3r6ymVOprBusEvr3UGMZyJDVEaiCiZ79PpItlVodn5sLbPhruh /E9Q== X-Forwarded-Encrypted: i=1; AJvYcCUMD2H2mNjOvRZHCc2qo7U+HE/Qu/U1s/n9R014hsywiydAgUjvFR48yToy8s90BYpdFcXs4nXvZw==@kvack.org X-Gm-Message-State: AOJu0YxURuitJC84SwBZ4BZ58uhpxUGFOdmwjzrCXZXz37SQwoi1oJT0 xbIc0uo0lPTu6MM/BiNKXa21RAd2AOpKhXlJ/RrJ/3pNIKsEz0UebtuSPHhtlxSeyCSutaAG/If YbEyuyNXdzBaZ+dm8iSlrXMvRHGQVkEF0DAJRo3i1DiNLy3ljnol3 X-Gm-Gg: ASbGnctgMxnExhREdlAdc3kaYU729LcYepg/eUAt8gOQTh21uRetsLGtPHIdZk1CHJB P6J2VU8q7MmPsN64/VEIBKqkZiMbJhv0J6uChgZDVwvNw1ToFtVFJ2Mb7lgq0okcVJIZwCuR+4P iB5vOKNFz+RjWXFibqVHv/XEXt/VpjmMl7BL2UA+gtK9nx7Yk3dmy3Uee1HSgsrf95oFpo/2rUT MvrK5juLGZX18AIF9g0y+Ny7lw8Jcj6WwvP2330ESsVu5xSYEsLtqVnlbMM/Awaf39jNbyHTwKj 68tusZd/dVGP84z1NG7j85mFU0Z/BgltMkazRtFeCNbOr1lxhAX+W3ShxMxmVIuJ7P4VrqXZR/f HJxD8nR5xKsWKG6CeMziaqIZKXgdVQMosJSQzJg9llw== X-Received: by 2002:a05:6000:40ca:b0:3a4:dbdf:7154 with SMTP id ffacd0b85a97d-3a531cf497cmr2521462f8f.54.1749210657960; Fri, 06 Jun 2025 04:50:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxlRZuyjqfxkJT9RqmeW3tRY0Za5IaocilDs8flVHqJyxHY7fHsk9RsbeeS7gy+19xAXOSBw== X-Received: by 2002:a05:6000:40ca:b0:3a4:dbdf:7154 with SMTP id ffacd0b85a97d-3a531cf497cmr2521437f8f.54.1749210657548; Fri, 06 Jun 2025 04:50:57 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229df09sm1665363f8f.6.2025.06.06.04.50.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 04:50:57 -0700 (PDT) Message-ID: <16459fe6-e449-4fa6-8e63-1ed71cce627b@redhat.com> Date: Fri, 6 Jun 2025 13:50:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/10] mm,memory-tiers: Use node-notifier instead of memory-notifier To: Oscar Salvador , Andrew Morton Cc: Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-6-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605142305.244465-6-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qpGv3ZZ_c7fkKSi95Va-aKHfstI4s5GUglDo3yAyVV8_1749210658 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1461B14000C X-Stat-Signature: 1mn16hjypycy61pqjhpodsxzaqfs7rh6 X-Rspam-User: X-HE-Tag: 1749210660-359552 X-HE-Meta: U2FsdGVkX19eyPQoV9qnhiWp+44ynU1rtjqKKat2ay4U07P/VuJBnYt3VDYWXWzebAm4TkVuftWIRbKMlXSbQY67z/VPLtu0th77WdkR0AfFEsyn5aNuXEe/Z5Gxd++DQ78ETsrNDpaEVkvw53IY1GWIU31uES1i6L3kRfhmkFFccWmwBcS5CtTxsJwMbD2dkmZlvwi0nqA8wu2q9llrWdhoGzrXvc0i7T8xRvL5cNEFj2kpKUnNwHGaZg5pTLTQypHdUn4qkHct8wIeYtNYpFRM2ccLsMxeYa6ER04GSX0lAzUm+XnkNLrRlb1iK7w8FLnFF8XtGVURvwvdW0kHa2HyBs+aoM64Q29876Y+yiL4Z5VGGC7qqNZ+chkACNrJQia+jiQefqGVVr+GgIUTEbXBewtrR5+5mzPJcRLlWxpjSqKMFYvIZ70T411F29VfqJWjlsrKtJuU/5fOQM1ScifFjccsOgJXifQ5ZJA7dZaolJQ1WUqwxgh1CFXLT3NVjGCPf9gB2xQHG9gOcbpYOhBaeYUeHIQNk+3ruR4Itt5Lr0Lr+gq4dglfkG3qcpupFlNmMWroyQAEx/DTGUdlT9hRs+nc8acs0flH+g3yA0oGYC6PdNaibs23VtDR3oqDv7Ukgjnzt6e959pl9PpHCIahpj5jPmKJZXAlKOTEK6w5LUhc9f8g9KTgE2b+8cseaE1/JcalBEW/H6OEbMQ38zn496nvd/XtDKxUxO9Ix6NmsNaV/KR59WGWUT2Ycld0mCl/7LZxnz0xzMF8g7j0QyVu9Q91Oy2A9pQcXR9LxNSAIzdxI3SdCokKV/QpMMQq9qyohE3fnpvwektpJNamgCVUEEUYqbjQp5fuS+Nvaka76sUypYhaMhDzsafcjfldQvJ3WiqIHSoiL7BQPIHdVWSjHsOTMqdnEtfZKq2gVPgLxnS1BOlifeiXCACiIF6BgjVrrVQJ/EMwP+KIraG 2G/VqyU7 JAk6yeiANZp/2ZaIDOYeWW2OlVxcHVpfsuDZ4ARRjbM8rXfc8jSbPP03ZjFWJBIcrmcqKVxawOsXBr4rjw8WLgxkspKIn6GmIu1ge3tpHPgFOpAfRMLMNUkwh+f1kYDQRIFsn4jnVg8aa27Gnd3YIr1cqP7FDBWirGKLasDQ4BKX25VjLMup76HN9g9Jtug0OTwHnoMQ6vqjNncAWYSx8L1TqFqIETeru5OGRPpTlfbhJncgVnZLRQkypeFGwLvKGuigbho8MO3YAQa5j2tsIdf0DNZ2COeAmyoqYr659Xc/EHwmLPvLYiElgEloeE+ZGXAz/wxcQ6Lm6n2DATkrRdZ4x5d3jGCR7AX/TGABuDmATgUeXx4h0kW2TpzDPN33lyu/q+X+0l52bcbo/Q2z8S7dzyVfT8oQRP4ytncnq5s6R7puK2G8AWs0Uic70GvCWQEZPZqZhG0aJ1xaeo+LHrNaAbyKwZsNMXBVpwsISidnfm2IkzSu5NPnRYELHP1B2F/OEunYw3yP7kfo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 16:22, Oscar Salvador wrote: > memory-tier is only concerned when a numa node changes its memory state, > because it then needs to re-create the demotion list. > So stop using the memory notifier and use the new numa node notifer > instead. > > Signed-off-by: Oscar Salvador > Reviewed-by: Jonathan Cameron > Reviewed-by: Harry Yoo > Reviewed-by: Vlastimil Babka > --- > mm/memory-tiers.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index fc14fe53e9b7..67f06e6264a1 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -872,25 +872,25 @@ static int __meminit memtier_hotplug_callback(struct notifier_block *self, > unsigned long action, void *_arg) > { > struct memory_tier *memtier; > - struct memory_notify *arg = _arg; > + struct node_notify *narg = _arg; > > /* > * Only update the node migration order when a node is > * changing status, like online->offline. > */ > - if (arg->status_change_nid < 0) > + if (narg->nid < 0) > return notifier_from_errno(0); Ehm, why are we ever calling a node notifier with nid < 0 ? We shouldn't do that. Can be adding first / removing last from something that ... is not a valid node? :) Maybe it's already do that way, in that case just drop this check here. -- Cheers, David / dhildenb