From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E2AAC2BD09 for ; Mon, 1 Jul 2024 19:47:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC4006B00BB; Mon, 1 Jul 2024 15:47:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A73FF6B00BC; Mon, 1 Jul 2024 15:47:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93BB56B00BD; Mon, 1 Jul 2024 15:47:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 70E846B00BB for ; Mon, 1 Jul 2024 15:47:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1948F1A1B26 for ; Mon, 1 Jul 2024 19:47:48 +0000 (UTC) X-FDA: 82292219016.28.923AAAF Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by imf07.hostedemail.com (Postfix) with ESMTP id 3F4E74000B for ; Mon, 1 Jul 2024 19:47:45 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=YxDOMQ6n; spf=pass (imf07.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.161.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719863243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rhNMYB1zr8j/8x5hEiifpg+dWIlJrOqqqN/Lc/vPbUc=; b=r1++DzvLzBH64M7HEX4Yg82gQEL2EFHrdCx/o+czebBOAYvfQfTlXp+9bFpE6t2t5Cic6R ZecpSaagVl2ZTrlqZUJHGRl2quraRezIGt9pbpzIzR+VeozdfUjqD2Dg22yhLdhysTR4gN wIwpPRu+N6aAl0KI8ArJlcmHmi/U8bs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719863243; a=rsa-sha256; cv=none; b=fv+oZ+vv5rtQkdw6zERsQu6b8Zd0mpmSv0D4Gfu6gMRwygQ4kgA+f0zy99Ul7wCZwTnB06 VULefKaNojBEPOQ11o2hXa9FrzstahxAPKMqeXG8geh/o5iZ3qDoxg9is89IrtJPKSuusK epP+9jgSDdaEujB2ndU2opD0Rh3UBeQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=YxDOMQ6n; spf=pass (imf07.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.161.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5c20995d038so1361700eaf.3 for ; Mon, 01 Jul 2024 12:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719863264; x=1720468064; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rhNMYB1zr8j/8x5hEiifpg+dWIlJrOqqqN/Lc/vPbUc=; b=YxDOMQ6nQDDfRRPrNu6GuvHPx+vyQcZFKK10tX7hCDgRa2r98c8TnwQC/tYFNzLRoq tDTk1TJErthhYMOBxc7wryYDBNRaZhiNGIkuZA5cONU7TT1JPCW2NC9sEcp8UQS9aRWV 49Zt4oWXMR8wPIrWeT8ek+ml5Xz1w4SO91REhSzNX6narXRYDzQ6z1FdN4teRIdqbEmr jfdCnLCm2LV8JbRcNghzJOkIdWq68RcWR5g0ulw6hp7d+em8QYgbpDkxlNxiHG62YqGw tAkNiQSP8QOZa+HivKy5cKBBwE5Flqz/KywB6UfMsh05kCzoD7CQlsWrwXvGAtjcofhm CdIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719863264; x=1720468064; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rhNMYB1zr8j/8x5hEiifpg+dWIlJrOqqqN/Lc/vPbUc=; b=abm3lVnzh0hFY4hO6STDNP9BVNqIDUc3SZ5r4Z9AgNV2XWA7zDjCJ0jyhaLvtms/vG Y8uAbGmA+x/bJcIjlFZbJwe33hVYfd+xiFUjXQEpDuwaNICfIx53Ah6icwVKBi+HjPiE gszGDpyJ+mdQUoB4JpV90593Hec9XmzgFu114ygxGeoo6hh1i070hMlq0bhRvojbAbjj 2Dk/Dkn9F9W84kyOXJxnLyCNc2/lDEHHgjOBtmMvolzbCskoJPU34hVavqqfu4QeLkaZ Emb6G9JXigU9SiQgfU2QH7U3va24ho6A3uDPWrKa9YM9dB76HRpGOyukcAp85MFbBWxo wWKw== X-Forwarded-Encrypted: i=1; AJvYcCVZaWJHaG3QVkTjekLwaGb94hT4sH/ulMi0hnHem2blZbGAjjq58FyGgF7e0kvhnrzbygFKaJxgL3iG4QFHJuoyJK4= X-Gm-Message-State: AOJu0YwDiK11UuY0ElxOgOMoZxUS15kzHMqnXOrNSYkWCm4Wv7bbMYc2 yfwa8ej+ha7n3O2z9N94s9MUWVvYsHwf+54LywbwgPH6DTqRAXPz8wXvV9UJBQ5vlYO7XGNKmzH c X-Google-Smtp-Source: AGHT+IGO7kpLe7/HTqtMj/Gvt0KY7xnl2MLDe5NUbJ/uY1ig3sf97Etjvvc0/nZYLeVQRxcz8FlCPA== X-Received: by 2002:a4a:5892:0:b0:5c3:c6e7:6daa with SMTP id 006d021491bc7-5c438e0f1b3mr5949530eaf.1.1719863264067; Mon, 01 Jul 2024 12:47:44 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:e8c6:2364:637f:c70e]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5c42fa82f86sm781446eaf.31.2024.07.01.12.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 12:47:43 -0700 (PDT) Date: Mon, 1 Jul 2024 21:47:41 +0200 From: Dan Carpenter To: Vishal Moola Cc: oe-kbuild@lists.linux.dev, Aristeu Rozanski , lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: Re: [linux-next:master 7944/8232] mm/hugetlb.c:2677 gather_surplus_pages() error: uninitialized symbol 'folio'. Message-ID: <16438a9b-ef57-459d-a79e-8bdd7c80cbc1@suswa.mountain> References: <6d5e5b32-246e-4c56-84d7-f7c4f0a6212f@suswa.mountain> <668300a6.170a0220.cdc45.7372@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <668300a6.170a0220.cdc45.7372@mx.google.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3F4E74000B X-Stat-Signature: ofanuoohjn3fcb4g7rcpiu7sc87bc6qs X-HE-Tag: 1719863265-189914 X-HE-Meta: U2FsdGVkX19kQ+lnreR8eYcrWVVw5ndI3143hDjxDgB1gpXm6KIn4d+y6+ARakShIIVYjJ0Oa9l2r8BDbcG+ZyM8EB7UQWdQkcuj84ahW2es0dTJxgyWuqZF3jXD42sbzSWnfhIHmOCSi3x7qXDIPLEpAa32djZM2ARSLaaaUtgsb3l78D7/iZo4fz4kOvlmg4bTsnaUmdjtefTJRh3ZapTWMDGikAgBNtUwSLc5eSwKHdaDUQFplXuv2TcVnXPeU49zYCKBm5zSoJa3dd0+QZMfgCvNZ+vwHeIQaB8tqa7ebKU6xKGoZz0SMZ01cb7Jzh/okzwgUtFU5jU12Q8BmsyduO65v3jz41CbSD8tGzEGESAQw/nA3gxa2YdoC67jrjVZ/z3cs6CGWJpjA8gsA+8iq6zEhUI2xK5/qqPVUn/vBz06GINKHq9mHdecNh6Qqd0/C2Yug+pbImWjhAmfW4YgvDdmX9uA6mvPIOZstkF3STDmO9phG5f2Ae/vDC7xxLCBoRxlYv3GoG9Ex+4w8QDrSuGUOJYCbzRVdYoWAmw85y+zro5XRYDlZZUTBXCC2QNDWH70f0rKGWHWrbj2yXy0+KHUrH4dBd52ajLXOymOd0y18trI6BCmA1tz2RvKexQqlrUmQqe+CieM5Jke8vlf6nu4scp8Tp/RWCnXDIKFTnqENZeRwCva7r5bfNv1Es1iD5LOGE+dT2sKG6htw2wKdOiuaA+zYxkr2+dmAct0REuSe1grIw+bNwkt110VMu4NrtMZYoYRgXsfu5G2kAVwfpr6bHdDT7F2diJkJGnA99kbXsVoL4zqxphZStEN/GfeVMU08bwmD+0bMV4e/HZuTDukiVDfHnjhxAQs4oO2Z7JF1g+YW0lI3KO0+6XkVVqlTKQ1AVBOkiZpV6X4ZiRwzNXFshOqYfSsVLnggJhAFXypX82334uCmyKUiiPWaxe+jGNFKRevFR0/4Dr Ys7j2aqW 1n3KvR2aYuwfLzHsaIJ0wLj6iCCJDjaRDQSKWquziwjbuFpns/peaTXUpXlP/CLySWZ63yDtnJQzHoycIBJH+x+X+88er/hbHt7GdVd6mQv1FutumFVAVUn+HzI8lKmEICdj54MCRAcfD43sqJtTguP2nPfx2EBO2K+/I4qZ2QIxH4Q6QmoOTq4TSaiRkAcbB3hT3BLhl2wahZumEopXDO00KVqdCfZ2+MObCK068yj155aCUWzc8CTEjtVz/zM7HjWsoz7hIwsdwkTYoXp1hv84WJcDCgreO897flrR1T+NtyImXx73zHz84n05O9nQjbTATyeR81kW+chAdPsSQvFl82TlyUgpBMIbvf47Pc9Lg6xD1o+C2ZmLWnLzYGcPwtudgd8SI2DYxKdBI7i7yfNV5Y0TVDHGyvt5Qt78KcbRP+jAzi/ai7yQBO4idANkzmxKQ57CrQj8BLvB+vSnR12JCrfSjyEoa4tCP3lpA6+xxYWpvW4qxruMEedhTo8UyShnjLNnwDjFUN/FYKJWyeljX1jg1/RPhIuXJj6ddxFqrcJa/2OTbnIzltmuVWBefVoMi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 01, 2024 at 12:16:52PM -0700, Vishal Moola wrote: > On Mon, Jul 01, 2024 at 05:49:34PM +0200, Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: df9574a57d02b265322e77fb8628d4d33641dda9 > > commit: 1cb6271d927cdb448a6a2794291c5405f1effa76 [7944/8232] hugetlb: force allocating surplus hugepages on mempolicy allowed nodes > > config: i386-randconfig-141-20240627 (https://download.01.org/0day-ci/archive/20240627/202406270727.F4yNrBsh-lkp@intel.com/config) > > compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202406270727.F4yNrBsh-lkp@intel.com/ > > > > smatch warnings: > > mm/hugetlb.c:2677 gather_surplus_pages() error: uninitialized symbol 'folio'. > > > > vim +/folio +2677 mm/hugetlb.c > > > > 0a4f3d1bb91cac Liu Xiang 2020-12-14 2644 static int gather_surplus_pages(struct hstate *h, long delta) > > 1b2a1e7bb9ce99 Jules Irenge 2020-04-06 2645 __must_hold(&hugetlb_lock) > > e4e574b767ba63 Adam Litke 2007-10-16 2646 { > > 3466534131b28e Miaohe Lin 2022-09-01 2647 LIST_HEAD(surplus_list); > > 454a00c40a21c5 Matthew Wilcox (Oracle 2023-08-16 2648) struct folio *folio, *tmp; > > 0a4f3d1bb91cac Liu Xiang 2020-12-14 2649 int ret; > > 0a4f3d1bb91cac Liu Xiang 2020-12-14 2650 long i; > > 0a4f3d1bb91cac Liu Xiang 2020-12-14 2651 long needed, allocated; > > 28073b02bfaaed Hillf Danton 2012-03-21 2652 bool alloc_ok = true; > > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2653 int node; > > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2654 nodemask_t *mbind_nodemask = policy_mbind_nodemask(htlb_alloc_mask(h)); > > e4e574b767ba63 Adam Litke 2007-10-16 2655 > > 9487ca60fd7fa2 Mike Kravetz 2021-05-04 2656 lockdep_assert_held(&hugetlb_lock); > > a5516438959d90 Andi Kleen 2008-07-23 2657 needed = (h->resv_huge_pages + delta) - h->free_huge_pages; > > ac09b3a15154af Adam Litke 2008-03-04 2658 if (needed <= 0) { > > a5516438959d90 Andi Kleen 2008-07-23 2659 h->resv_huge_pages += delta; > > e4e574b767ba63 Adam Litke 2007-10-16 2660 return 0; > > ac09b3a15154af Adam Litke 2008-03-04 2661 } > > e4e574b767ba63 Adam Litke 2007-10-16 2662 > > e4e574b767ba63 Adam Litke 2007-10-16 2663 allocated = 0; > > e4e574b767ba63 Adam Litke 2007-10-16 2664 > > e4e574b767ba63 Adam Litke 2007-10-16 2665 ret = -ENOMEM; > > e4e574b767ba63 Adam Litke 2007-10-16 2666 retry: > > db71ef79b59bb2 Mike Kravetz 2021-05-04 2667 spin_unlock_irq(&hugetlb_lock); > > e4e574b767ba63 Adam Litke 2007-10-16 2668 for (i = 0; i < needed; i++) { > > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2669 for_each_node_mask(node, cpuset_current_mems_allowed) { > > Smatch might be concerned about us skipping over this > for_each_node_mask()? It appears to be possible if we have 1 non-empty > Numa node. > Oh, yes, good point. That too. Thanks for looking at this. regards, dan carpenter