From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikita Danilov <Nikita@Namesys.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16418.24401.323448.472921@laputa.namesys.com>
Date: Thu, 5 Feb 2004 18:20:49 +0300
Subject: Re: [PATCH 0/5] mm improvements
In-Reply-To: <40225E0B.70200@cyberone.com.au>
References: <16416.64425.172529.550105@laputa.namesys.com>
	<Pine.LNX.4.44.0402041459420.3574-100000@localhost.localdomain>
	<16417.3444.377405.923166@laputa.namesys.com>
	<4021A6BA.5000808@cyberone.com.au>
	<16418.19751.234876.491644@laputa.namesys.com>
	<40225D1F.8090103@cyberone.com.au>
	<40225E0B.70200@cyberone.com.au>
Sender: owner-linux-mm@kvack.org
Return-Path: <owner-linux-mm@kvack.org>
To: Nick Piggin <piggin@cyberone.com.au>
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>, linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>

Nick Piggin writes:
 > 
 > 
 > Nick Piggin wrote:
 > 
 > >
 > > +                pte_dirty = page_pte_is_dirty(page, pte_paddr);
 > > +                if (pte_dirty != 0)
 > > +                    ret = pte_dirty;
 > >
 > >
 > > Won't this leave ret in a random state? Should it be ret++?
 > >
 > 
 > ... must be past my bedtime.
 > 

Well, @ret handling is kind of obscure in this function, right.

Nikita.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>