* [PATCH] mm/thp: Drop unused trace events hugepage_[invalidate|splitting]
@ 2022-01-07 9:05 Anshuman Khandual
2022-01-12 9:17 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Anshuman Khandual @ 2022-01-07 9:05 UTC (permalink / raw)
To: linux-mm
Cc: Anshuman Khandual, Steven Rostedt, Ingo Molnar, Andrew Morton,
Aneesh Kumar K.V, Kirill A . Shutemov, linux-kernel
The trace events hugepage_[invalidate|splitting], were added via the commit
9e813308a5c1 ("powerpc/thp: Add tracepoints to track hugepage invalidate").
Afterwards their call sites i.e trace_hugepage_[invalidate|splitting] were
just dropped off, leaving these trace points unused.
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Kirill A. Shutemov <kirill@shutemov.name>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
This applies on v5.16-rc8
trace_hugepage_splitting() dropped via the commit 7aa9a23c69ea
trace_hugepage_invalidate() dropped via the commit 7900757ce1b4
include/trace/events/thp.h | 36 ------------------------------------
1 file changed, 36 deletions(-)
diff --git a/include/trace/events/thp.h b/include/trace/events/thp.h
index d7fbbe551841..ffa4b37d02a9 100644
--- a/include/trace/events/thp.h
+++ b/include/trace/events/thp.h
@@ -8,24 +8,6 @@
#include <linux/types.h>
#include <linux/tracepoint.h>
-TRACE_EVENT(hugepage_invalidate,
-
- TP_PROTO(unsigned long addr, unsigned long pte),
- TP_ARGS(addr, pte),
- TP_STRUCT__entry(
- __field(unsigned long, addr)
- __field(unsigned long, pte)
- ),
-
- TP_fast_assign(
- __entry->addr = addr;
- __entry->pte = pte;
- ),
-
- TP_printk("hugepage invalidate at addr 0x%lx and pte = 0x%lx",
- __entry->addr, __entry->pte)
-);
-
TRACE_EVENT(hugepage_set_pmd,
TP_PROTO(unsigned long addr, unsigned long pmd),
@@ -65,24 +47,6 @@ TRACE_EVENT(hugepage_update,
TP_printk("hugepage update at addr 0x%lx and pte = 0x%lx clr = 0x%lx, set = 0x%lx", __entry->addr, __entry->pte, __entry->clr, __entry->set)
);
-TRACE_EVENT(hugepage_splitting,
-
- TP_PROTO(unsigned long addr, unsigned long pte),
- TP_ARGS(addr, pte),
- TP_STRUCT__entry(
- __field(unsigned long, addr)
- __field(unsigned long, pte)
- ),
-
- TP_fast_assign(
- __entry->addr = addr;
- __entry->pte = pte;
- ),
-
- TP_printk("hugepage splitting at addr 0x%lx and pte = 0x%lx",
- __entry->addr, __entry->pte)
-);
-
#endif /* _TRACE_THP_H */
/* This part must be outside protection */
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm/thp: Drop unused trace events hugepage_[invalidate|splitting]
2022-01-07 9:05 [PATCH] mm/thp: Drop unused trace events hugepage_[invalidate|splitting] Anshuman Khandual
@ 2022-01-12 9:17 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2022-01-12 9:17 UTC (permalink / raw)
To: Anshuman Khandual, linux-mm
Cc: Steven Rostedt, Ingo Molnar, Andrew Morton, Aneesh Kumar K.V,
Kirill A . Shutemov, linux-kernel
On 07.01.22 10:05, Anshuman Khandual wrote:
> The trace events hugepage_[invalidate|splitting], were added via the commit
> 9e813308a5c1 ("powerpc/thp: Add tracepoints to track hugepage invalidate").
> Afterwards their call sites i.e trace_hugepage_[invalidate|splitting] were
> just dropped off, leaving these trace points unused.
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> Cc: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> This applies on v5.16-rc8
>
> trace_hugepage_splitting() dropped via the commit 7aa9a23c69ea
> trace_hugepage_invalidate() dropped via the commit 7900757ce1b4
>
> include/trace/events/thp.h | 36 ------------------------------------
> 1 file changed, 36 deletions(-)
>
> diff --git a/include/trace/events/thp.h b/include/trace/events/thp.h
> index d7fbbe551841..ffa4b37d02a9 100644
> --- a/include/trace/events/thp.h
> +++ b/include/trace/events/thp.h
> @@ -8,24 +8,6 @@
> #include <linux/types.h>
> #include <linux/tracepoint.h>
>
> -TRACE_EVENT(hugepage_invalidate,
> -
> - TP_PROTO(unsigned long addr, unsigned long pte),
> - TP_ARGS(addr, pte),
> - TP_STRUCT__entry(
> - __field(unsigned long, addr)
> - __field(unsigned long, pte)
> - ),
> -
> - TP_fast_assign(
> - __entry->addr = addr;
> - __entry->pte = pte;
> - ),
> -
> - TP_printk("hugepage invalidate at addr 0x%lx and pte = 0x%lx",
> - __entry->addr, __entry->pte)
> -);
> -
> TRACE_EVENT(hugepage_set_pmd,
>
> TP_PROTO(unsigned long addr, unsigned long pmd),
> @@ -65,24 +47,6 @@ TRACE_EVENT(hugepage_update,
>
> TP_printk("hugepage update at addr 0x%lx and pte = 0x%lx clr = 0x%lx, set = 0x%lx", __entry->addr, __entry->pte, __entry->clr, __entry->set)
> );
> -TRACE_EVENT(hugepage_splitting,
> -
> - TP_PROTO(unsigned long addr, unsigned long pte),
> - TP_ARGS(addr, pte),
> - TP_STRUCT__entry(
> - __field(unsigned long, addr)
> - __field(unsigned long, pte)
> - ),
> -
> - TP_fast_assign(
> - __entry->addr = addr;
> - __entry->pte = pte;
> - ),
> -
> - TP_printk("hugepage splitting at addr 0x%lx and pte = 0x%lx",
> - __entry->addr, __entry->pte)
> -);
> -
> #endif /* _TRACE_THP_H */
>
> /* This part must be outside protection */
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-12 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07 9:05 [PATCH] mm/thp: Drop unused trace events hugepage_[invalidate|splitting] Anshuman Khandual
2022-01-12 9:17 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox