From: Nikita Danilov <Nikita@Namesys.COM>
To: Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <piggin@cyberone.com.au>, linux-mm@kvack.org
Subject: Re: [BENCHMARKS] Namesys VM patches improve kbuild
Date: Fri, 30 Jan 2004 15:00:48 +0300 [thread overview]
Message-ID: <16410.18288.285937.59890@laputa.namesys.com> (raw)
In-Reply-To: <20040129195602.469e9586.akpm@osdl.org>
Andrew Morton writes:
> Nick Piggin <piggin@cyberone.com.au> wrote:
> >
> > Hi Nikita,
> >
> > Just having a look at your patch. I think maybe this array
> > should be in a seperate cacheline per node?
> >
> > +/* dummy pages used to scan active lists */
> > +static struct page scan_pages[MAX_NUMNODES][MAX_NR_ZONES];
> > +
>
> You really want it a member of `struct zone', don't you?
>
> That'll cause include dependency hell, so maybe a page* in struct zone.
I don't quite understand:
struct zone {
....
/*
* dummy page used as place holder during scanning of
* active_list in refill_inactive_zone()
*/
struct page *scan_page;
....
};
is already here. Array scan_pages[][] contains struct pages to which
zone->scan_page's point to. Yes, I didn't embed struct page into struct
zone exactly due to dependencies problems.
>
>
Nikita.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-01-30 12:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-22 5:43 Nick Piggin
2004-01-22 6:36 ` Andrew Morton
2004-01-22 6:54 ` Nick Piggin
2004-01-22 7:04 ` Andrew Morton
2004-01-22 7:19 ` Nick Piggin
2004-01-22 8:16 ` William Lee Irwin III
2004-01-22 23:32 ` Nick Piggin
2004-01-22 10:35 ` Nikita Danilov
2004-01-22 23:01 ` Nick Piggin
2004-01-23 10:29 ` Nikita Danilov
2004-01-23 12:28 ` Nick Piggin
2004-01-23 15:09 ` Nick Piggin
2004-01-23 15:40 ` Nikita Danilov
2004-01-24 1:07 ` Nick Piggin
2004-01-26 11:19 ` Nikita Danilov
2004-01-26 11:25 ` Nick Piggin
2004-01-26 12:14 ` Nikita Danilov
2004-01-30 3:48 ` Nick Piggin
2004-01-30 3:56 ` Andrew Morton
2004-01-30 12:00 ` Nikita Danilov [this message]
2004-01-23 7:16 ` Nick Piggin
2004-01-23 9:42 ` Nikita Danilov
2004-01-23 12:15 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16410.18288.285937.59890@laputa.namesys.com \
--to=nikita@namesys.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox