From: Muchun Song <muchun.song@linux.dev>
To: cgel.zte@gmail.com
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, Linux MM <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org, xupanda <xu.panda@zte.com.cn>,
Zeal Robot <zealic@zte.com.cn>
Subject: Re: [PATCH linux-next] mm: memcontrol: Fix typos in comment Fix a spelling mistake in comment.
Date: Mon, 15 Aug 2022 14:45:27 +0800 [thread overview]
Message-ID: <163DC765-D629-4BF5-8A3C-9146BEC6748D@linux.dev> (raw)
In-Reply-To: <20220815061208.65945-1-xu.panda@zte.com.cn>
> On Aug 15, 2022, at 14:12, cgel.zte@gmail.com wrote:
>
> From: xupanda <xu.panda@zte.com.cn>
1. Your subject seems to have redundant description.
“Fix typos in comment” vs “Fix a spelling mistake in comment"
2. It is better to clarify what you have changed here. Like:
Fix a spelling mistake on “cgruop1”.
With this:
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
prev parent reply other threads:[~2022-08-15 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 6:12 cgel.zte
2022-08-15 6:45 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163DC765-D629-4BF5-8A3C-9146BEC6748D@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgel.zte@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=xu.panda@zte.com.cn \
--cc=zealic@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox