From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DCDDC433EF for ; Thu, 9 Dec 2021 09:36:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA3AA6B0071; Thu, 9 Dec 2021 04:36:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A535D6B0073; Thu, 9 Dec 2021 04:36:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91B3C6B0074; Thu, 9 Dec 2021 04:36:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 83EFF6B0071 for ; Thu, 9 Dec 2021 04:36:34 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DDFD58248076 for ; Thu, 9 Dec 2021 09:36:23 +0000 (UTC) X-FDA: 78897750246.30.7993547 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf03.hostedemail.com (Postfix) with ESMTP id E657620002 for ; Thu, 9 Dec 2021 09:36:22 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id y14-20020a17090a2b4e00b001a5824f4918so6436973pjc.4 for ; Thu, 09 Dec 2021 01:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=ANnqQo7YlVyJRVO2UBynpUD5QgJ1sL4B6Gna7gav4x0=; b=b2ViHkJCp5m2+2YQHTPTBDm3RXv4V9ziuzsBvMmlYIRLLAOHKjnI0TyaxmWM0mwzzE sTEowXvVIH/XHfcRygVyF9S8R03oieKXkXP5ZrR1GTIuxfMMkJCH4KHjcm/Cv4Mw8q/u Op5FnGErqqIGrcCx3n5EE/Yv9ta4UdDVjhZUSZqoDm9WA5EUH+2TehBUWdv/4vh2myyy casRoLbcXeK4OYu0zE04pKOKQk5SoMBTi/Fckg/qDnwjpvDErFnYp6eUxL4M7cNHZzAM PrMt9U5KCKplnJmehYc13wsAimamkDxvhE6PJAWFf4JnU7sPBWrStGm4CPeMcyoziKWp b99A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=ANnqQo7YlVyJRVO2UBynpUD5QgJ1sL4B6Gna7gav4x0=; b=Z5ym3aHjxH6ynZHxrm1uB+nFnIKULchhpnCLz3faL7O/+1evUy/drElOU2a7Sog2+C SXP9ztzx2XZGEYKISBzIe5JHRe1iwmYbalZ5bnavMru2nnCnPHrQK/E9KRQYkSb1D8nk /MSuDgz2Sycj/qmrHiWMGyhpFLhXC77/jOGWBL0rxx9meBtHEV3gasaXoAt7XlwRiZ5O l3KgpbLFVAL0HLbqAE5fJWgiHUeTq+xBmrIymgQexwm4xiygz7XC3bkM+5/ZrZe0cpvH bzMsdj6c6B/HA3xF/NGlbPR484SOsv8X4yPjoEQxyk6io3SHLGpaeV6LQNfWMDz/Dsr6 VWHQ== X-Gm-Message-State: AOAM530o4ztKKggaj/5JiLM4JB2K3W0sjiFceltxndSyuYnuuzhh1ztY SNh7WI04RFHm8KqSb05Y5x8= X-Google-Smtp-Source: ABdhPJxAboP2NZuRVxFnuWAZ/4Plf9uJs6kjYeQI3ZWn5Gl+RspeZdtlIldC9e6K060mWaNM2FrOMA== X-Received: by 2002:a17:90a:b88d:: with SMTP id o13mr14105935pjr.39.1639042581800; Thu, 09 Dec 2021 01:36:21 -0800 (PST) Received: from localhost (203-219-139-206.static.tpgi.com.au. [203.219.139.206]) by smtp.gmail.com with ESMTPSA id g7sm6435078pfv.159.2021.12.09.01.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 01:36:21 -0800 (PST) Date: Thu, 09 Dec 2021 19:36:14 +1000 From: Nicholas Piggin Subject: Re: [PATCH v4 03/10] powerpc/mm: Move vma_mmu_pagesize() To: "alex@ghiti.fr" , Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , Paul Mackerras Cc: "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" References: <372d1488c35dca1c5af04f95d9b8548ea07ea603.1638976229.git.christophe.leroy@csgroup.eu> In-Reply-To: <372d1488c35dca1c5af04f95d9b8548ea07ea603.1638976229.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Message-Id: <1639042485.7qs1vmt7kw.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E657620002 X-Stat-Signature: cbpjmgj7gkwuy3p17wwkpjg1w44oyagw Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=b2ViHkJC; spf=pass (imf03.hostedemail.com: domain of npiggin@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=npiggin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1639042582-868458 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Christophe Leroy's message of December 9, 2021 3:18 am: > vma_mmu_pagesize() is only required for slices, > otherwise there is a generic weak version doing the > exact same thing. >=20 > Move it to slice.c >=20 Reviewed-by: Nicholas Piggin > Signed-off-by: Christophe Leroy > --- > arch/powerpc/mm/hugetlbpage.c | 11 ----------- > arch/powerpc/mm/slice.c | 9 +++++++++ > 2 files changed, 9 insertions(+), 11 deletions(-) >=20 > diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.= c > index ddead41e2194..0eec3b61bd13 100644 > --- a/arch/powerpc/mm/hugetlbpage.c > +++ b/arch/powerpc/mm/hugetlbpage.c > @@ -565,17 +565,6 @@ unsigned long hugetlb_get_unmapped_area(struct file = *file, unsigned long addr, > } > #endif > =20 > -unsigned long vma_mmu_pagesize(struct vm_area_struct *vma) > -{ > - /* With radix we don't use slice, so derive it from vma*/ > - if (IS_ENABLED(CONFIG_PPC_MM_SLICES) && !radix_enabled()) { > - unsigned int psize =3D get_slice_psize(vma->vm_mm, vma->vm_start); > - > - return 1UL << mmu_psize_to_shift(psize); > - } > - return vma_kernel_pagesize(vma); > -} > - > bool __init arch_hugetlb_valid_size(unsigned long size) > { > int shift =3D __ffs(size); > diff --git a/arch/powerpc/mm/slice.c b/arch/powerpc/mm/slice.c > index f42711f865f3..8a3ac062b71e 100644 > --- a/arch/powerpc/mm/slice.c > +++ b/arch/powerpc/mm/slice.c > @@ -759,4 +759,13 @@ int slice_is_hugepage_only_range(struct mm_struct *m= m, unsigned long addr, > =20 > return !slice_check_range_fits(mm, maskp, addr, len); > } > + > +unsigned long vma_mmu_pagesize(struct vm_area_struct *vma) > +{ > + /* With radix we don't use slice, so derive it from vma*/ > + if (radix_enabled()) > + return vma_kernel_pagesize(vma); > + > + return 1UL << mmu_psize_to_shift(get_slice_psize(vma->vm_mm, vma->vm_st= art)); > +} > #endif > --=20 > 2.33.1 >=20 >=20