From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D9D9C433EF for ; Wed, 1 Dec 2021 06:01:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87E9D6B0074; Wed, 1 Dec 2021 01:01:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 807476B0075; Wed, 1 Dec 2021 01:01:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 680336B0078; Wed, 1 Dec 2021 01:01:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 5909C6B0074 for ; Wed, 1 Dec 2021 01:01:16 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 102498274F for ; Wed, 1 Dec 2021 06:01:06 +0000 (UTC) X-FDA: 78868177332.17.6EDFC4E Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf19.hostedemail.com (Postfix) with ESMTP id 9D852B00018F for ; Wed, 1 Dec 2021 06:01:05 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id z6so16840160plk.6 for ; Tue, 30 Nov 2021 22:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=p+h1Ci/5eM23w48d10JZjE3E1+seAEm4EAViYXAETPQ=; b=EMHBw0e/vGvcPCdRzYL0MfE/37rgfduTDk9qLZ0R3VsAFToDzsY/A2ZyZ55i+ws7OC 0NL1oAJDxinVH4PZ9cqcxaQji1byUi4VBBM5seBz+tqYgz/yhelWO7a1trjSCybQ3lcc pYciQPv0k6n7Hwx2dgGPY2QSQxnkTHGPCPmxujPrXi76r1YIneRk3+Dos1ye+XfYOd2i VvBSarZjbLT9XBYH2mkWnOmV0bD/AoTKSuoMmLv+z7Tqnq4tqUwJ+nlHapIl9iQR9Sfq cQMSM+DZl4T0/eKs/Idrs599QBFIKXg03quXFFHV1VsZovNYt23a2gDS0ak+hDJvHwwB 28QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=p+h1Ci/5eM23w48d10JZjE3E1+seAEm4EAViYXAETPQ=; b=UTIlbcsSsJw0oOZwoUkXZuGTqZeBSd41TlKUcnmjE9ilSPtkXflUv6CCK0WDpxGnMG 5iaQYsv/3yAXXrfUyx4Qde5J/Rxzqk0T+kcQUswXohKxjtavvRGJaoTv/jwIVKbB4+CI 2zP5/bx6p1F7PkY6BIpZ6ezJjx48sVufRjjIrBaSfCNA79kmzC9jJwRTkQv7YlZSVPiD xiqbJilG+Kzyq5NL2PGYJbBLPd6IGRdJp6XldlOstUsiAWTLGBvWqhsAeo4Nl9DnOVMW vA0kI9H/kmZoyEZIYscYLRJMbN4RehN5YJaWI5umRHtcojTwX74FHmbIfh7pTrFopJXv /mWw== X-Gm-Message-State: AOAM532UqKQL3BwuwsNMVRc2bi8RU1510KJjoDWvW+ubD2bTPA1Mb+6u +f+D+Hsh9s4FvW5Qn6/QfDs= X-Google-Smtp-Source: ABdhPJyVjW0vwT2dzIxQQRiiYKpz/cJyyLjekGgJiHEOZGOEmsuBfOcYzGxu/rMy5VtmahhvpyRyHA== X-Received: by 2002:a17:902:c202:b0:142:2441:aa25 with SMTP id 2-20020a170902c20200b001422441aa25mr4897937pll.68.1638338464453; Tue, 30 Nov 2021 22:01:04 -0800 (PST) Received: from localhost (115-64-213-93.static.tpgi.com.au. [115.64.213.93]) by smtp.gmail.com with ESMTPSA id p10sm22499478pff.173.2021.11.30.22.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 22:01:03 -0800 (PST) Date: Wed, 01 Dec 2021 16:00:58 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 rebased 5/9] powerpc/mm: Call radix__arch_get_unmapped_area() from arch_get_unmapped_area() To: alex@ghiti.fr, Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org References: <6ba86b0ef347c04a6c4e475c059f486b0db170ec.1637862579.git.christophe.leroy@csgroup.eu> In-Reply-To: <6ba86b0ef347c04a6c4e475c059f486b0db170ec.1637862579.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Message-Id: <1638338152.00yryi8b39.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 8b7636wd7pbtyt6mhcgxnwt7it8wobnu Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="EMHBw0e/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of npiggin@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=npiggin@gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9D852B00018F X-HE-Tag: 1638338465-775398 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001873, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Christophe Leroy's message of November 26, 2021 3:52 am: > Instead of setting mm->get_unmapped_area() to either > arch_get_unmapped_area() or radix__arch_get_unmapped_area(), > always set it to arch_get_unmapped_area() and call > radix__arch_get_unmapped_area() from there when radix is enabled. >=20 > To keep radix__arch_get_unmapped_area() static, move it to slice.c >=20 > Do the same with radix__arch_get_unmapped_area_topdown() Same comment with this one really. It would be better if we can reuse generic code. Thanks, Nick