From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087F5C433EF for ; Fri, 22 Oct 2021 01:07:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E51760FD8 for ; Fri, 22 Oct 2021 01:07:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8E51760FD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DBBB6900003; Thu, 21 Oct 2021 21:07:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4328900002; Thu, 21 Oct 2021 21:07:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B708F900003; Thu, 21 Oct 2021 21:07:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id A14DF900002 for ; Thu, 21 Oct 2021 21:07:54 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5EA588249980 for ; Fri, 22 Oct 2021 01:07:54 +0000 (UTC) X-FDA: 78722286468.38.1D57F3C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 89DFD10000BD for ; Fri, 22 Oct 2021 01:07:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 85D361FD5D; Fri, 22 Oct 2021 01:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1634864872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhUuNIRaH32Jg6rNRG9aJqS7Vzin0wwV0iGwsDMIo8Y=; b=JWeAJeHHc23DutYi/I3mBxe0vpnYRi37B0yVlrR84wIEUTZfLpsZ4VUzwPkXUpi9zP2blY AoJpZHcfy62DoUpkDjPJiJpulIfe1q4pEP3BKWpZ7O6IdoYtKZLVm1zW0QScowM+35dIXl WivDFoKYGvvr3tgs+J5vFRSsPwl04HU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1634864872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhUuNIRaH32Jg6rNRG9aJqS7Vzin0wwV0iGwsDMIo8Y=; b=MRDubLBijrL0abU+hF316RmPJCeCcnsIhZ6AbgVbj5+ERWZkIJnQpwD1YqxoO+ELWDNnE2 f0mqdAzRG+motvAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0E4B01346B; Fri, 22 Oct 2021 01:07:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KRnFKuIOcmHrJQAAMHmgww (envelope-from ); Fri, 22 Oct 2021 01:07:46 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 From: "NeilBrown" To: "Mel Gorman" Cc: "Andrew Morton" , "Theodore Ts'o" , "Andreas Dilger" , "Darrick J . Wong" , "Matthew Wilcox" , "Michal Hocko" , "Dave Chinner" , "Rik van Riel" , "Vlastimil Babka" , "Johannes Weiner" , "Jonathan Corbet" , "Linux-MM" , "Linux-fsdevel" , "LKML" , "Mel Gorman" Subject: Re: [PATCH 7/8] mm/vmscan: Increase the timeout if page reclaim is not making progress In-reply-to: <20211019090108.25501-8-mgorman@techsingularity.net> References: <20211019090108.25501-1-mgorman@techsingularity.net>, <20211019090108.25501-8-mgorman@techsingularity.net> Date: Fri, 22 Oct 2021 12:07:43 +1100 Message-id: <163486486314.17149.7181265861483962024@noble.neil.brown.name> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 89DFD10000BD X-Stat-Signature: ngnhbsmdz5fde5x7bn1yppnbcry47rmh Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=JWeAJeHH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MRDubLBi; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of neilb@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=neilb@suse.de X-HE-Tag: 1634864878-469544 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 19 Oct 2021, Mel Gorman wrote: > Tracing of the stutterp workload showed the following delays >=20 > 1 usect_delayed=3D124000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 1 usect_delayed=3D128000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 1 usect_delayed=3D176000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 1 usect_delayed=3D536000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 1 usect_delayed=3D544000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 1 usect_delayed=3D556000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 1 usect_delayed=3D624000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 1 usect_delayed=3D716000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 1 usect_delayed=3D772000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 2 usect_delayed=3D512000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 16 usect_delayed=3D120000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 53 usect_delayed=3D116000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 116 usect_delayed=3D112000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 5907 usect_delayed=3D108000 reason=3DVMSCAN_THROTTLE_NOPROGRESS > 71741 usect_delayed=3D104000 reason=3DVMSCAN_THROTTLE_NOPROGRESS >=20 > All the throttling hit the full timeout and then there was wakeup delays > meaning that the wakeups are premature as no other reclaimer such as > kswapd has made progress. This patch increases the maximum timeout. Would love to see the comparable tracing results for after the patch. Thanks, NeilBrown >=20 > Signed-off-by: Mel Gorman > Acked-by: Vlastimil Babka > --- > mm/vmscan.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1f5c467dc83c..ec2006680242 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1033,6 +1033,8 @@ void reclaim_throttle(pg_data_t *pgdat, enum vmscan_t= hrottle_state reason) > */ > switch(reason) { > case VMSCAN_THROTTLE_NOPROGRESS: > + timeout =3D HZ/2; > + break; > case VMSCAN_THROTTLE_WRITEBACK: > timeout =3D HZ/10; > =20 > --=20 > 2.31.1 >=20 >=20