From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0EADC433EF for ; Thu, 21 Oct 2021 14:37:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 31F12610D0 for ; Thu, 21 Oct 2021 14:37:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 31F12610D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AB2026B0071; Thu, 21 Oct 2021 10:37:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A631E900002; Thu, 21 Oct 2021 10:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94FED6B0073; Thu, 21 Oct 2021 10:37:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 828506B0071 for ; Thu, 21 Oct 2021 10:37:42 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2DFAC30C88 for ; Thu, 21 Oct 2021 14:37:42 +0000 (UTC) X-FDA: 78720698364.34.67CF890 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf07.hostedemail.com (Postfix) with ESMTP id 3756A10000BD for ; Thu, 21 Oct 2021 14:37:46 +0000 (UTC) Received: by mail-ot1-f42.google.com with SMTP id g62-20020a9d2dc4000000b0054752cfbc59so701845otb.1 for ; Thu, 21 Oct 2021 07:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=dDWiDipIHK5HS6MeBxjwAzx3AX6EeZz5LXZckVi1/bo=; b=GK5V02ISlYBHzpOBLF1zpta1GjhfAs9dy2MvUVgN5TUFpyOInmeAsVfJP+6ah1rZVv bNIlx97VDxD5ozhsnrZZdE3Yn1O3JsA5IdMmdE6ZkcdhXHQFcVyTXcjjAMTie4cXf+0U WM8isIKKkZJEZffuGxvnr5jfzL6xGo6TW6NawGLgOIgbYFVPAFy7PeKfOXv8/SZx2kFp ljkEVIabkyc9VzhlUyVw2hH0o4ouYSc0MspRk+qCO98md3YCz7CxX0GlMRcHmHdfrtBb OBxSugbTXw0jsGomAnItJKwo1ZJplwg0mTw/1ARmCBWIfNuOQRepNV7ep24Dwe5pv7yz J3rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=dDWiDipIHK5HS6MeBxjwAzx3AX6EeZz5LXZckVi1/bo=; b=n6c63s2Yib/VOKZ5xVDI+IBnwUA1fygw6PYmjEv4z+KYFN86zxeijb+JWdB3JDD11Q K8DznOmQNzxtjaBO5juFmerqY9GOUeLyCrLvFpJeSIN7tbU3Aj0JYFI2Ymnp3pdSGhDs Dc6L5HMoFKEN0K5jec/1Nef5ZeO0y8f9RhOWoh2AXj5BXYCGPWsnQK5h8wyPuGE0MvmR B0sNOFB/y0qvPzrqlM/pDy+T0hag01AZGNkvAWp4Xeh8Yjij5L01rZNR0zd8jKJDlPnj jrqadvgoZLOB8Jrt04/0Ya9uzvLUuespac+nik5cwDkp/71+6+wp1OqzHPlMs+xnKxbN q+wQ== X-Gm-Message-State: AOAM531rOMdnvXaAXzSCwsUY8J3w8mgvc+AtPN5rKObFt+0AZ5CaWvuT dWrMlbUaJYKcVemODpmk5xEd/g== X-Google-Smtp-Source: ABdhPJxNL5QPcUrTS8+siBt4FYmfmiwU2xtnsVC3wrzxIslvK3bC3TMz4siO5gWkpAxAhnVJjJ67WQ== X-Received: by 2002:a9d:20a3:: with SMTP id x32mr4783922ota.91.1634827061206; Thu, 21 Oct 2021 07:37:41 -0700 (PDT) Received: from [127.0.1.1] ([2600:380:783a:c43c:af64:c142:4db7:63ac]) by smtp.gmail.com with ESMTPSA id bk8sm1131310oib.57.2021.10.21.07.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 07:37:40 -0700 (PDT) From: Jens Axboe To: Pavel Begunkov , linux-block@vger.kernel.org Cc: Dennis Zhou , Tejun Heo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter In-Reply-To: References: Subject: Re: [PATCH v2 0/2] optimise blk_try_enter_queue() Message-Id: <163482705916.41758.93518625125015139.b4-ty@kernel.dk> Date: Thu, 21 Oct 2021 08:37:39 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3756A10000BD X-Stat-Signature: 31o1cgrfa97q41omy99b6bafwih8z6ec Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=GK5V02IS; dmarc=none; spf=pass (imf07.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.42 as permitted sender) smtp.mailfrom=axboe@kernel.dk X-HE-Tag: 1634827066-574152 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 21 Oct 2021 14:30:50 +0100, Pavel Begunkov wrote: > Kill extra rcu_read_lock/unlock() pair in blk_try_enter_queue(). > Testing with io_uring (high batching) with nullblk: >=20 > Before: > 3.20% io_uring [kernel.vmlinux] [k] __rcu_read_unlock > 3.05% io_uring [kernel.vmlinux] [k] __rcu_read_lock >=20 > [...] Applied, thanks! [1/2] percpu_ref: percpu_ref_tryget_live() version holding RCU commit: 3b13c168186c115501ee7d194460ba2f8c825155 [2/2] block: kill extra rcu lock/unlock in queue enter commit: e94f68527a35271131cdf9d3fb4eb3c2513dc3d0 Best regards, --=20 Jens Axboe