linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] mm: page_alloc: Add debug log in free_reserved_area for static memory
@ 2021-10-18  6:54 Faiyaz Mohammed
  2021-10-18 18:00 ` Andrew Morton
  2021-10-19  2:50 ` [mm] f859d2a494: kernel_BUG_at_arch/x86/mm/physaddr.c kernel test robot
  0 siblings, 2 replies; 3+ messages in thread
From: Faiyaz Mohammed @ 2021-10-18  6:54 UTC (permalink / raw)
  To: akpm, linux-mm, linux-kernel, david; +Cc: guptap, Faiyaz Mohammed

For INITRD and initmem memory is reserved through "memblock_reserve"
during boot up but it is free via "free_reserved_area" instead
of "memblock_free".
For example:
[    0.294848] Freeing initrd memory: 12K.
[    0.696688] Freeing unused kernel memory: 4096K.

To get the start and end address of the above freed memory and to account
proper memblock added pr_debug log in "free_reserved_area".
After adding log:
[    0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0x28
[    0.294848] Freeing initrd memory: 12K.
[    0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8
[    0.696688] Freeing unused kernel memory: 4096K.

Signed-off-by: Faiyaz Mohammed <faiyazm@codeaurora.org>
---
changes in v4:
	- Use correctly _RET_IP_ macro.
changes in v3:
	- Update the format specifier.
changes in v2:
	- To avoid confusion, remove the memblock_dbg print and drop the
	memblock_free string, now using pr_debug to print the address ranges.

 mm/page_alloc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b37435c..19ca193 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -8097,6 +8097,8 @@ EXPORT_SYMBOL(adjust_managed_page_count);
 
 unsigned long free_reserved_area(void *start, void *end, int poison, const char *s)
 {
+	const phys_addr_t pstart = __pa(start);
+	const phys_addr_t pend = __pa(end);
 	void *pos;
 	unsigned long pages = 0;
 
@@ -8125,9 +8127,12 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char
 		free_reserved_page(page);
 	}
 
-	if (pages && s)
+	if (pages && s) {
 		pr_info("Freeing %s memory: %ldK\n",
 			s, pages << (PAGE_SHIFT - 10));
+		pr_debug("[%pa-%pa] %pS\n", &pstart, &pend,
+			(void *)_RET_IP_);
+	}
 
 	return pages;
 }
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-19  2:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18  6:54 [PATCH v4] mm: page_alloc: Add debug log in free_reserved_area for static memory Faiyaz Mohammed
2021-10-18 18:00 ` Andrew Morton
2021-10-19  2:50 ` [mm] f859d2a494: kernel_BUG_at_arch/x86/mm/physaddr.c kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox