From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D29C4332F for ; Fri, 15 Oct 2021 05:58:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7DF6361163 for ; Fri, 15 Oct 2021 05:58:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7DF6361163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D4560900002; Fri, 15 Oct 2021 01:58:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCDB16B0071; Fri, 15 Oct 2021 01:58:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6E4C900002; Fri, 15 Oct 2021 01:58:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id A40CC6B006C for ; Fri, 15 Oct 2021 01:58:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5146E2D4B9 for ; Fri, 15 Oct 2021 05:58:03 +0000 (UTC) X-FDA: 78697616046.22.1D4E21A Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf28.hostedemail.com (Postfix) with ESMTP id E6798900009E for ; Fri, 15 Oct 2021 05:58:02 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id d13-20020a17090ad3cd00b0019e746f7bd4so8634298pjw.0 for ; Thu, 14 Oct 2021 22:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=S0rBIBfnndl4sO0SZD30iqTuRSBoy5r+zNmXEO729ec=; b=BvkezB9DzKzErquz1XZOTKqoL0XOL3U6Eb5odSJ6flnnPgmmGEa3vMoyopsdwVJpIo +kJ9msCSx7YGPh77U30LXnNLubl1IugeDdeSuYmeI37nvbmhSm5CsYs8iAoSKXMNhzxO 6i912LlK4afHQGJIc4S85mDVOKR5UpDhCrBkxj6ietrjMxi2fywEBEuiLIZgu19q/I1g +8t1vHWN0EHqjETvz4uZZN6EvLLpsZtZkFFYte3N8uN6vsiAuv/ZnqxmivZw24+wB8Ud WkPTCZYNe4CFVIiv/WGJwu9SWhmgRP+wcQq7L1rL9ZDmaijfZRGwseytUWA+JVHD4hhp bQ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=S0rBIBfnndl4sO0SZD30iqTuRSBoy5r+zNmXEO729ec=; b=0yS6x0lFzbDWk/s/LnEW9w8HIFZ+LNCVSe81qIjqRZN6fDyaCMkrbBXWORmx1MU9q2 KE2Hs/x8xshHaDq8vYgFgYDJz9rYK4/eQ6jtJfGGEL+oWaCx0KgiH8tVTha8rTCoQgad 5y+JU26L0TNLDMVTm0wQex0Ln7BdZMek+5rSNnnMM3wWehBnxEuYJWzbLFGxf0d3ll0p eqHQl9ZopfdtUfPqEIec47bLIikmCa/Km1C7zTzcwvCwdfPcBt5DWJVPVrLNUD5VI2wV PhMbEBaMy1ka61kgCdi/iw1YctNqvrjzclxj2U5JZSQpa+ewExXe2PBzlgwgPtgN+h4k G22g== X-Gm-Message-State: AOAM531m/noAFAULwhNGg34t8yrGFwXlOtUhLox9HAy8HyxUdt48RJR9 R5OlsKd6HulmH3dvWq/J94s= X-Google-Smtp-Source: ABdhPJyXz4rN56bUpmFK5R707chQeiJbYyyVjPcMsN6ywtX2cPlh5ALJb3tBLebih8BJB0NaHGRlvg== X-Received: by 2002:a17:902:d488:b0:13f:165e:f491 with SMTP id c8-20020a170902d48800b0013f165ef491mr9412847plg.12.1634277481786; Thu, 14 Oct 2021 22:58:01 -0700 (PDT) Received: from localhost (14-203-144-177.static.tpgi.com.au. [14.203.144.177]) by smtp.gmail.com with ESMTPSA id t126sm4092988pfc.80.2021.10.14.22.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 22:58:01 -0700 (PDT) Date: Fri, 15 Oct 2021 15:57:56 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 01/13] powerpc: Move 'struct ppc64_opd_entry' back into asm/elf.h To: Andrew Morton , Arnd Bergmann , Benjamin Herrenschmidt , Christophe Leroy , Helge Deller , Greg Kroah-Hartman , "James E.J. Bottomley" , Kees Cook , Michael Ellerman , Paul Mackerras Cc: linux-arch@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <42d2a571677e60082c0a5b3e52e855aa58c0b1fc.1634190022.git.christophe.leroy@csgroup.eu> In-Reply-To: <42d2a571677e60082c0a5b3e52e855aa58c0b1fc.1634190022.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Message-Id: <1634277306.r82aohhn4e.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E6798900009E X-Stat-Signature: xu7m4qhmsgby98qmigwnumzxp8kuqb4q Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BvkezB9D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of npiggin@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=npiggin@gmail.com X-HE-Tag: 1634277482-613765 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Christophe Leroy's message of October 14, 2021 3:49 pm: > 'struct ppc64_opd_entry' doesn't belong to uapi/asm/elf.h >=20 > It was initially in module_64.c and commit 2d291e902791 ("Fix compile > failure with non modular builds") moved it into asm/elf.h >=20 > But it was by mistake added outside of __KERNEL__ section, > therefore commit c3617f72036c ("UAPI: (Scripted) Disintegrate > arch/powerpc/include/asm") moved it to uapi/asm/elf.h >=20 > Move it back into asm/elf.h, this brings it back in line with > IA64 and PARISC architectures. >=20 > Fixes: 2d291e902791 ("Fix compile failure with non modular builds") > Reviewed-by: Kees Cook > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/elf.h | 6 ++++++ > arch/powerpc/include/uapi/asm/elf.h | 8 -------- > 2 files changed, 6 insertions(+), 8 deletions(-) >=20 > diff --git a/arch/powerpc/include/asm/elf.h b/arch/powerpc/include/asm/el= f.h > index b8425e3cfd81..a4406714c060 100644 > --- a/arch/powerpc/include/asm/elf.h > +++ b/arch/powerpc/include/asm/elf.h > @@ -176,4 +176,10 @@ do { \ > /* Relocate the kernel image to @final_address */ > void relocate(unsigned long final_address); > =20 > +/* There's actually a third entry here, but it's unused */ > +struct ppc64_opd_entry { > + unsigned long funcaddr; > + unsigned long r2; > +}; Reviewed-by: Nicholas Piggin I wonder if we should add that third entry, just for completeness. And=20 'r2' isn't a good name should probably be toc. And should it be packed?=20 At any rate that's not for your series, a cleanup I might think about for later. Thanks, Nick