From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98152CD6E7E for ; Wed, 11 Oct 2023 15:42:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F26E88D00A3; Wed, 11 Oct 2023 11:42:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED6A88D0050; Wed, 11 Oct 2023 11:42:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9D6F8D00A3; Wed, 11 Oct 2023 11:42:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C70538D0050 for ; Wed, 11 Oct 2023 11:42:44 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9A31214028E for ; Wed, 11 Oct 2023 15:42:44 +0000 (UTC) X-FDA: 81333598248.07.7B4136B Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf15.hostedemail.com (Postfix) with ESMTP id 16B87A0030 for ; Wed, 11 Oct 2023 15:42:41 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=W3sDuKGH; spf=pass (imf15.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697038962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cLH0umzVzkzMlLL505+WdiJ0FY1Sury7B+CiECVSeNs=; b=Un8xxcyHgNakZshL5428zrAN+1jYJaDICd9sDF4ntutFMapp1Lq1yU2F/NHcxMVyWv+tXR /J0xzPVnIhaxrqWDC61OBymnXdkrHpeuUy46KSwJ9ATvhESgDyKXK1eqJHz/5xfJPvJ/DN ELdeEDY072EQVtWeZITvFssx5F5yCYU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697038962; a=rsa-sha256; cv=none; b=ReowgkLybp4GYFnRChOF34z5MA7uGc3NxdCkpdOQPVMRAgSxU0uEfDN9drIlXV+RUCakjf neggDbpmJ62F/eTg6ZhBP0rjpDOUfruUeErCLCJSZbdxecabPZhNlH06bIJogFT5XMwEQL nmn0WZf/m1ZuL3XtyOb9xNUZORFv6gI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=W3sDuKGH; spf=pass (imf15.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1c9a1762b43so26382265ad.1 for ; Wed, 11 Oct 2023 08:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1697038959; x=1697643759; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=cLH0umzVzkzMlLL505+WdiJ0FY1Sury7B+CiECVSeNs=; b=W3sDuKGHvRNS4+8uVDm77b+/Ceesx/4UXxul7HuDP1WYwF2Drz2wHMZ08X3iHjUZC0 RIfST21tiiSw3drg9PVkBagTTN5X8Z/YmBpxXMybRWJg75Crek+NXT0h5Ef8VJSSl5sL 9gzI57BTu9gEVbaG0IMRR6k70sRyhp2Ervh7LqQL18Jna7Egt7JDZXoJhfTiu/O/2T7t bf8eUCo1FvkfBAqm9TZmeBP/CKv6iwELxjTGTi3f7ZMovc0WUGxXZ3sCriSFGioJqqh8 VfxkM0pBSMlHdX35s1qDXYfQPhTVkJO+xWAET3NOp7VfFpp+fQz1eMeigZ52+D1HZjRU +GyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697038959; x=1697643759; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cLH0umzVzkzMlLL505+WdiJ0FY1Sury7B+CiECVSeNs=; b=X1C1yV+Dtg+eA/sGt5VsNl0HToWhK3vbl8DKwla8Nq9ZXf7+kozCP8NaGPTdN+l/fA ltB2NeJlkMrAIPJVg/w/GD034b04qa6OnbevAP+xsDUqK0QqGhBc38TU4X+S8WV4eDuS j2riMoMM5zAdIlL9atWbdfNUU6Z9KmxYlQEzvF5q3fRRO13DXViDwQfjp+rkSNg8FJnq vMAu0ZEomr4Hy9T7hHis7LAHg/98oDjCLI3mRZ3UUR14AockXC4c4CjawlBCKiyvWzyv VeWgX6HieGneSLGUIu9c0PVgr/Ww2MD6yyl9RJlaWKbk1r6ZJedZsl9BVXXMTY4zkyIj P3Nw== X-Gm-Message-State: AOJu0YxAC/wM0bMsZEGJaHdO/A7hQcbpljXnZDkzMQrYTP8u8Q7zokTS 52/MclR6FZ50Mc9E1BA0/xEZ4A== X-Google-Smtp-Source: AGHT+IGPdhqvnqVeFNJs68w/YbZwkSpWls5CnBMwSw9bjKEbdwdMVO/Hv7EShENVpIrvfdotYi32RQ== X-Received: by 2002:a17:902:7893:b0:1bc:6c8:cded with SMTP id q19-20020a170902789300b001bc06c8cdedmr20157796pll.67.1697038959247; Wed, 11 Oct 2023 08:42:39 -0700 (PDT) Received: from [10.4.181.228] ([139.177.225.227]) by smtp.gmail.com with ESMTPSA id g5-20020a170902c38500b001c60e7bf5besm14039387plg.281.2023.10.11.08.42.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 08:42:38 -0700 (PDT) Message-ID: <1632d0e6-2d52-43b1-8a01-056231c0819d@bytedance.com> Date: Wed, 11 Oct 2023 23:42:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/10] maple_tree: Preserve the tree attributes when destroying maple tree To: Liam.Howlett@oracle.com Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Peng Zhang , corbet@lwn.net, akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org, surenb@google.com, michael.christie@oracle.com, mjguzik@gmail.com, mathieu.desnoyers@efficios.com, npiggin@gmail.com, peterz@infradead.org, oliver.sang@intel.com, mst@redhat.com References: <20231009090320.64565-1-zhangpeng.00@bytedance.com> <20231009090320.64565-10-zhangpeng.00@bytedance.com> From: Peng Zhang In-Reply-To: <20231009090320.64565-10-zhangpeng.00@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 16B87A0030 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hb7t7s3hrnrirgoraa14er1eu4g9ks6t X-HE-Tag: 1697038961-419983 X-HE-Meta: U2FsdGVkX1/9vWEnNLMU+K3hRx1/Fw/X5txXgZmJdCjwMSRSFQq6MsONsvaJCsUYXl31/XVtSUtnZnC6pt241u2owb/Mu0sz4X8oxvohaRvnPxCq1fKWDaOyUPNynwTwwbzkQ8OOoKuVtBDbLND4SQUtRihEFe22DSDN8OTXpk30zCiTsSkSVTemc6xg5BARy3d+tB2bS7RfG2DStEINmEzwAK92GaPmScskUggV9I8gBUOyaZbpI9tvhRZW/1GZE1tIbvQKT00LgPkL0G+znmJTWHk0lzlSJlzjlOE00cf/tu+aabzky758rZeo0sNHMjvQyDaHYewsVMAoNUDY5PBkMsPJ4vTNn+Js5Ni2LXHpbA271oyrGU2ZyfLQWyAI9ZtVrlgRs4cEeslsxSb+j/OsnBkQGSbDtkFEFccbmOMeevPQgM1jpC4qVhhMvMt4/CZs9nms+N0hyFZpjzrC8NawNUd5rCDizd/ErhQkEYL+qgcN69tuLeMNJyBTJyMZl9olCo+FZke8w4WOJKHhIosDrcIjWZswngyXIQ0aFmXTsa5y9nuYw/ULLWpRo7u1T3KmMInbGY2aR8soCU3YsPWkBwpH8rRT9YOMUqTgZoHgTLK5TsiPOayBFWLdpvacwd7cM1n/XAx3HXtmQrcMUH/GIkwRc0XHPh24d0yJRQIfXLjoy91HTDZ/zUjClGwFzY82iMYl1keg8fJ+MPjulyxV+PXWAHPkxLqWCOJRd4ELMKhSR0kzKF9ksRz36fzdEqN+9b6EaSyfMDIA/au4sVV3Sape2cZw1AvtD1wdIyjIJD9ZA3rUTAUJcxKqEFTz8NflfgWmX3iJRHnfdpH7Qo7uvB7GPuevQsKO3w3izvOdvWPyyfyLVsIMJa+cNnWE29Lkhz9CMvwNrn/jmTyV9rrvYjEgaz6UDs20K53yXLx796V834GVU89YimTyPvOpMeWskMibl7YfFtK1Yg6 Wwuh6O7A AjJ+E8sF6+N9XiBUCh7OAGqSlNFCVxwk4LEzvulsfFrrne7DMXMi7q/HHChFxKvtaeBDFd03odAeLfUYCdofOMlai+eVcRilTqstV51SmV+VNwt1oPSvRpvoRvDvixddthZxz8ro1geW/+lQ2YShsMl033+qrOACPV9ETqRditB93DjJ//GleliW4+wCeGBAL5jqJAG8Xnc8SwBPHUj5xbTYNpKQEJXBXC5PhLRz0LDAkCiTxCXs/mV2JuaUbF5ICEvjJo/AK797dNxYRHYg0K93KrUmjcB4gslVumC+P29P4UJd7T3aP7r5+5CuKX3oLviZPlH+HbwMxw41K210Qnzu09AdMtv/xm94H/SR1qqQNPGZeAkgXejx3ISnctzWby9BjT3c+QcIfr6KxKdNE1rP7TolaPiCaWS78zpQMpqE23Wk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/10/9 17:03, Peng Zhang 写道: > When destroying maple tree, preserve its attributes and then turn it > into an empty tree. This allows it to be reused without needing to be > reinitialized. > > Signed-off-by: Peng Zhang > --- > lib/maple_tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index d5544382ff15..1745242092fb 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -6775,7 +6775,7 @@ void __mt_destroy(struct maple_tree *mt) > if (xa_is_node(root)) > mte_destroy_walk(root, mt); > > - mt->ma_flags = 0; > + mt->ma_flags = mt_attr(mt)If I put everything into exit_mmap() for handling, this patch would not be necessary. But I think this patch is reasonable as it simply deletes all elements without requiring us to reinitialize the tree. What do you think? > } > EXPORT_SYMBOL_GPL(__mt_destroy); >