From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C81AD1AD50 for ; Wed, 16 Oct 2024 12:37:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 066A96B00A1; Wed, 16 Oct 2024 08:37:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 016466B00A2; Wed, 16 Oct 2024 08:37:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6ED36B00A3; Wed, 16 Oct 2024 08:37:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C81436B00A1 for ; Wed, 16 Oct 2024 08:37:43 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E42C3C018D for ; Wed, 16 Oct 2024 12:37:32 +0000 (UTC) X-FDA: 82679416386.09.3885ADE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 79E15A0026 for ; Wed, 16 Oct 2024 12:37:35 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729082070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yR3aWnu4kdJpgkkDNz0LPcuu+EE+FEJCfdQgwyE1VPw=; b=NaX4hPUglBqw1k0C8ptw3s53Fb8RzHVp3AssZW1zLfKr3C8/DR00fHMRl7pMOdRoUtVWzJ 2kiUHwXWlqYPk0EKmB/0fjbxhu3pJsNpAzd3x8LydrGuADDxEj+jeL4dTSmkIDgAUkQm5f 1guNAzd+V/L7afB73b0QkVoBVDZD/hU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729082070; a=rsa-sha256; cv=none; b=j5vtnhYArQ1feovrtg5B2vs0OHj50WN+K8/Qlhnmap04UKTnJr+WYosODJhHVz7GBOyS+8 X/aqtO97CRaIWP3ONMOPYasKoozSu1P6CBukGGCW2Te/+S7sbYRSLMF4Xs4ryfMyGYV6jn KDmfyr8aWg4swW5U37JuXFr9w8qohuY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B27AFEC; Wed, 16 Oct 2024 05:38:10 -0700 (PDT) Received: from [10.163.39.8] (unknown [10.163.39.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC7783F528; Wed, 16 Oct 2024 05:37:38 -0700 (PDT) Message-ID: <162ff655-0c55-4aa8-9ca2-3f818a1233cd@arm.com> Date: Wed, 16 Oct 2024 18:07:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: numa_clear_kernel_node_hotplug: Add NUMA_NO_NODE check for node id To: Nobuhiro Iwamatsu , linux-mm@kvack.org, Andrew Morton Cc: linux-kernel@vger.kernel.org, yuji2.ishikawa@toshiba.co.jp, Mike Rapoport References: <1729070461-13576-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <1729070461-13576-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 79E15A0026 X-Stat-Signature: mqgoomb4hmdbrkk5odx5mxju538358p4 X-Rspam-User: X-HE-Tag: 1729082255-310526 X-HE-Meta: U2FsdGVkX19dh5vz3lNgtcWEsE17ZvRMd2VrJoMn7OUVbopOtODAqtM3PLbyXznyFu+TsukInHTieUCCz1HwKBi4i/s15bvZuZwC/hVrCIqjOiWvCt9m4Ti0BYG8eNDS8nzsHn+97j6y+MDjGUjyqzdDWFMFazIsJ2FD+QuFqQEPgyd2v6nTePKmdWIRTTMcI+2eTjCtrk4M8diFCwuGwIZiJ7rWWVYQC7YtLn6xOcJwoHGIU7KpX1Opxo4F/hdTxdqlXXD2HpgsHW35tqMHM/lZRqID6UiX9/zNvPKcyRv0VOz40tBsW0KU3k3SQ8dU4grwCSpq/HXKzl4ctLRH9E0QkUwtKsoC0KId1d/X2TqfyTdBCdufC/8dnp49dNhs8iGMa2XrWIBOz8wA1NfaF1Xhs5Fs0Q/Ys/QA6qr5bT1RSEy4juFz2XK07ufX7y4InehVQmBXlqD4U/FAliMqCWStG3VvHdCwhCwOGJzD6V2g7e1EaohEq6OhIR/YCDLXlo9aAoSh0rv6prlbnPyvC6KoC3VCB8uewi/9F4Ig2+lqby6U4xGv62Ti+qtImZ1k0jUMuly74O380uJBOUC4QmTQ5qppj53jw3wdqu+rkIUIo8tkeqgjjuysOYuPDxHdOEyaGnYsvO8UZ7KwPz14BWFFUS4n4wqoAFwcPZmFrbQ5HN6DHiQztUgWkWdnRpEDyqSvt5dWCfOWPgymwq/BSnC5kqc1l8kYd1/fox0UNTujSQpg1lbdAIMBJZvmCeQLTNcVBdOG2jme9nP6glE+DxWSpIqb8MhaGABaa1Dy4VKN6t9Kp/IhySysl4r+FDnr3IR3Eo5l2/Swu+4/C9fo+KnIVQDRWuF9ohDWXewtCgoO1AhpCdI3MNO0W/5tui+1zJMDpcsJWna51JCghT9mrkWUMi/qlniJ5IMG8K+OdDoh1v62LDgEYBR1N94UQ4ER2ABvhF4aCUDWH3QlLFw YpIV6B77 t+BuDFadQynJFKOvJztxKvBCQA/HvoLkNobt69d7UZ2RfCOKi48/JMLFheelCMM/kdl6bEUYwnxrRvgjriG4QHu6x42aVYpHK89ffng8LcPUlPi1aiYvgG04aIVaMkdBNhuOgkhwtkS9/Wllg1WnGfldwnS6b6W34RtC544Vy4N7dTOdqdG7VBpFZMgvu9aWgru1u/DejaSHCfK9TexFAZiWqTy7Xqwv+A9LMVAidiyS+mpXw982t9D57tEbOSuHcOxAHy/csJBL1PAE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/16/24 14:51, Nobuhiro Iwamatsu wrote: > The acquired memory blocks for reserved may include blocks outside of > memory management. In this case, the nid variable is set to NUMA_NO_NODE > (-1), so an error occurs in node_set(). > This adds a check using numa_valid_node() to numa_clear_kernel_node_hotplug() > that skips node_set() when nid is set to NUMA_NO_NODE. > > Fixes: 87482708210f ("mm: introduce numa_memblks") > Cc: Mike Rapoport (Microsoft) > Reviewed-by: Mike Rapoport (Microsoft) > Suggested-by: Yuji Ishikawa > Signed-off-by: Nobuhiro Iwamatsu > --- > mm/numa_memblks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > v2: > - Use numa_valid_node() instead of check. > - Add Reviewed-by: Mike Rapoport (Microsoft) > - Update description. > - Drop RFC from subject. > > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > index be52b93a9c58..a3877e9bc878 100644 > --- a/mm/numa_memblks.c > +++ b/mm/numa_memblks.c > @@ -349,7 +349,7 @@ static void __init numa_clear_kernel_node_hotplug(void) > for_each_reserved_mem_region(mb_region) { > int nid = memblock_get_region_node(mb_region); > > - if (nid != MAX_NUMNODES) > + if (numa_valid_node(nid)) > node_set(nid, reserved_nodemask); > } > Reviewed-by: Anshuman Khandual