From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A1CC3DA60 for ; Wed, 17 Jul 2024 19:36:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98D096B0082; Wed, 17 Jul 2024 15:36:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93C6C6B0083; Wed, 17 Jul 2024 15:36:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B79B6B0085; Wed, 17 Jul 2024 15:36:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 60E396B0082 for ; Wed, 17 Jul 2024 15:36:03 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 19390120C33 for ; Wed, 17 Jul 2024 19:36:03 +0000 (UTC) X-FDA: 82350250206.27.74E514C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 6CEBB100014 for ; Wed, 17 Jul 2024 19:35:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZaaVHRXh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="G7jZb1e/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZaaVHRXh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="G7jZb1e/"; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721244921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+M+Pn7zfpnilj1S7DATFhnaQ3aerhqqQI9HJEiiY/4=; b=nTCST/sFQHaV6AKn+NjtLTE9aPtZR3qWri/OQ6andozjip7+/wex1vaDr0Dz1O9rKEoF4Q a5uOvc89TTZgbzMksSwXW07sQ7AViTD9CNqA5+RehXvoAS6adFn+/DIbDbfGpBv5cQHFcZ AloUuA3iPpF+b2PinAEn94eJGLi8ydc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721244921; a=rsa-sha256; cv=none; b=l4KJq7ld+i7pqQq9vYFccq3S9u81PCzu0+jvHfgejTgs6KFyvIbJafFCiS0F3UaVbOnMsH FTOQc1xzIMTQhiOvK6ClIwNVdvygYDu7cqEEodZubWEgodKmPsGHvTAWWu/14W51jcvjGR 88B62fJiQEULBq3Q2CaSz6+1PndTih8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZaaVHRXh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="G7jZb1e/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZaaVHRXh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="G7jZb1e/"; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 27E571FB98; Wed, 17 Jul 2024 19:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721244957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+M+Pn7zfpnilj1S7DATFhnaQ3aerhqqQI9HJEiiY/4=; b=ZaaVHRXhsLIMhOIH6x8Pos36JTHpnUIkdVpUN3FH3jhen6eeqzZFr0KW72H2cdqeLCR4ec WKMVQCihtxFMRiFxsJtbPPogSoAEpUE/2vAYc/y6y2tvw11ZpUx86wcTpbIpIQGmfyrmFW AuxC8DaM18fN1evvoiavF5TRHEWanv4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721244957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+M+Pn7zfpnilj1S7DATFhnaQ3aerhqqQI9HJEiiY/4=; b=G7jZb1e/z4SmpZub/w6ZRRyPqbkSf8dlkwiaKEITECRbRXerigPq5tgPHmq4h7QdcyS1bE +gWbVdlWuGj55jAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721244957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+M+Pn7zfpnilj1S7DATFhnaQ3aerhqqQI9HJEiiY/4=; b=ZaaVHRXhsLIMhOIH6x8Pos36JTHpnUIkdVpUN3FH3jhen6eeqzZFr0KW72H2cdqeLCR4ec WKMVQCihtxFMRiFxsJtbPPogSoAEpUE/2vAYc/y6y2tvw11ZpUx86wcTpbIpIQGmfyrmFW AuxC8DaM18fN1evvoiavF5TRHEWanv4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721244957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+M+Pn7zfpnilj1S7DATFhnaQ3aerhqqQI9HJEiiY/4=; b=G7jZb1e/z4SmpZub/w6ZRRyPqbkSf8dlkwiaKEITECRbRXerigPq5tgPHmq4h7QdcyS1bE +gWbVdlWuGj55jAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 11A5B136E5; Wed, 17 Jul 2024 19:35:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dkb+Ax0dmGbsXAAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 19:35:57 +0000 Message-ID: <16286915-1350-4e6b-a0f6-deec02b7fa92@suse.cz> Date: Wed, 17 Jul 2024 21:35:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] alloc_tag: outline and export free_reserved_page() Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, hch@infradead.org, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot References: <20240717181239.2510054-1-surenb@google.com> <20240717181239.2510054-2-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240717181239.2510054-2-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6CEBB100014 X-Stat-Signature: uq1m3r5b133jo64nkwgawxzmspotcti3 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721244959-60833 X-HE-Meta: U2FsdGVkX183MTCgm1+79mL136mKY6TEL91yyx4RzIChPn6dqRauBcg0hVZTUShTCyibHCQErbcm3NGVfoaVFsHZ+GYrnxyIsuI1m1z08wM4+4GbE+9WzXe/4D/5IiGbgA6cIId7FwAhlMo4qty4IgxLEaqD60fxa4zocxAEb7Yrt8aYg4gFSYPgpAUl8cIIaipCnCNu9/gOswA1JSP361bpAULvwGBROyRvDlHPSkOTd+WQ4LD3dseds1SpRm0vKY+pTUTpps81XVwJd3ALD5fWOBHrDoXl7oTSDc7VXd5Kn0EIPGvRk+haovaXbiGahPzr0/yzIEWZwaZ8EmIMWHyk3CJ40MrfuCF8zyVyIZPy1go4B3ZvhtOwJJRvpSxhngeWdUH9sctgoKWAZPDiPackTHl07WNpkjv/fnd9/J2XTbfLqus0/9Xjr7qsv95Rb7mUTUJX09ggqsR1MAhmTrDujDjDA92bksN3qtV7LjMqgO2Sw6iPSrxc1OPr/vAncQMmnk97kKDW186VU0GZMbIqHcpRo5z87HE9YXn2Xk+sgnsptm7/CYjbC/PQFIrOs1ySVSo/Lud1t6F3GrIFjFvxdSdVtZxvoKikdHGnPjiNFgHmNBT45uvZSVxD46oRy2/8jOR8fttgNZLmL9vXHSkQ5Sgj7cuGYTi36h6IfhaS0yRmFZROlqtcYTXJ6l9ygnht9tcGo/ovQhGYr7b/CdeGGUeH1oARcVj7wl0aQCJbFUZ80K4PvNqQmg7fD0gUmZGjc3SDXv8rVdOroAWaIf9xgKVjZHBDfzWSpTe1Z9c5wKgUOKhy5sHOlm/xtODOn2qh/0YyJ09dm1+073M8P2kT32TJ3uGXsYkCXSOe0w9YrLhjmLUCPooSCKCrsq9Lsr0qALWdU1ZmRyrs4krrmzyshE8touNeVeppDJKP6oC8oJeMKk2q/WDB+DGoDROVxwBGk0knpdyZ+vBQ9yV ovakygJO wjaLwvch3QJIQzGP+fzO4SNNvyI0WSJDeH6uCuZPdCAQWOSh2iMZdM5jksZ9Ngzoonw6iFkJyebdZmgNldsXW4kPkSEPyYd/2Tiq1Vr2vdHUQAsl3CzYTFr9buGtD14AXfE1d3SCcRjFglM/V3UJvpc6joKdQTSbUAW8Z2GkQ6FcDPbTy0ilndQedT9R7gFEPxymjdzckyxhEUH5NdU3gy1fY+P0GgDVvMNBtZj0EnC0Q4C5csv9nXOws6HMWz5VSpskxoXlhqSmzN0l3gYx+naXMrDsl7vfW+4EADnM4I128DrksnP8ovzfnjV73lRKjYbNKdFGYHQ9LYzbYN8xWBQX351+xVq0S1/bN2PfAdKrDEfIE+sfF8P3rrz7HKQcdZaH1YMrQoSifxKHRLuF4JTSFXwGDVjSMTzy8dVMzek1OkzRF2CG8EtptOf4qS5qpd6eTVPmDG5c8+qdB7voLZY5dDz748Opiuk0h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/17/24 8:12 PM, Suren Baghdasaryan wrote: > Outline and export free_reserved_page() because modules use it and it > in turn uses page_ext_{get|put} which should not be exported. The same > result could be obtained by outlining {get|put}_page_tag_ref() but that > would have higher performance impact as these functions are used in > more performance critical paths. > > Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/ > Suggested-by: Christoph Hellwig > Suggested-by: Vlastimil Babka > Signed-off-by: Suren Baghdasaryan Acked-by: Vlastimil Babka Are these two patches now stable@ material as 6.10 build is broken on ppc64 with alloc taging enabled? > --- > Changes since v1 [1] > - Outlined and exported free_reserved_page() in place of {get|put}_page_tag_ref, > per Vlastimil Babka > > [1] https://lore.kernel.org/all/20240717011631.2150066-2-surenb@google.com/ > > include/linux/mm.h | 16 +--------------- > mm/page_alloc.c | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+), 15 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index eb7c96d24ac0..b58bad248eef 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3177,21 +3177,7 @@ extern void reserve_bootmem_region(phys_addr_t start, > phys_addr_t end, int nid); > > /* Free the reserved page into the buddy system, so it gets managed. */ > -static inline void free_reserved_page(struct page *page) > -{ > - if (mem_alloc_profiling_enabled()) { > - union codetag_ref *ref = get_page_tag_ref(page); > - > - if (ref) { > - set_codetag_empty(ref); > - put_page_tag_ref(ref); > - } > - } > - ClearPageReserved(page); > - init_page_count(page); > - __free_page(page); > - adjust_managed_page_count(page, 1); > -} > +void free_reserved_page(struct page *page); > #define free_highmem_page(page) free_reserved_page(page) > > static inline void mark_page_reserved(struct page *page) > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 9ecf99190ea2..7d2fa9f5e750 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5805,6 +5805,23 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char > return pages; > } > > +void free_reserved_page(struct page *page) > +{ > + if (mem_alloc_profiling_enabled()) { > + union codetag_ref *ref = get_page_tag_ref(page); > + > + if (ref) { > + set_codetag_empty(ref); > + put_page_tag_ref(ref); > + } > + } > + ClearPageReserved(page); > + init_page_count(page); > + __free_page(page); > + adjust_managed_page_count(page, 1); > +} > +EXPORT_SYMBOL(free_reserved_page); > + > static int page_alloc_cpu_dead(unsigned int cpu) > { > struct zone *zone;